LGTM
For the s390x parts I'm involved in:
Acked-by: Halil Pasic
[..]
> --- a/include/exec/cpu-all.h
> +++ b/include/exec/cpu-all.h
> @@ -34,13 +34,13 @@
>
> /* some important defines:
> *
> - * HOST_WORDS_BIGENDIAN : if defined, the host cpu is big endian and
> + * HO
On Wed, 16 Mar 2022 11:28:59 +0100
Thomas Huth wrote:
> On 16/03/2022 10.53, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > Replace a config-time define with a compile time condition
> > define (compatible with clang and gcc) that must be declared prior to
> > its usage.
On Thu, 23 Sep 2021 16:28:11 +0200
Halil Pasic wrote:
> Can't we use some of the established constants instead of hard coding a
> qemu specific IOV_MAX?
>
> POSIX.1 seems to guarantee the availability of IOV_MAX in
> according to: https://man7.org/linux/man-pages/man2/rea
of the established constants instead of hard coding a
qemu specific IOV_MAX?
POSIX.1 seems to guarantee the availability of IOV_MAX in
according to: https://man7.org/linux/man-pages/man2/readv.2.html
and may have UIO_MAXIOV defined.
>
> Reported-by: Halil Pasic
> Cc: Hanna Reitz
&g
On Thu, 23 Sep 2021 12:57:38 +0200
Paolo Bonzini wrote:
> On 22/09/21 21:51, Halil Pasic wrote:
> > We have figured out what is going on here. The problem seems to be
> > specific to linux aio, which seems to limit the size of the iovec to
> > 1024 (UIO_MAXIOV).
>
>
On Mon, 6 Sep 2021 16:24:20 +0200
Halil Pasic wrote:
> On Fri, 25 Jun 2021 16:18:12 +0200
> Paolo Bonzini wrote:
>
> > bs->sg is only true for character devices, but block devices can also
> > be used with scsi-block and scsi-generic. Unfortunately BLKSECTGET
> &g
On 03/09/2017 03:55 AM, QingFeng Hao wrote:
>
>
> 在 2017/3/8 19:33, Halil Pasic 写道:
>>
>> On 03/08/2017 08:05 AM, QingFeng Hao wrote:
>>>
>>> 在 2017/3/7 18:19, Halil Pasic 写道:
>>>> On 03/07/2017 11:05 AM, Kevin Wolf wrote:
>>>>>
On 03/08/2017 08:05 AM, QingFeng Hao wrote:
>
>
> 在 2017/3/7 18:19, Halil Pasic 写道:
>>
>> On 03/07/2017 11:05 AM, Kevin Wolf wrote:
>>> Am 07.03.2017 um 10:54 hat Halil Pasic geschrieben:
>>>>
>>>> On 03/07/2017 10:29 AM, Kevin Wol
On 03/07/2017 11:05 AM, Kevin Wolf wrote:
> Am 07.03.2017 um 10:54 hat Halil Pasic geschrieben:
>>
>>
>> On 03/07/2017 10:29 AM, Kevin Wolf wrote:
>>> Am 07.03.2017 um 03:53 hat QingFeng Hao geschrieben:
>>>> I am not very clear about the l
On 03/07/2017 11:03 AM, Dr. David Alan Gilbert wrote:
> * Halil Pasic (pa...@linux.vnet.ibm.com) wrote:
>>
>>
>> On 03/07/2017 10:29 AM, Kevin Wolf wrote:
>>> Am 07.03.2017 um 03:53 hat QingFeng Hao geschrieben:
>>>> I am not very clear about the l
On 03/07/2017 10:29 AM, Kevin Wolf wrote:
> Am 07.03.2017 um 03:53 hat QingFeng Hao geschrieben:
>> I am not very clear about the logic in vmstate.c, but from its context in
>> vmstate_save_state, it seems size should not be 0, otherwise the followed
>> for loop will keep working on the same elem
On 10/14/2016 05:59 PM, Stefan Hajnoczi wrote:
> On Tue, Oct 11, 2016 at 04:12:35PM +0200, Halil Pasic wrote:
>> > Make raw_open for POSIX more consistent in handling errors by setting
>> > the error object also when qemu_open fails. The error object was set
>> > g
Make raw_open for POSIX more consistent in handling errors by setting
the error object also when qemu_open fails. The error object was set
generally set in case of errors, but I guess this case was overlooked.
Do the same for win32.
Signed-off-by: Halil Pasic
Reviewed-by: Sascha Silbe
Tested-by
Make raw_open for POSIX more consistent in handling errors by setting
the error object also when qemu_open fails. The error object was set
generally set in case of errors, but I guess this case was overlooked.
Do the same for win32.
Signed-off-by: Halil Pasic
Reviewed-by: Sascha Silbe
Tested-by
On 07/27/2016 04:37 PM, Max Reitz wrote:
>> Now if you examine #1 drive_new(all_opts,block_default_type) you see,
>> > there is no errp argument and if you examine the code you see that the
>> > error from blockdev_init which gets propagated properly to this point
>> > gets "handled" by error_rep
On 07/27/2016 05:28 PM, Halil Pasic wrote:
> Make raw_open for POSIX more consistent in handling errors by setting
> the error object also when qemu_open fails. The error object was set
> generally set in case of errors, but I guess this case was overlooked.
> Do the same for win32.
Make raw_open for POSIX more consistent in handling errors by setting
the error object also when qemu_open fails. The error object was set
generally set in case of errors, but I guess this case was overlooked.
Do the same for win32.
Signed-off-by: Halil Pasic
Reviewed-by: Sascha Silbe
Tested-by
On 07/26/2016 07:47 PM, Max Reitz wrote:
>> Frankly, I'm a bit uncomfortable with asking (do not want to be pushy),
>> > but do you have an opinion on the 'error_report_err' issue (pointed
>> > out in the cover letter part)?
> You are using drive_add with QMP? As far as I know, one can only do so
On 07/26/2016 05:42 PM, Max Reitz wrote:
>> +++ b/block/raw-posix.c
>> > @@ -485,6 +485,7 @@ static int raw_open_common(BlockDriverState *bs, QDict
>> > *options,
>> > s->fd = -1;
>> > fd = qemu_open(filename, s->open_flags, 0644);
>> > if (fd < 0) {
>> > +error_setg_errno
Make raw_open for POSIX more consistent in handling errors by setting
the error object also when qemu_open fails. The error object was set
generally set in case of errors, but I guess this case was overlooked.
Do the same for win32.
Signed-off-by: Halil Pasic
Reviewed-by: Sascha Silbe
Tested-by
On 07/18/2016 05:57 PM, Max Reitz wrote:
> On 18.07.2016 17:48, Halil Pasic wrote:
>>
>>
>> On 07/18/2016 04:41 PM, Max Reitz wrote:
>>> On 18.07.2016 14:30, Halil Pasic wrote:
>>>> Make raw_open for POSIX more consistent in handling errors by setting
On 07/18/2016 04:41 PM, Max Reitz wrote:
> On 18.07.2016 14:30, Halil Pasic wrote:
>> Make raw_open for POSIX more consistent in handling errors by setting
>> the error object also when qemu_open fails. The error object was
>> generally set in case of errors, but I guess thi
Make raw_open for POSIX more consistent in handling errors by setting
the error object also when qemu_open fails. The error object was
generally set in case of errors, but I guess this case was overlooked.
Do the same for win32.
Signed-off-by: Halil Pasic
Reviewed-by: Cornelia Huck
Reviewed-by
EMU_ARCH_S390X },
> +{ "virtio-net-pci", "virtio-net", QEMU_ARCH_ALL & ~QEMU_ARCH_S390X },
> { "virtio-serial-ccw", "virtio-serial", QEMU_ARCH_S390X },
> -{ "lsi53c895a", "lsi" },
> -{ "ich9-ahci", "ahci" },
> -{ "kvm-pci-assign", "pci-assign" },
> -{ "e1000", "e1000-82540em" },
> +{ "virtio-serial-pci", "virtio-serial", QEMU_ARCH_ALL & ~QEMU_ARCH_S390X
> },
> { }
> };
>
Reviewed-by: Halil Pasic
24 matches
Mail list logo
