Re: [PATCH v2 03/13] hw/arm/npcm7xx_boards: Replace drive_get_next() by drive_get()

2021-11-17 Thread Havard Skinnemoen
ive_get_next(), but with a helper function. Change it to use > drive_get() directly. This makes the unit numbers explicit in the > code. > > Cc: Havard Skinnemoen > Cc: Tyrone Ting > Cc: Peter Maydell > Cc: qemu-...@nongnu.org > Signed-off-by: Markus Armbruster > --- >

Re: [PATCH 0/9] hw/block: m25p80: Fix the mess of dummy bytes needed for fast read commands

2021-01-14 Thread Havard Skinnemoen via
Hi Bin, On Thu, Jan 14, 2021 at 6:08 PM Bin Meng wrote: > > Hi Francisco, > > On Fri, Jan 15, 2021 at 2:13 AM Francisco Iglesias > wrote: > > > > Hi Bin, > > > > On [2021 Jan 14] Thu 23:08:53, Bin Meng wrote: > > > From: Bin Meng > > > > > > The m25p80 model uses s->needed_bytes to indicate

Re: [PATCH v5 10/11] hw/arm: Wire up BMC boot flash for npcm750-evb and quanta-gsj

2020-07-17 Thread Havard Skinnemoen
On Fri, Jul 17, 2020 at 1:52 PM Philippe Mathieu-Daudé wrote: > > On 7/17/20 9:18 PM, Havard Skinnemoen wrote: > > On Fri, Jul 17, 2020 at 2:00 AM Philippe Mathieu-Daudé > > wrote: > >> > >> On 7/17/20 10:27 AM, Philippe Mathieu-Daudé wrote: > >

Re: [PATCH v5 10/11] hw/arm: Wire up BMC boot flash for npcm750-evb and quanta-gsj

2020-07-17 Thread Havard Skinnemoen
On Fri, Jul 17, 2020 at 2:00 AM Philippe Mathieu-Daudé wrote: > > On 7/17/20 10:27 AM, Philippe Mathieu-Daudé wrote: > > On 7/17/20 10:03 AM, Thomas Huth wrote: > >> On 17/07/2020 09.48, Philippe Mathieu-Daudé wrote: > >>> +Thomas > >> > >

Re: [PATCH v5 10/11] hw/arm: Wire up BMC boot flash for npcm750-evb and quanta-gsj

2020-07-16 Thread Havard Skinnemoen
On Wed, Jul 15, 2020 at 1:54 PM Havard Skinnemoen wrote: > > On Wed, Jul 15, 2020 at 3:57 AM Philippe Mathieu-Daudé > wrote: > > > > On 7/15/20 11:00 AM, Markus Armbruster wrote: > > > Now my point. Why first make up user configuration, then use that to > &g

Re: [PATCH v5 10/11] hw/arm: Wire up BMC boot flash for npcm750-evb and quanta-gsj

2020-07-15 Thread Havard Skinnemoen
On Wed, Jul 15, 2020 at 3:57 AM Philippe Mathieu-Daudé wrote: > > On 7/15/20 11:00 AM, Markus Armbruster wrote: > > Now my point. Why first make up user configuration, then use that to > > create a BlockBackend, when you could just go ahead and create the > > BlockBackend? > > CLI issue mostly.