Re: RFC: tracking valid backing chain issue

2020-10-22 Thread Nikolay Shirokovskiy
On 21.10.2020 13:56, Kevin Wolf wrote: > Am 20.10.2020 um 12:29 hat Nikolay Shirokovskiy geschrieben: >> >> >> On 20.10.2020 13:23, Nikolay Shirokovskiy wrote: >>> >>> >>> On 20.10.2020 11:50, Kevin Wolf wrote: >>>> Am 20.10.2020

Re: RFC: tracking valid backing chain issue

2020-10-20 Thread Nikolay Shirokovskiy
On 20.10.2020 13:23, Nikolay Shirokovskiy wrote: > > > On 20.10.2020 11:50, Kevin Wolf wrote: >> Am 20.10.2020 um 10:21 hat Nikolay Shirokovskiy geschrieben: >>> Hi, all. >>> >>> I recently found a corner case when it is impossible AFAIK to find out

Re: RFC: tracking valid backing chain issue

2020-10-20 Thread Nikolay Shirokovskiy
On 20.10.2020 11:50, Kevin Wolf wrote: > Am 20.10.2020 um 10:21 hat Nikolay Shirokovskiy geschrieben: >> Hi, all. >> >> I recently found a corner case when it is impossible AFAIK to find out valid >> backing chain after block commit operation. Imagine committing top

RFC: tracking valid backing chain issue

2020-10-20 Thread Nikolay Shirokovskiy
Hi, all. I recently found a corner case when it is impossible AFAIK to find out valid backing chain after block commit operation. Imagine committing top image. After commit ready state pivot is sent and then mgmt crashed. So far so good. Upon next start mgmt can either check block job status for

Re: [Qemu-block] [PATCH v2 3/6] nbd: Allow bitmap export during QMP nbd-server-add

2019-01-10 Thread Nikolay Shirokovskiy
On 10.01.2019 15:02, Vladimir Sementsov-Ogievskiy wrote: > cc Nikolay > > 10.01.2019 10:13, Eric Blake wrote: >> With the experimental x-nbd-server-add-bitmap command, there was >> a window of time where an NBD client could see the export but not >> the associated dirty bitmap, which can cause

Re: [Qemu-block] [PATCH 1/2] qapi: support device id for x-block-latency-histogram-set

2018-10-02 Thread Nikolay Shirokovskiy
On 02.10.2018 17:22, Eric Blake wrote: > On 10/2/18 6:33 AM, Vladimir Sementsov-Ogievskiy wrote: >> Support modern way of device selecting. >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> --- >>   qapi/block-core.json | 6 -- >>   blockdev.c   | 8 +--- >>   2 files changed,

Re: [Qemu-block] [PATCH v5 5/6] qapi: new qmp command nbd-server-add-bitmap

2018-06-21 Thread Nikolay Shirokovskiy
On 20.06.2018 17:13, Vladimir Sementsov-Ogievskiy wrote: > 20.06.2018 14:26, Eric Blake wrote: >> On 06/09/2018 10:17 AM, Vladimir Sementsov-Ogievskiy wrote: >>> Signed-off-by: Vladimir Sementsov-Ogievskiy >>> --- >>>   qapi/block.json | 23 +++ >>>   blockdev-nbd.c  | 23

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.12 0/4] qmp dirty bitmap API

2017-12-20 Thread Nikolay Shirokovskiy
On 20.12.2017 04:06, John Snow wrote: > > > On 12/19/2017 11:07 AM, Vladimir Sementsov-Ogievskiy wrote: >> 13.12.2017 07:12, Fam Zheng wrote: >>> On Mon, 11/13 19:20, Vladimir Sementsov-Ogievskiy wrote: Hi all. There are three qmp commands, needed to implement external backup

Re: [Qemu-block] [PATCH v2 0/4] blockjobs: add explicit job reaping

2017-10-09 Thread Nikolay Shirokovskiy
Hi, John. This is the original letter https://lists.nongnu.org/archive/html/qemu-devel/2016-11/msg04091.html. In short problem is next. If during full backup I miss the completion event I don't know whether backup file is correct or not. If I miss the event during incremental backup