Re: [PULL 0/1] Block patches

2024-09-17 Thread Peter Maydell
On Tue, 17 Sept 2024 at 12:44, Stefan Hajnoczi wrote: > > The following changes since commit ea9cdbcf3a0b8d5497cddf87990f1b39d8f3bb0a: > > Merge tag 'hw-misc-20240913' of https://github.com/philmd/qemu into staging > (2024-09-15 18:27:40 +0100) > > are available in the Git repository at: > >

Re: [PATCH 1/2] hw/sd: Remove legacy sd_set_cb()

2024-09-13 Thread Peter Maydell
On Fri, 13 Sept 2024 at 09:28, Markus Armbruster wrote: > > Peter Maydell writes: > > > On Tue, 3 Sept 2024 at 21:04, Philippe Mathieu-Daudé > > wrote: > >> > >> sd_set_cb() was only used by omap2_mmc_init() which > >> got recently removed. Time

Re: [PATCH v2 14/48] include/hw/s390x: replace assert(false) with g_assert_not_reached()

2024-09-12 Thread Peter Maydell
On Thu, 12 Sept 2024 at 12:59, Philippe Mathieu-Daudé wrote: > > On 12/9/24 09:38, Pierrick Bouvier wrote: > > This patch is part of a series that moves towards a consistent use of > > g_assert_not_reached() rather than an ad hoc mix of different > > assertion mechanisms. > > > > Reviewed-by: Rich

Re: [PATCH] docs/devel: Prohibit calling object_unparent() for memory region

2024-09-10 Thread Peter Maydell
On Tue, 10 Sept 2024 at 18:27, Michael S. Tsirkin wrote: > > On Thu, Aug 29, 2024 at 02:46:48PM +0900, Akihiko Odaki wrote: > > Previously it was allowed to call object_unparent() for a memory region > > in instance_finalize() of its parent. However, such a call typically > > has no effect because

Re: [PULL 00/10] Crypto fixes patches

2024-09-09 Thread Peter Maydell
On Mon, 9 Sept 2024 at 15:17, Daniel P. Berrangé wrote: > > The following changes since commit f2aee60305a1e40374b2fc1093e4d04404e780ee: > > Merge tag 'pull-request-2024-09-08' of https://gitlab.com/huth/qemu into > staging (2024-09-09 10:47:24 +0100) > > are available in the Git repository at:

Re: [PATCH 1/2] hw/sd: Remove legacy sd_set_cb()

2024-09-09 Thread Peter Maydell
On Tue, 3 Sept 2024 at 21:04, Philippe Mathieu-Daudé wrote: > > sd_set_cb() was only used by omap2_mmc_init() which > got recently removed. Time to remove it. For historical > background on the me_no_qdev_me_kill_mammoth_with_rocks > kludge, see commit 007d1dbf72 ("sd: Hide the qdev-but-not-quite

Re: [PATCH 2/2] hw/sd: Remove legacy sd_enable()

2024-09-09 Thread Peter Maydell
gt; return dummy_byte; > > if (sd->state != sd_sendingdata_state) { Maybe add the { } that coding style wants to these if()s since we're editing them anyway? Either way, Reviewed-by: Peter Maydell thanks -- PMM

Re: [PULL 0/5] ufs queue

2024-09-07 Thread Peter Maydell
On Fri, 6 Sept 2024 at 11:58, Jeuk Kim wrote: > > From: Jeuk Kim > > The following changes since commit 7b87a25f49a301d3377f3e71e0b4a62540c6f6e4: > > Merge tag 'edgar/xen-queue-2024-09-04.for-upstream' of > https://gitlab.com/edgar.iglesias/qemu into staging (2024-09-05 13:02:26 > +0100) > >

Re: [PATCH 0/3] hw/sh4: Remove the deprecated SHIX machine

2024-09-03 Thread Peter Maydell
OM > hw/sh4: Remove sh7750_register_io_device() helper Whole series: Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v4 7/7] tests/qtest: Delete previous boot file

2024-08-27 Thread Peter Maydell
On Tue, 27 Aug 2024 at 15:03, Fabiano Rosas wrote: > > Thomas Huth writes: > > > On 26/08/2024 17.26, Peter Xu wrote: > >> On Fri, Aug 23, 2024 at 03:13:12PM +0900, Akihiko Odaki wrote: > >>> A test run may create boot files several times. Delete the previous boot > >>> file before creating a new

Re: [PATCH v4 6/7] memory: Do not create circular reference with subregion

2024-08-26 Thread Peter Maydell
On Mon, 26 Aug 2024 at 16:22, Peter Xu wrote: > > On Fri, Aug 23, 2024 at 03:13:11PM +0900, Akihiko Odaki wrote: > > memory_region_update_container_subregions() used to call > > memory_region_ref(), which creates a reference to the owner of the > > subregion, on behalf of the owner of the containe

Re: [PATCH 7/7] block/ssh.c: Don't double-check that characters are hex digits

2024-07-31 Thread Peter Maydell
On Wed, 31 Jul 2024 at 16:21, Kevin Wolf wrote: > > Am 31.07.2024 um 16:36 hat Peter Maydell geschrieben: > > In compare_fingerprint() we effectively check whether the characters > > in the fingerprint are valid hex digits twice: first we do so with > > qemu_isxdigit(),

Re: [PATCH 4/7] hw/ide/atapi: Be explicit that assigning to s->lcyl truncates

2024-07-31 Thread Peter Maydell
On Wed, 31 Jul 2024 at 15:47, Markus Armbruster wrote: > > Peter Maydell writes: > > > In ide_atapi_cmd_reply_end() we calculate a 16-bit size, and then > > assign its two halves to s->lcyl and s->hcyl like this: > > > >s->lcyl

[PATCH 3/7] hw/block/pflash_cfi01: Don't decrement pfl->counter below 0

2024-07-31 Thread Peter Maydell
; the only way back into code which looks at the counter value is via wcycle == 1, which will reinitialize the counter. But it's arguably a little clearer to break early in the "counter == 0" if(), to avoid the decrement-below-zero. Resolves: Coverity CID 1547611 Signed-off-by:

[PATCH 2/7] block/gluster: Use g_autofree for string in qemu_gluster_parse_json()

2024-07-31 Thread Peter Maydell
ty CID 1527385 Signed-off-by: Peter Maydell --- block/gluster.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/block/gluster.c b/block/gluster.c index f8b415f3812..61ded95e660 100644 --- a/block/gluster.c +++ b/block/gluster.c @@ -514,7 +514,6 @@ static in

[PATCH 4/7] hw/ide/atapi: Be explicit that assigning to s->lcyl truncates

2024-07-31 Thread Peter Maydell
rue, and in this case we're deliberately only after the low 8 bits of the value. The code is clearer to both humans and Coverity if we're explicit that we only wanted the low 8 bits, though. Signed-off-by: Peter Maydell --- hw/ide/atapi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(

[PATCH 6/7] hw/ide/pci.c: Remove dead code from bmdma_prepare_buf()

2024-07-31 Thread Peter Maydell
notice that this meant we should also remove the code at the end of the loop. Remove the dead code. Resolves: Coverity CID 1547772 Signed-off-by: Peter Maydell --- hw/ide/pci.c | 4 1 file changed, 4 deletions(-) diff --git a/hw/ide/pci.c b/hw/ide/pci.c index 4675d079a17..f2cb500a94f 100644

[PATCH 5/7] hw/block/fdc-isa: Assert that isa_fdc_get_drive_max_chs() found something

2024-07-31 Thread Peter Maydell
y for each FloppyDriveType, so we must at least once find a match and update *maxc, *maxh and *maxs. Assert that we did find a match, which should keep Coverity happy and will also detect possible bugs in the data in fd_formats. Resolves: Coverity CID 1547663 Signed-off-by: Peter Maydell --- hw/bloc

[PATCH 7/7] block/ssh.c: Don't double-check that characters are hex digits

2024-07-31 Thread Peter Maydell
complain because it thinks that we might use that -1 value in an expression where it would be an integer overflow. Avoid the double-check of hex digit validity by testing the return values from hex2decimal() rather than doing separate calls to qemu_isxdigit(). Signed-off-by: Peter Maydell --- Could

[PATCH 0/7] block: Miscellaneous minor Coverity fixes

2024-07-31 Thread Peter Maydell
(with "make check" and "make check-avocado"). thanks -- PMM Peter Maydell (7): block/vdi.c: Avoid potential overflow when calculating size of write block/gluster: Use g_autofree for string in qemu_gluster_parse_json() hw/block/pflash_cfi01: Don't decrement pfl->c

[PATCH 1/7] block/vdi.c: Avoid potential overflow when calculating size of write

2024-07-31 Thread Peter Maydell
map has 4 bytes per block and the maximum number of blocks in the image must fit into a 32-bit integer. But we can keep Coverity happy by including a cast so we do a 64-bit multiply here. Resolves: Coverity CID 1508076 Signed-off-by: Peter Maydell --- block/vdi.c | 2 +- 1 file changed, 1 insert

Re: [PATCH] util/async.c: Forbid negative min/max in aio_context_set_thread_pool_params()

2024-07-23 Thread Peter Maydell
On Tue, 23 Jul 2024 at 16:44, Philippe Mathieu-Daudé wrote: > > On 23/7/24 17:09, Peter Maydell wrote: > > aio_context_set_thread_pool_params() takes two int64_t arguments to > > set the minimum and maximum number of threads in the pool. We do > > some bounds checkin

[PATCH] util/async.c: Forbid negative min/max in aio_context_set_thread_pool_params()

2024-07-23 Thread Peter Maydell
47605 Signed-off-by: Peter Maydell --- util/async.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/async.c b/util/async.c index 0467890052a..3e3e4fc7126 100644 --- a/util/async.c +++ b/util/async.c @@ -746,7 +746,7 @@ void aio_context_set_thread_pool_params(AioContext

Re: [PATCH 2/2] nvme/ctrl: remove useless type cast

2024-07-22 Thread Peter Maydell
NvmeRequest *req) > { > -NvmeCmd *cmd = (NvmeCmd *)&req->cmd; > +NvmeCmd *cmd = &req->cmd; > NvmeNamespace *ns = req->ns; > /* cdw12 is zero-based number of dwords to return. Convert to bytes */ > uint32_t data_size = (le32_to_cpu(cmd->cdw12) + 1) << 2; > -- > 2.41.0 Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v2 06/15] ppc/vof: Fix unaligned FDT property access

2024-07-08 Thread Peter Maydell
On Mon, 8 Jul 2024 at 08:49, Nicholas Piggin wrote: > > On Sun Jul 7, 2024 at 9:46 AM AEST, David Gibson wrote: > > On Sat, Jul 06, 2024 at 11:37:08AM +0100, Peter Maydell wrote: > > > On Fri, 5 Jul 2024 at 06:13, David Gibson > > > wrote: > > > > Huh..

Re: [PATCH v2 06/15] ppc/vof: Fix unaligned FDT property access

2024-07-06 Thread Peter Maydell
Thu Jul 4, 2024 at 10:15 PM AEST, Peter Maydell wrote: > > > > > On Sat, 29 Jun 2024 at 04:17, David Gibson > > > > > wrote: > > > > > > > > > > > > On Fri, Jun 28, 2024 at 04:20:02PM +0100, Peter Maydell wrote: > > > &g

Re: [PATCH v2 06/15] ppc/vof: Fix unaligned FDT property access

2024-07-04 Thread Peter Maydell
On Sat, 29 Jun 2024 at 04:17, David Gibson wrote: > > On Fri, Jun 28, 2024 at 04:20:02PM +0100, Peter Maydell wrote: > > On Thu, 27 Jun 2024 at 14:39, Akihiko Odaki > > wrote: > > > > > > FDT properties are aligned by 4 bytes, not 8 bytes. >

Re: [PATCH 0/4] Drop ifdef for macOS versions older than 12.0

2024-07-01 Thread Peter Maydell
On Mon, 1 Jul 2024 at 16:07, Konstantin Ryabitsev wrote: > > On Mon, Jul 01, 2024 at 09:00:48PM GMT, Akihiko Odaki wrote: > > > > Signed-off-by: Akihiko Odaki > > > > > > PS: you don't need to put a signed-off-by line on the cover > > > letter, only in the individual patches. > > > > I have been

Re: [PATCH 0/4] Drop ifdef for macOS versions older than 12.0

2024-07-01 Thread Peter Maydell
the vendor itself drops > > support, whichever comes first. > > macOS 12.0 was released 2021: > https://www.apple.com/newsroom/2021/10/macos-monterey-is-now-available/ Further, we have already dropped support for macos < 12 in the ui/cocoa.m code in commit 2d27c91e2b72ac. For th

Re: [PATCH] hw/ide/macio.c: switch from using qemu_allocate_irq() to qdev input GPIOs

2024-06-28 Thread Peter Maydell
b54da6b31..869b66055b 100644 > --- a/include/hw/misc/macio/macio.h > +++ b/include/hw/misc/macio/macio.h > @@ -92,6 +92,11 @@ struct MACIOIDEState { > uint32_t irq_reg; > }; > > +#define MACIO_IDE_PMAC_NIRQS 2 > + > +#define MACIO_IDE_PMAC_DMA_IRQ 0 > +#define MACIO_IDE

Re: [PATCH v2 15/15] tests/qtest: Free GThread

2024-06-28 Thread Peter Maydell
On Thu, 27 Jun 2024 at 14:41, Akihiko Odaki wrote: > > These GThreads are never referenced. > > Signed-off-by: Akihiko Odaki > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v2 12/15] tests/qtest: Free old machine variable name

2024-06-28 Thread Peter Maydell
t; qemu_var = g_strdup(var); > > /* new qemu, clear the cache */ > > -- > 2.45.2 Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v2 06/15] ppc/vof: Fix unaligned FDT property access

2024-06-28 Thread Peter Maydell
*(uint32_t *)(mem0_reg + sizeof(uint32_t) * > ac)); > } I did wonder if there was a better way to do what this is doing, but neither we (in system/device_tree.c) nor libfdt seem to provide one. Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v2 01/15] cpu: Free cpu_ases

2024-06-28 Thread Peter Maydell
On Thu, 27 Jun 2024 at 14:39, Akihiko Odaki wrote: > > This fixes LeakSanitizer warnings. > > Signed-off-by: Akihiko Odaki > --- > hw/core/cpu-common.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/core/cpu-common.c b/hw/core/cpu-common.c > index f131cde2c038..a3073c17d098 100644 >

Re: [PATCH 02/14] hw/ide: Free macio-ide IRQs

2024-06-26 Thread Peter Maydell
On Wed, 26 Jun 2024 at 12:09, Akihiko Odaki wrote: > > This suppresses LeakSanitizer warnings. > > Signed-off-by: Akihiko Odaki > --- > hw/ide/macio.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/hw/ide/macio.c b/hw/ide/macio.c > index aca90d04f0e8..d8fbc1a17ba6 100644 > ---

Re: [PATCH 03/14] hw/isa/vt82c686: Free irqs

2024-06-26 Thread Peter Maydell
On Wed, 26 Jun 2024 at 12:08, Akihiko Odaki wrote: > > This suppresses LeakSanitizer warnings. > > Signed-off-by: Akihiko Odaki > --- > hw/isa/vt82c686.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c > index 8582ac0322eb..189b487

Re: [PULL v2 2/2] hw/ufs: Add support MCQ of UFSHCI 4.0

2024-06-07 Thread Peter Maydell
On Mon, 3 Jun 2024 at 09:38, Jeuk Kim wrote: > > From: Minwoo Im > > This patch adds support for MCQ defined in UFSHCI 4.0. This patch > utilized the legacy I/O codes as much as possible to support MCQ. > > MCQ operation & runtime register is placed at 0x1000 offset of UFSHCI > register statical

Re: [PULL 02/17] crypto: Introduce SM4 symmetric cipher algorithm

2024-06-07 Thread Peter Maydell
On Fri, 9 Feb 2024 at 14:07, Daniel P. Berrangé wrote: > > From: Hyman Huang > > Introduce the SM4 cipher algorithms (OSCCA GB/T 32907-2016). > > SM4 (GBT.32907-2016) is a cryptographic standard issued by the > Organization of State Commercial Administration of China (OSCCA) > as an authorized cr

Re: [PATCH] misc: Use QEMU header path relative to include/ directory

2024-05-07 Thread Peter Maydell
t; Signed-off-by: Philippe Mathieu-Daudé > --- > hw/audio/virtio-snd.c | 2 +- > hw/rtc/ls7a_rtc.c | 2 +- > target/i386/gdbstub.c | 2 +- > tests/qtest/nvme-test.c | 2 +- > tests/qtest/ufs-test.c | 2 +- Reviewed-by: Peter Maydell thanks -- PMM

Re: [PULL v2 03/16] block/block-backend: add block layer APIs resembling Linux ZonedBlockDevice ioctls

2024-05-03 Thread Peter Maydell
On Mon, 15 May 2023 at 17:07, Stefan Hajnoczi wrote: > > From: Sam Li > > Add zoned device option to host_device BlockDriver. It will be presented only > for zoned host block devices. By adding zone management operations to the > host_block_device BlockDriver, users can use the new block layer AP

Re: [PATCH for-9.0?] usb-storage: Fix BlockConf defaults

2024-04-16 Thread Peter Maydell
On Tue, 16 Apr 2024 at 10:26, Hanna Czenczek wrote: > > On 12.04.24 16:42, Kevin Wolf wrote: > > Commit 30896374 started to pass the full BlockConf from usb-storage to > > scsi-disk, while previously only a few select properties would be > > forwarded. This enables the user to set more properties,

Re: [PATCH-for-9.0 v2] hw/sd/sdhci: Do not update TRNMOD when Command Inhibit (DAT) is set

2024-04-09 Thread Peter Maydell
esses to the Buffer Data Port register. > > Fixes: CVE-2024-3447 > Cc: qemu-sta...@nongnu.org > Fixes: d7dfca0807 ("hw/sdhci: introduce standard SD host controller") > Buglink: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=58813 > Reported-by: Alexander Buleko

Re: [PATCH-for-9.0] hw/sd/sdhci: Discard excess of data written to Buffer Data Port register

2024-04-09 Thread Peter Maydell
On Mon, 8 Apr 2024 at 17:42, Peter Maydell wrote: > So another approach here would be... That said, this is all quite complicated looking, so for 9.0 and backports at least this patch is fine. Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH-for-9.0] hw/sd/sdhci: Discard excess of data written to Buffer Data Port register

2024-04-08 Thread Peter Maydell
On Mon, 8 Apr 2024 at 13:34, Peter Maydell wrote: > > On Thu, 4 Apr 2024 at 09:56, Philippe Mathieu-Daudé wrote: > > diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c > > index c5e0bc018b..2dd88fa139 100644 > > --- a/hw/sd/sdhci.c > > +++ b/hw/sd/sdhci.c >

Re: [PATCH-for-9.1 2/2] hw/sd/sdcard: Assert @data_offset is in range

2024-04-08 Thread Peter Maydell
On Mon, 8 Apr 2024 at 15:18, Philippe Mathieu-Daudé wrote: > > Prevent out-of-bound access with assertions. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/sd/sd.c | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/hw/sd/sd.c b/hw/sd/sd.c > index 16d8d52a78..c081211582

Re: [PATCH-for-9.0] hw/sd/sdhci: Discard excess of data written to Buffer Data Port register

2024-04-08 Thread Peter Maydell
On Thu, 4 Apr 2024 at 09:56, Philippe Mathieu-Daudé wrote: > > Per "SD Host Controller Standard Specification Version 3.00": > > * 1.7 Buffer Control > > - 1.7.1 Control of Buffer Pointer > > (3) Buffer Control with Block Size > > In case of write operation, the buffer accumulates the

Re: [PULL for-9.0 0/1] Block patches

2024-04-04 Thread Peter Maydell
On Thu, 4 Apr 2024 at 14:58, Stefan Hajnoczi wrote: > > The following changes since commit 786fd793b81410fb2a28914315e2f05d2ff6733b: > > Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging > (2024-04-03 12:52:03 +0100) > > are available in the Git repository at: > > https

Re: [PULL 00/15] Misc HW patches for 2024-04-02

2024-04-02 Thread Peter Maydell
On Tue, 2 Apr 2024 at 15:25, Philippe Mathieu-Daudé wrote: > > The following changes since commit 7fcf7575f3d201fc84ae168017ffdfd6c86257a6: > > Merge tag 'pull-target-arm-20240402' of > https://git.linaro.org/people/pmaydell/qemu-arm into staging (2024-04-02 > 11:34:49 +0100) > > are available

Re: [PULL 0/6] Block layer patches

2024-03-26 Thread Peter Maydell
On Tue, 26 Mar 2024 at 13:54, Kevin Wolf wrote: > > The following changes since commit 096ae430a7b5a704af4cd94dca7200d6cb069991: > > Merge tag 'pull-qapi-2024-03-26' of https://repo.or.cz/qemu/armbru into > staging (2024-03-26 09:50:21 +) > > are available in the Git repository at: > > ht

Re: [PATCH-for-9.0? v2 3/4] qtest/libqos: Reduce size_to_prdtl() declaration scope

2024-03-26 Thread Peter Maydell
. > > Suggested-by: Peter Maydell > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell thanks -- PMM

Re: [PULL for-9.0 0/1] Block patches

2024-03-22 Thread Peter Maydell
On Thu, 21 Mar 2024 at 17:23, Stefan Hajnoczi wrote: > > The following changes since commit fea445e8fe9acea4f775a832815ee22bdf2b0222: > > Merge tag 'pull-maintainer-final-for-real-this-time-200324-1' of > https://gitlab.com/stsquad/qemu into staging (2024-03-21 10:31:56 +) > > are available

Re: [PULL 0/1] Block patches

2024-03-19 Thread Peter Maydell
On Tue, 19 Mar 2024 at 15:09, Stefan Hajnoczi wrote: > > The following changes since commit ddc27d2ad9361a81c2b3800d14143bf420dae172: > > Merge tag 'pull-request-2024-03-18' of https://gitlab.com/thuth/qemu into > staging (2024-03-19 10:25:25 +) > > are available in the Git repository at: >

Re: [PULL 00/15] Block layer patches

2024-03-19 Thread Peter Maydell
On Mon, 18 Mar 2024 at 13:04, Kevin Wolf wrote: > > The following changes since commit ba49d760eb04630e7b15f423ebecf6c871b8f77b: > > Merge tag 'pull-maintainer-final-130324-1' of > https://gitlab.com/stsquad/qemu into staging (2024-03-13 15:12:14 +) > > are available in the Git repository a

Re: [PATCH-for-9.0 2/4] accel/hvf: Un-inline hvf_arch_supports_guest_debug()

2024-03-13 Thread Peter Maydell
On Wed, 13 Mar 2024 at 18:50, Philippe Mathieu-Daudé wrote: > > See previous commit and commit 9de9fa5cf2 ("Avoid using inlined > functions with external linkage") for rationale. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH-for-9.0 3/4] qtest/libqos: Un-inline size_to_prdtl()

2024-03-13 Thread Peter Maydell
On Wed, 13 Mar 2024 at 18:50, Philippe Mathieu-Daudé wrote: > > See previous commit and commit 9de9fa5cf2 ("Avoid using inlined > functions with external linkage") for rationale. > > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/qtest/libqos/ahci.c | 2 +- > 1 file changed, 1 insertion(+),

Re: [PULL v2 0/6] hw/nvme updates

2024-03-13 Thread Peter Maydell
On Tue, 12 Mar 2024 at 17:26, Klaus Jensen wrote: > > From: Klaus Jensen > > Hi, > > Sorry about the compilation error in v1. Did a full CI run for v2. > > https://gitlab.com/birkelund/qemu/-/pipelines/1210559370 > > > > The following changes since commit 8f3f329f5e0117bd1a23a79ab751f8a7d3471e4

Re: [PULL 00/13] Misc HW patches for 2024-03-12

2024-03-12 Thread Peter Maydell
On Tue, 12 Mar 2024 at 08:24, Philippe Mathieu-Daudé wrote: > > The following changes since commit 7489f7f3f81dcb776df8c1b9a9db281fc21bf05f: > > Merge tag 'hw-misc-20240309' of https://github.com/philmd/qemu into staging > (2024-03-09 20:12:21 +) > > are available in the Git repository at:

Re: [PULL 0/6] hw/nvme updates

2024-03-12 Thread Peter Maydell
On Mon, 11 Mar 2024 at 19:11, Klaus Jensen wrote: > > From: Klaus Jensen > > Hi, > > The following changes since commit 7489f7f3f81dcb776df8c1b9a9db281fc21bf05f: > > Merge tag 'hw-misc-20240309' of https://github.com/philmd/qemu into staging > (2024-03-09 20:12:21 +) > > are available in t

Re: [PULL 34/56] hw/intc/grlib_irqmp: add ncpus property

2024-03-08 Thread Peter Maydell
On Thu, 15 Feb 2024 at 18:04, Philippe Mathieu-Daudé wrote: > > From: Clément Chigot > > This adds a "ncpus" property to the "grlib-irqmp" device to be used > later, this required a little refactoring of how we initialize the > device (ie: use realize instead of init). > > Co-developed-by: Freder

Re: [PULL 00/30] Misc HW patches for 2024-02-27

2024-02-27 Thread Peter Maydell
On Tue, 27 Feb 2024 at 12:33, Peter Maydell wrote: > > On Tue, 27 Feb 2024 at 08:40, Philippe Mathieu-Daudé > wrote: > > > > The following changes since commit 03d496a992d98650315af41be7c0ca6de2a28da1: > > > > Merge tag 'pull-qapi-2024-02-26&#

Re: [PULL 00/30] Misc HW patches for 2024-02-27

2024-02-27 Thread Peter Maydell
hw/nvme: Fix invalid endian conversion > hw/i386: More PC machine housekeeping (Bernhard, Phil) > hw/ide: Restrict "ide-internal.h" (Zoltan, Phil) > qom: Expose object_resolve_type_unambiguous() (Paolo) > > > Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH 2/2] hw/intc/arm_gicv3_its: Use send_msi in the GITS_TRANSLATER write

2024-02-23 Thread Peter Maydell
On Wed, 21 Feb 2024 at 17:33, Nabih Estefan wrote: > > From: Roque Arcudia Hernandez > > This is trying to achieve 2 things: To be able to redefine the send_msi in a > derived class of arm_gicv3_its and/or to expose a method call interface to > inject interrupts from another device. But there is

Re: [PATCH 1/2] hw/intc/arm_gicv3_its_common: Increase DeviceID to 32 bits

2024-02-23 Thread Peter Maydell
On Wed, 21 Feb 2024 at 17:33, Nabih Estefan wrote: > > From: Roque Arcudia Hernandez > > According to the “GICv3 and GICv4 Software Overview” the DeviceID is > IMPLEMENTATION DEFINED. This patch increases the DeviceID in send_msi virtual > function to 32 bits to allow the possibility of a redefin

Re: [PULL v2 00/32] Misc HW patches for 2024-02-22

2024-02-23 Thread Peter Maydell
On Thu, 22 Feb 2024 at 12:58, Philippe Mathieu-Daudé wrote: > > The following changes since commit 760b4dcdddba4a40b9fa0eb78fdfc7eda7cb83d0: > > Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging > (2024-02-20 10:11:08 +) > > are available in the Git repository at: > >

Re: [PATCH v2 0/2] OSPI updates

2024-02-22 Thread Peter Maydell
On Tue, 20 Feb 2024 at 09:17, Sai Pavan Boddu wrote: > > Add a new 2Gib octal flash mt35xu02gbba. Add an interface for versal > virt board to swap the default flash. > > Changes for V2: > Added type checks for provided flash part name. > > Sai Pavan Boddu (2): > block: m25p80: Add support of m

Re: [PATCH v2] xlnx-versal-ospi: disable reentrancy detection for iomem_dac

2024-02-22 Thread Peter Maydell
On Mon, 19 Feb 2024 at 10:56, Sai Pavan Boddu wrote: > > The OSPI DMA reads flash data through the OSPI linear address space (the > iomem_dac region), because of this the reentrancy guard introduced in > commit a2e1753b ("memory: prevent dma-reentracy issues") is disabled for > the memory region.

Re: [PATCH] MAINTAINERS: Cover hw/ide/ahci-allwinner.c with AllWinner A10 machine

2024-02-22 Thread Peter Maydell
On Thu, 15 Feb 2024 at 16:09, Philippe Mathieu-Daudé wrote: > > This code -- which was moved many times around -- was added in > commit 377e214539 ("ahci: Add allwinner AHCI") and belong to the > AllWinner machines. See also commit dca625768a ("arm: allwinner-a10: > Add SATA"). > > Signed-off-by:

Re: [PULL 00/56] Misc HW patches for 2024-02-15

2024-02-16 Thread Peter Maydell
On Thu, 15 Feb 2024 at 17:58, Philippe Mathieu-Daudé wrote: > > The following changes since commit 5767815218efd3cbfd409505ed824d5f356044ae: > > Merge tag 'for_upstream' of > https://git.kernel.org/pub/scm/virt/kvm/mst/qemu into staging (2024-02-14 > 15:45:52 +) > > are available in the Gi

Re: [PATCH] iotests: Make 144 deterministic again

2024-02-15 Thread Peter Maydell
On Mon, 12 Feb 2024 at 15:20, Stefan Hajnoczi wrote: > > On Fri, Feb 09, 2024 at 06:31:03PM +0100, Kevin Wolf wrote: > > Since commit effd60c8 changed how QMP commands are processed, the order > > of the block-commit return value and job events in iotests 144 wasn't > > fixed and more and caused t

Re: [PULL 00/17] Misc fixes patches

2024-02-12 Thread Peter Maydell
On Fri, 9 Feb 2024 at 14:07, Daniel P. Berrangé wrote: > > The following changes since commit 9e34f127f419b3941b36dfdfac79640dc81e97e2: > > Merge tag 'pull-request-2024-02-06' of https://gitlab.com/thuth/qemu into > staging (2024-02-08 11:59:28 +) > > are available in the Git repository at:

Re: [PATCH v3 09/11] hw/sparc/leon3: Realize GRLIB IRQ controller before accessing it

2024-02-09 Thread Peter Maydell
On Thu, 8 Feb 2024 at 18:15, Philippe Mathieu-Daudé wrote: > > We should not wire IRQs on unrealized device. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/sparc/leon3.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v3 08/11] hw/sparc/sun4m: Realize DMA controller before accessing it

2024-02-09 Thread Peter Maydell
ledma), 0, ledma_irq); > + (This confused me briefly until I realised that this function is reaching into the dma device to find child objects to connect the IRQs to. Perhaps it would be nicer if the wrapping 'dma' object passed through those IRQs to avoid that.) Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v3 10/11] hw/sparc/leon3: Initialize GPIO before realizing CPU devices

2024-02-09 Thread Peter Maydell
env, "pil", 1); > +qdev_realize(DEVICE(cpu), NULL, &error_fatal); Reviewed-by: Peter Maydell with a similar caveat as with the sparc64.c patch. thanks -- PMM

Re: [PATCH v3 11/11] hw/sparc64/cpu: Initialize GPIO before realizing CPU devices

2024-02-09 Thread Peter Maydell
qdev_realize(DEVICE(cpu), NULL, &error_fatal); > env = &cpu->env; > > env->tick = cpu_timer_create("tick", cpu, tick_irq, > -- > 2.41.0 For the purposes of letting us enforce the "init GPIOs before realize, not after" rule, Reviewed-by: Pet

Re: [PATCH v3 07/11] hw/sh4/r2d: Realize IDE controller before accessing it

2024-02-09 Thread Peter Maydell
On Thu, 8 Feb 2024 at 18:14, Philippe Mathieu-Daudé wrote: > > We should not wire IRQs on unrealized device. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/sh4/r2d.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v3 05/11] hw/ppc/prep: Realize ISA bridge before accessing it

2024-02-09 Thread Peter Maydell
On Thu, 8 Feb 2024 at 18:14, Philippe Mathieu-Daudé wrote: > > We should not wire IRQs on unrealized device. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v3 03/11] hw/rx/rx62n: Only call qdev_get_gpio_in() when necessary

2024-02-09 Thread Peter Maydell
t; > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v3 02/11] hw/rx/rx62n: Reduce inclusion of 'qemu/units.h'

2024-02-09 Thread Peter Maydell
On Thu, 8 Feb 2024 at 18:13, Philippe Mathieu-Daudé wrote: > > "qemu/units.h" is not used in the "hw/rx/rx62n.h" > header, include it in the source where it is. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v3 01/11] hw/ide/ich9: Use AHCIPCIState typedef

2024-02-09 Thread Peter Maydell
On Thu, 8 Feb 2024 at 18:13, Philippe Mathieu-Daudé wrote: > > QEMU coding style recommend using structure typedefs: > https://www.qemu.org/docs/master/devel/style.html#typedefs > > Signed-off-by: Philippe Mathieu-Daudé > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [PULL 00/16] Block layer patches

2024-02-09 Thread Peter Maydell
On Wed, 7 Feb 2024 at 21:57, Kevin Wolf wrote: > > The following changes since commit 39a6e4f87e7b75a45b08d6dc8b8b7c2954c87440: > > Merge tag 'pull-qapi-2024-02-03' of https://repo.or.cz/qemu/armbru into > staging (2024-02-03 13:31:58 +) > > are available in the Git repository at: > > htt

Re: [PATCH] iothread: Simplify expression in qemu_in_iothread()

2024-02-08 Thread Peter Maydell
On Thu, 8 Feb 2024 at 14:22, Kevin Wolf wrote: > > Am 08.02.2024 um 11:48 hat Philippe Mathieu-Daudé geschrieben: > > BTW using the same pattern: > > > > -- >8 -- > > diff --git a/hw/nvram/xlnx-zynqmp-efuse.c b/hw/nvram/xlnx-zynqmp-efuse.c > > index ec98456e5d..d074762a25 100644 > > --- a/hw/nvram

Re: [PATCH] iotests: fix leak of tmpdir in dry-run mode

2024-02-05 Thread Peter Maydell
On Mon, 5 Feb 2024 at 15:41, Daniel P. Berrangé wrote: > > Creating an instance of the 'TestEnv' class will create a temporary > directory. This dir is only deleted, however, in the __exit__ handler > invoked by a context manager. > > In dry-run mode, we don't use the TestEnv via a context manager

Re: [PATCH v3 0/6] hw/{arm,xen} convert printfs to trace/reports

2024-02-01 Thread Peter Maydell
On Mon, 29 Jan 2024 at 16:10, Manos Pitsidianakis wrote: > > This series changes some printfs to use the trace event framework. > Additionally, it converts some error/warning reporting fprintfs to > error_report/warn_report. > > v2 -> v3 > : > - addressed Peter Maydells's review > > v1 -> v2 >

Re: [PULL 0/5] Block patches

2024-02-01 Thread Peter Maydell
On Tue, 30 Jan 2024 at 21:51, Stefan Hajnoczi wrote: > > The following changes since commit 11be70677c70fdccd452a3233653949b79e97908: > > Merge tag 'pull-vfio-20240129' of https://github.com/legoater/qemu into > staging (2024-01-29 10:53:56 +) > > are available in the Git repository at: > >

Re: [PATCH 0/3] monitor: only run coroutine commands in qemu_aio_context

2024-01-29 Thread Peter Maydell
On Tue, 16 Jan 2024 at 19:01, Stefan Hajnoczi wrote: > > Several bugs have been reported related to how QMP commands are rescheduled in > qemu_aio_context: > - https://gitlab.com/qemu-project/qemu/-/issues/1933 > - https://issues.redhat.com/browse/RHEL-17369 > - https://bugzilla.redhat.com/show_bu

Re: [PULL v3 00/18] Block layer patches

2024-01-26 Thread Peter Maydell
On Fri, 26 Jan 2024 at 12:28, Kevin Wolf wrote: > > The following changes since commit 5bab95dc74d43bbb28c6a96d24c810a664432057: > > Merge tag 'pull-request-2024-01-24' of https://gitlab.com/thuth/qemu into > staging (2024-01-25 12:33:42 +) > > are available in the Git repository at: > >

Re: [PULL v3 00/18] Block layer patches

2024-01-26 Thread Peter Maydell
On Fri, 26 Jan 2024 at 12:28, Kevin Wolf wrote: > > The following changes since commit 5bab95dc74d43bbb28c6a96d24c810a664432057: > > Merge tag 'pull-request-2024-01-24' of https://gitlab.com/thuth/qemu into > staging (2024-01-25 12:33:42 +) > > are available in the Git repository at: > >

Re: [PULL 0/2] Block patches

2024-01-25 Thread Peter Maydell
On Mon, 22 Jan 2024 at 16:01, Stefan Hajnoczi wrote: > > The following changes since commit 09be34717190c1620f0c6e5c8765b8da354aeb4b: > > Merge tag 'pull-request-2024-01-19' of https://gitlab.com/thuth/qemu into > staging (2024-01-20 17:22:16 +) > > are available in the Git repository at: >

Re: [PULL v2 00/14] Block layer patches

2024-01-25 Thread Peter Maydell
On Mon, 22 Jan 2024 at 11:22, Kevin Wolf wrote: > > The following changes since commit 3f2a357b95845ea0bf7463eff6661e43b97d1afc: > > Merge tag 'hw-cpus-20240119' of https://github.com/philmd/qemu into staging > (2024-01-19 11:39:38 +) > > are available in the Git repository at: > > https:

Re: [PATCH v2 2/4] Avoid conflicting types for 'copy_file_range'

2024-01-22 Thread Peter Maydell
(Cc'ing the block folks) On Thu, 18 Jan 2024 at 16:03, Manolo de Medici wrote: > > Compilation fails on systems where copy_file_range is already defined as a > stub. What do you mean by "stub" here ? If the system headers define a prototype for the function, I would have expected the meson check

Re: [PULL 00/14] Block layer patches

2024-01-22 Thread Peter Maydell
On Mon, 22 Jan 2024 at 11:15, Kevin Wolf wrote: > > Am 20.01.2024 um 18:21 hat Peter Maydell geschrieben: > > Got some compile failures on this one; looks like the compiler > > on our s390 box didn't like this: > > > > https://gitlab.com/qemu-project/qemu/-/job

Re: [PULL 00/14] Block layer patches

2024-01-20 Thread Peter Maydell
On Fri, 19 Jan 2024 at 18:15, Kevin Wolf wrote: > > The following changes since commit 3f2a357b95845ea0bf7463eff6661e43b97d1afc: > > Merge tag 'hw-cpus-20240119' of https://github.com/philmd/qemu into staging > (2024-01-19 11:39:38 +) > > are available in the Git repository at: > > https:

Re: [PULL 00/36] HW core patches for 2024-01-19

2024-01-19 Thread Peter Maydell
On Fri, 19 Jan 2024 at 11:37, Philippe Mathieu-Daudé wrote: > > The following changes since commit 88cf5fec91e50cd34bc002b633b4116228db0bc8: > > Merge tag 'pull-target-arm-20240118' of > https://git.linaro.org/people/pmaydell/qemu-arm into staging (2024-01-18 > 12:48:17 +) > > are availabl

Re: how do the iotests pick a machine model to run on ?

2024-01-19 Thread Peter Maydell
On Fri, 19 Jan 2024 at 15:26, Peter Maydell wrote: > (Also, we should probably put an entry for sh4 in machine_map, > because the default board type (shix) is about to be deprecated, > and the r2d board type is thus a better choice.) The good news is if we add r2d to the machine_map, th

Re: how do the iotests pick a machine model to run on ?

2024-01-19 Thread Peter Maydell
On Fri, 19 Jan 2024 at 14:07, Kevin Wolf wrote: > > Am 19.01.2024 um 13:55 hat Peter Maydell geschrieben: > > How are the iotests supposed to select a machine model to run > > on, and how are they intended to mark themselves as requiring > > particular facilities, like PCI

how do the iotests pick a machine model to run on ?

2024-01-19 Thread Peter Maydell
If you build QEMU with support for the sh4 target only (configure --target-list=sh4-softmmu) then 'make check' fails in the iotests, because some iotests, including for instance 040, try to create a machine with a virtio-scsi device, but they don't do anything to ensure that the machine they create

Re: double free or corruption (out) in iscsi virtual machine

2024-01-17 Thread Peter Maydell
On Wed, 17 Jan 2024 at 07:24, M_O_Bz wrote: > > Basic Info: > 1. Issue: I got a " double free or corruption (out)", head for attachment > debug.log for details, the debug.log print the backtrace of one virtual > machine > 2. Reproduce: currently I cann't destribe how to reproduce this bug, becau

Re: [PATCH v2 2/2] hw/pflash: implement update buffer for block writes

2024-01-16 Thread Peter Maydell
On Tue, 16 Jan 2024 at 16:08, Philippe Mathieu-Daudé wrote: > > On 12/1/24 17:54, Peter Maydell wrote: > > On Mon, 8 Jan 2024 at 13:06, Philippe Mathieu-Daudé > > wrote: > >> > >> Hi Gerd, > >> > >> On 8/1/24 13:53, Philippe Mathieu-Daud

Re: [PATCH v2 2/2] hw/pflash: implement update buffer for block writes

2024-01-12 Thread Peter Maydell
On Mon, 8 Jan 2024 at 13:06, Philippe Mathieu-Daudé wrote: > > Hi Gerd, > > On 8/1/24 13:53, Philippe Mathieu-Daudé wrote: > > From: Gerd Hoffmann > > > > Add an update buffer where all block updates are staged. > > Flush or discard updates properly, so we should never see > > half-completed bloc

Re: [PULL 0/6] Block patches

2024-01-09 Thread Peter Maydell
On Mon, 8 Jan 2024 at 16:37, Stefan Hajnoczi wrote: > > The following changes since commit ffd454c67e38cc6df792733ebc5d967eee28ac0d: > > Merge tag 'pull-vfio-20240107' of https://github.com/legoater/qemu into > staging (2024-01-08 10:28:42 +) > > are available in the Git repository at: > >

  1   2   3   4   5   6   7   8   9   10   >