Re: [PATCH] block/vvfat: fix: drop backing

2021-07-15 Thread Programmingkid
> On Jul 15, 2021, at 8:48 AM, Vladimir Sementsov-Ogievskiy > wrote: > > Most probably this fake backing child doesn't work anyway (see notes > about it in a8a4d15c1c34d). > > Still, since 25f78d9e2de528473d52 drivers are required to set > .supports_backing if they want to call

Re: Host folder sharing via USB issue

2021-07-14 Thread Programmingkid
> On Jul 14, 2021, at 6:35 AM, Vladimir Sementsov-Ogievskiy > wrote: > > 14.07.2021 00:04, Programmingkid wrote: >> Hi I have noticed that host folder sharing via USB has recently stopped >> working. After doing some git bisecting I found this as the patch that s

Host folder sharing via USB issue

2021-07-13 Thread Programmingkid
Hi I have noticed that host folder sharing via USB has recently stopped working. After doing some git bisecting I found this as the patch that seems to be the issue: 25f78d9e2de528473d52acfcf7acdfb64e3453d4 is the first bad commit commit 25f78d9e2de528473d52acfcf7acdfb64e3453d4 Author: Vladimir

Re: [PATCH 0/2] vvfat: fix two crashes.

2021-05-26 Thread Programmingkid
> On May 25, 2021, at 12:18 PM, Kevin Wolf wrote: > > Am 24.05.2021 um 18:06 hat Programmingkid geschrieben: >>>>> qemu-system-ppc -usb -device usb-storage,drive=fat16 -drive >>>>> file=fat:rw:fat-type=16:">>>> folder>",id=fat1

Re: [PATCH 0/2] vvfat: fix two crashes.

2021-05-25 Thread Programmingkid
> On May 25, 2021, at 2:05 AM, Vladimir Sementsov-Ogievskiy > wrote: > > 24.05.2021 20:33, Programmingkid wrote: >>> On May 24, 2021, at 12:56 PM, Vladimir Sementsov-Ogievskiy >>> wrote: >>> >>> 24.05.2021 19:06, Programmingkid wrote: >&g

Re: [PATCH 0/2] vvfat: fix two crashes.

2021-05-24 Thread Programmingkid
> On May 24, 2021, at 12:56 PM, Vladimir Sementsov-Ogievskiy > wrote: > > 24.05.2021 19:06, Programmingkid wrote: >>> On May 24, 2021, at 11:55 AM, Vladimir Sementsov-Ogievskiy >>> wrote: >>> >>> 24.05.2021 18:41, Programmingkid wrote: >&

Re: [PATCH 0/2] vvfat: fix two crashes.

2021-05-24 Thread Programmingkid
> On May 24, 2021, at 11:55 AM, Vladimir Sementsov-Ogievskiy > wrote: > > 24.05.2021 18:41, Programmingkid wrote: >>> On May 24, 2021, at 6:12 AM, Vladimir Sementsov-Ogievskiy >>> wrote: >>> >>> Hi! >>> >>> As reported by

Re: [PATCH 0/2] vvfat: fix two crashes.

2021-05-24 Thread Programmingkid
> On May 24, 2021, at 6:12 AM, Vladimir Sementsov-Ogievskiy > wrote: > > Hi! > > As reported by Programmingkid, command > > qemu-system-ppc -usb -device usb-storage,drive=fat16 -drive > file=fat:rw:fat-type=16:"",id=fat16,format=raw,if=none > >

Patch "block: drop ctx argument from bdrv_root_attach_child" causing crash

2021-05-23 Thread Programmingkid
After doing some git bisecting I found out a problem I was having with sharing a host folder as an USB flash drive on the guest was caused by this patch: 228ca37e12f97788e05bd0c92f89b3e5e4019607 is the first bad commit commit 228ca37e12f97788e05bd0c92f89b3e5e4019607 Author: Vladimir

Re: [Qemu-block] [PATCH v3] qemu-img.c: add help for each command

2018-09-25 Thread Programmingkid
> On Sep 25, 2018, at 12:46 PM, Murilo Opsfelder Araujo > wrote: > > Hi, John. > > On Tue, Sep 25, 2018 at 11:39:49AM -0400, John Arbuckle wrote: >> Add the ability for the user to display help for a certain command. >> Example: qemu-img create --help >> >> What is printed is all the

Re: [Qemu-block] [Qemu-devel] Ping [PATCH v2] qemu-img.c: add help for each command

2018-09-23 Thread Programmingkid
> On Sep 23, 2018, at 11:02 AM, Murilo Opsfelder Araujo > wrote: > > Hi, John. > > On Sat, Sep 22, 2018 at 01:16:06PM -0400, Programmingkid wrote: >> Patchworks url: https://patchwork.ozlabs.org/patch/970255/ >> >> Add the ability for the user t

[Qemu-block] Ping [PATCH v2] qemu-img.c: add help for each command

2018-09-22 Thread Programmingkid
Patchworks url: https://patchwork.ozlabs.org/patch/970255/ Add the ability for the user to display help for a certain command. Example: qemu-img create --help What is printed is all the options available to this command and an example. Signed-off-by: John Arbuckle --- v2 changes: Removed

Re: [Qemu-block] [Qemu-devel] [PATCH] qemu-img.c: add help for each command

2018-09-10 Thread Programmingkid
> On Sep 10, 2018, at 4:16 AM, Kevin Wolf wrote: > > Am 08.09.2018 um 05:16 hat Programmingkid geschrieben: >> >>> On Sep 7, 2018, at 11:13 PM, Peter Maydell wrote: >>> >>> On 8 September 2018 at 04:01, John Arbuckle >>> wrote

Re: [Qemu-block] [Qemu-devel] [PATCH] qemu-img.c: add help for each command

2018-09-07 Thread Programmingkid
> On Sep 7, 2018, at 11:13 PM, Peter Maydell wrote: > > On 8 September 2018 at 04:01, John Arbuckle wrote: > >> +/* print the help for this command */ >> +if (strcmp("--help", argv[optind + 1]) == 0) { >> +if (strcmp("amend", cmdname) == 0) { >> +help_amend(); >>

Re: [Qemu-block] [PATCH] qemu-img.c: increase spacing between commands in documentation

2018-08-18 Thread Programmingkid
> On Aug 17, 2018, at 4:59 PM, Eric Blake wrote: > > On 08/17/2018 02:28 PM, Programmingkid wrote: > >>>> -o Used with a comma separated list of format specific >>>> options in a >>>> name=value format.

Re: [Qemu-block] [PATCH] qemu-img.c: increase spacing between commands in documentation

2018-08-17 Thread Programmingkid
> On Aug 17, 2018, at 9:44 AM, Eric Blake wrote: > > On 08/16/2018 08:27 PM, Programmingkid wrote: > >> I am by no means an expert at qemu-img. But I did try my best to create what >> I think should be the new output for qemu-img --help. This is just >> the te

Re: [Qemu-block] [PATCH] qemu-img.c: increase spacing between commands in documentation

2018-08-16 Thread Programmingkid
> On Aug 14, 2018, at 4:40 AM, Kevin Wolf wrote: > > Am 13.08.2018 um 20:19 hat Eric Blake geschrieben: >> On 08/13/2018 11:56 AM, Max Reitz wrote: >>> >>> Ah, hm, so much for that. Hm... I don't quite know what to think of >>> this. It does indeed improve legibility. But the question is

Re: [Qemu-block] [PATCH] qemu-img.c: increase spacing between commands in documentation

2018-08-14 Thread Programmingkid
> On Aug 14, 2018, at 8:55 AM, Eric Blake wrote: > > On 08/14/2018 03:40 AM, Kevin Wolf wrote: >>> And I've already expressed my opinion that it is already rather long, where >>> making it longer is not necessarily making it smarter. >> I think if we want to improve the help text, we should

Re: [Qemu-block] [Qemu-devel] [PATCH] qemu-img.c: Add examples section

2018-08-03 Thread Programmingkid
> On Aug 3, 2018, at 4:46 AM, Fam Zheng wrote: > > On Thu, 08/02 22:34, Programmingkid wrote: >> >>> On Aug 2, 2018, at 10:10 PM, Fam Zheng wrote: >>> >>> On Thu, 08/02 20:50, John Arbuckle wrote: >>>> Add an examples section to th

Re: [Qemu-block] [Qemu-devel] [PATCH] qemu-img.c: Add examples section

2018-08-02 Thread Programmingkid
> On Aug 2, 2018, at 10:10 PM, Fam Zheng wrote: > > On Thu, 08/02 20:50, John Arbuckle wrote: >> Add an examples section to the help output. >> >> Signed-off-by: John Arbuckle >> --- >> qemu-img.c | 11 +++ >> 1 file changed, 11 insertions(+) >> >> diff --git a/qemu-img.c

Re: [Qemu-block] [PATCH] Add interactive mode to qemu-img command

2018-07-31 Thread Programmingkid
> On Jul 31, 2018, at 6:48 AM, Kevin Wolf wrote: > > Am 30.07.2018 um 22:27 hat Programmingkid geschrieben: >> On Jul 30, 2018, at 3:39 PM, Max Reitz wrote: >>> On 2018-07-30 21:14, John Arbuckle wrote: >>> What comes to my mind is this: Why don't you write a

Re: [Qemu-block] [Qemu-devel] [PATCH] qemu-img-cmds.hx: Add example usage for create command

2018-07-31 Thread Programmingkid
> On Jul 31, 2018, at 7:57 AM, Eric Blake wrote: > > On 07/30/2018 09:52 PM, John Arbuckle wrote: >> Add an example on how to use the create command. I believe this will make >> qemu-img easier to use. >> Signed-off-by: John Arbuckle >> --- >> qemu-img-cmds.hx | 2 +- >> 1 file changed, 1

Re: [Qemu-block] [Qemu-devel] [PATCH] qemu-img-cmds.hx: Add example usage for create command

2018-07-31 Thread Programmingkid
> On Jul 31, 2018, at 8:35 AM, Kevin Wolf wrote: > > Am 31.07.2018 um 13:57 hat Eric Blake geschrieben: >> On 07/30/2018 09:52 PM, John Arbuckle wrote: >>> Add an example on how to use the create command. I believe this will make >>> qemu-img easier to use. >>> >>> Signed-off-by: John

Re: [Qemu-block] interactive qemu-img

2018-07-30 Thread Programmingkid
> On Jul 30, 2018, at 6:14 PM, Nir Soffer wrote: > > On Mon, Jul 30, 2018 at 11:09 PM Eric Blake wrote: > On 07/30/2018 02:54 PM, Nir Soffer wrote: > > >>> $ qemu-img > >>> qemu-img: Not enough arguments > >>> Try 'qemu-img --help' for more information > > > > > > This is not user

Re: [Qemu-block] interactive qemu-img

2018-07-30 Thread Programmingkid
> On Jul 30, 2018, at 3:55 PM, Jeff Cody wrote: > > On Mon, Jul 30, 2018 at 12:30:01PM -0400, Programmingkid wrote: >> >>> On Jul 30, 2018, at 11:09 AM, Eric Blake wrote: >>> >>> On 07/28/2018 08:22 PM, Programmingkid wrote: >>>> I tho

Re: [Qemu-block] interactive qemu-img

2018-07-30 Thread Programmingkid
> On Jul 30, 2018, at 3:54 PM, Nir Soffer wrote: > > On Mon, Jul 30, 2018 at 8:00 PM Programmingkid > wrote: > > > On Jul 30, 2018, at 11:09 AM, Eric Blake wrote: > > > > On 07/28/2018 08:22 PM, Programmingkid wrote: > >> I thought of a way to m

Re: [Qemu-block] [PATCH] Add interactive mode to qemu-img command

2018-07-30 Thread Programmingkid
> On Jul 30, 2018, at 3:48 PM, Eric Blake wrote: > > On 07/30/2018 02:14 PM, John Arbuckle wrote: >> Changes qemu-img so if the user runs it without any >> arguments, it will walk the user thru making an image >> file. > > Please remember to cc qemu-devel on ALL patches, as suggested by >

Re: [Qemu-block] [PATCH] Add interactive mode to qemu-img command

2018-07-30 Thread Programmingkid
> On Jul 30, 2018, at 3:39 PM, Max Reitz wrote: > > On 2018-07-30 21:14, John Arbuckle wrote: >> Changes qemu-img so if the user runs it without any >> arguments, it will walk the user thru making an image >> file. >> >> Signed-off-by: John Arbuckle >> --- >> qemu-img.c | 31

Re: [Qemu-block] interactive qemu-img

2018-07-30 Thread Programmingkid
> On Jul 30, 2018, at 11:09 AM, Eric Blake wrote: > > On 07/28/2018 08:22 PM, Programmingkid wrote: >> I thought of a way to make qemu-img much more user-friendly. When the user >> opens qemu-img without any arguments, we could present a prompt that guides >> the u

[Qemu-block] interactive qemu-img

2018-07-28 Thread Programmingkid
I thought of a way to make qemu-img much more user-friendly. When the user opens qemu-img without any arguments, we could present a prompt that guides the user on making an image file. This illustrates what I think should happen. Please select a format (qcow, qcow2, raw, vdi, vhdx, vmdk,

[Qemu-block] Block warning messages displayed while compiling

2017-08-10 Thread Programmingkid
Host info: Operating system: Mac OS 10.12.5 Compiler: Apple LLVM version 8.1.0 (clang-802.0.42) Command to reproduce: ./configure --target-list=ppc-softmmu,i386-softmmu && make -j 4 When compiling QEMU I see these warning messages: CC block/vdi.o block/qcow.c:138:19: warning: taking

Re: [Qemu-block] [Qemu-devel] [PATCH v5] build: Work around SIZE_MAX bug in OSX headers

2016-10-11 Thread Programmingkid
On Oct 11, 2016, at 2:12 PM, Eric Blake wrote: > On 10/11/2016 01:03 PM, Programmingkid wrote: > >>> +/* Mac OSX has a bug that incorrectly defines SIZE_MAX with >>> + * the wrong type. Our replacement isn't usable in preprocessor >>> + * expressions, b

[Qemu-block] [Qemu-devel] [PATCH v5] build: Work around SIZE_MAX bug in OSX headers

2016-10-11 Thread Programmingkid
On Oct 11, 2016, at 12:00 PM, qemu-devel-requ...@nongnu.org wrote: > C99 requires SIZE_MAX to be declared with the same type as the > integral promotion of size_t, but OSX mistakenly defines it as > an 'unsigned long long' expression even though size_t is only > 'unsigned long'. Rather than

[Qemu-block] ping [PATCH v15] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2016-03-21 Thread Programmingkid
http://patchwork.ozlabs.org/patch/591171/ Mac OS X can be picky when it comes to allowing the user to use physical devices in QEMU. Most mounted volumes appear to be off limits to QEMU. If an issue is detected, a message is displayed showing the user how to unmount a volume. Now QEMU uses both CD

Re: [Qemu-block] ping [PATCH v14] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2016-03-02 Thread Programmingkid
On Mar 2, 2016, at 4:02 AM, Kevin Wolf wrote: > Am 02.03.2016 um 04:32 hat Programmingkid geschrieben: >> >> On Mar 1, 2016, at 10:16 AM, Kevin Wolf wrote: >> >>> Am 29.02.2016 um 16:17 hat Programmingkid geschrieben: >>>> I do think this patch is

Re: [Qemu-block] ping [PATCH v14] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2016-03-01 Thread Programmingkid
On Mar 1, 2016, at 10:16 AM, Kevin Wolf wrote: > Am 29.02.2016 um 16:17 hat Programmingkid geschrieben: >> I do think this patch is ready to be added to QEMU. I have listened to what >> you said and implemented your changes. >> >> https://patchwork.ozlabs.org/patch/

[Qemu-block] ping [PATCH v14] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2016-02-29 Thread Programmingkid
I do think this patch is ready to be added to QEMU. I have listened to what you said and implemented your changes. https://patchwork.ozlabs.org/patch/579325/ Mac OS X can be picky when it comes to allowing the user to use physical devices in QEMU. Most mounted volumes appear to be off limits

[Qemu-block] ping [PATCH v14] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2016-02-15 Thread Programmingkid
https://patchwork.ozlabs.org/patch/579325/ Mac OS X can be picky when it comes to allowing the user to use physical devices in QEMU. Most mounted volumes appear to be off limits to QEMU. If an issue is detected, a message is displayed showing the user how to unmount a volume. Now QEMU uses both

Re: [Qemu-block] [Qemu-devel] ping: [PATCH v13] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2016-02-03 Thread Programmingkid
On Feb 2, 2016, at 11:36 PM, Eric Blake wrote: > On 02/02/2016 09:21 PM, Programmingkid wrote: > >>>> #if defined(__APPLE__) && defined(__MACH__) >>>> /* if a physical device experienced an error while being opened */ >>>> if (str

Re: [Qemu-block] [Qemu-devel] ping: [PATCH v13] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2016-02-02 Thread Programmingkid
On Feb 2, 2016, at 12:31 PM, Daniel P. Berrange wrote: > On Tue, Feb 02, 2016 at 12:28:24PM -0500, Programmingkid wrote: >> >> On Feb 2, 2016, at 12:16 PM, Daniel P. Berrange wrote: >> >>> On Tue, Feb 02, 2016 at 12:08:31PM -0500, Programmingkid wrote: >>&

Re: [Qemu-block] [Qemu-devel] ping: [PATCH v13] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2016-02-02 Thread Programmingkid
On Feb 2, 2016, at 2:24 PM, Eric Blake wrote: > On 02/02/2016 12:10 PM, Programmingkid wrote: > >>> There was/is no leak because it qdict_get_str() returns 'const char *' and >>> so nothing needs freeing. So your change is still a backwards steps IMHO. >>

Re: [Qemu-block] [Qemu-devel] ping: [PATCH v13] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2016-02-02 Thread Programmingkid
On Feb 2, 2016, at 9:30 PM, Eric Blake wrote: > On 02/02/2016 06:15 PM, Programmingkid wrote: > >>> No, keep filename as a const char * pointer. It's easy to avoid use of >>> uninitialized memory. Try this: >>> >>> const ch

Re: [Qemu-block] [Qemu-devel] ping: [PATCH v13] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2016-02-02 Thread Programmingkid
On Feb 2, 2016, at 5:04 PM, Eric Blake wrote: > On 02/02/2016 02:23 PM, Programmingkid wrote: > >>> And why isn't bsd_path usable for that purpose? >> >> After trying it out, I found out why bsd_path isn't usable for that purpose. >> It is because the us

[Qemu-block] [PATCH v13] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2016-01-19 Thread Programmingkid
Mac OS X can be picky when it comes to allowing the user to use physical devices in QEMU. Most mounted volumes appear to be off limits to QEMU. If an issue is detected, a message is displayed showing the user how to unmount a volume. Now QEMU uses both CD and DVD media. Signed-off-by: John

[Qemu-block] ping: [PATCH v12] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2016-01-17 Thread Programmingkid
https://patchwork.ozlabs.org/patch/555945/ > Mac OS X can be picky when it comes to allowing the user > to use physical devices in QEMU. Most mounted volumes > appear to be off limits to QEMU. If an issue is detected, > a message is displayed showing the user how to unmount a > volume. > >

Re: [Qemu-block] ping Re: [PATCH v12] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2016-01-04 Thread Programmingkid
On Jan 4, 2016, at 11:35 AM, Max Reitz wrote: > On 29.12.2015 01:27, Programmingkid wrote: >> I do realize you are busy Kevin, but I would >> appreciate knowing my patch is in line >> for review. > > Primarily, he's been on holiday since before christmas until next

[Qemu-block] ping Re: [PATCH v12] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2015-12-28 Thread Programmingkid
I do realize you are busy Kevin, but I would appreciate knowing my patch is in line for review. https://patchwork.ozlabs.org/patch/555945/ On Dec 11, 2015, at 10:27 PM, Programmingkid wrote: > Mac OS X can be picky when it comes to allowing the user > to use physical devices in QEMU

[Qemu-block] ping Re: [PATCH v12] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2015-12-18 Thread Programmingkid
https://patchwork.ozlabs.org/patch/555945/ On Dec 11, 2015, at 10:27 PM, Programmingkid wrote: > Mac OS X can be picky when it comes to allowing the user > to use physical devices in QEMU. Most mounted volumes > appear to be off limits to QEMU. If an issue is detected, > a message

Re: [Qemu-block] ping [PATCH v11] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2015-12-11 Thread Programmingkid
On Dec 11, 2015, at 5:00 PM, Jeff Cody wrote: > On Thu, Dec 10, 2015 at 09:39:51AM -0500, Programmingkid wrote: >> https://patchwork.ozlabs.org/patch/550295/ >> >> Mac OS X can be picky when it comes to allowing the user >> to use physical devices in QEMU. Mos

[Qemu-block] [PATCH v12] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2015-12-11 Thread Programmingkid
Mac OS X can be picky when it comes to allowing the user to use physical devices in QEMU. Most mounted volumes appear to be off limits to QEMU. If an issue is detected, a message is displayed showing the user how to unmount a volume. Now QEMU uses both CD and DVD media. Signed-off-by: John

[Qemu-block] ping [PATCH v11] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2015-12-10 Thread Programmingkid
https://patchwork.ozlabs.org/patch/550295/ Mac OS X can be picky when it comes to allowing the user to use physical devices in QEMU. Most mounted volumes appear to be off limits to QEMU. If an issue is detected, a message is displayed showing the user how to unmount a volume. Signed-off-by: John

Re: [Qemu-block] QEMU being able to use audio cdroms

2015-12-08 Thread Programmingkid
On Dec 8, 2015, at 1:49 PM, John Snow wrote: > > > On 11/25/2015 03:44 PM, Programmingkid wrote: >> Is there any platform where a guest in QEMU can play an audio cd? If not, is >> this a feature that you would allow into QEMU? >> > > I haven't tested it,

Re: [Qemu-block] [Qemu-devel] [PATCH v9] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2015-11-30 Thread Programmingkid
On Nov 30, 2015, at 11:26 AM, Kevin Wolf wrote: > Am 30.11.2015 um 17:19 hat Eric Blake geschrieben: >> On 11/27/2015 12:35 PM, Programmingkid wrote: >> >>>> Unusual indentation; more typical is: >>>> >>>> | static kern_return_t FindEjec

Re: [Qemu-block] [Qemu-devel] [PATCH v10] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2015-11-30 Thread Programmingkid
On Nov 30, 2015, at 11:26 AM, Eric Blake wrote: > On 11/27/2015 02:49 PM, Programmingkid wrote: >> Mac OS X can be picky when it comes to allowing the user >> to use physical devices in QEMU. Most mounted volumes >> appear to be off limits to QEMU. If an issue is d

[Qemu-block] [PATCH v11] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2015-11-30 Thread Programmingkid
Mac OS X can be picky when it comes to allowing the user to use physical devices in QEMU. Most mounted volumes appear to be off limits to QEMU. If an issue is detected, a message is displayed showing the user how to unmount a volume. Signed-off-by: John Arbuckle ---

Re: [Qemu-block] [Qemu-devel] [PATCH v9] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2015-11-27 Thread Programmingkid
On Nov 25, 2015, at 11:23 PM, Eric Blake wrote: > On 11/25/2015 09:10 PM, Programmingkid wrote: >> Mac OS X can be picky when it comes to allowing the user >> to use physical devices in QEMU. Most mounted volumes >> appear to be off limits to QEMU. If an issue is d

Re: [Qemu-block] [Qemu-devel] [PATCH v9] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2015-11-27 Thread Programmingkid
On Nov 25, 2015, at 11:29 PM, Eric Blake wrote: > On 11/25/2015 09:23 PM, Eric Blake wrote: > >>> +static kern_return_t FindEjectableOpticalMedia(io_iterator_t >>> *mediaIterator, >>> +char >>> *mediaType) >> >> Unusual

[Qemu-block] [PATCH v8] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2015-11-25 Thread Programmingkid
Mac OS X can be picky when it comes to allowing the user to use physical devices in QEMU. Most mounted volumes appear to be off limits to QEMU. If an issue is detected, a message is displayed showing the user how to unmount a volume. Signed-off-by: John Arbuckle ---

[Qemu-block] [PATCH v9] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2015-11-25 Thread Programmingkid
Mac OS X can be picky when it comes to allowing the user to use physical devices in QEMU. Most mounted volumes appear to be off limits to QEMU. If an issue is detected, a message is displayed showing the user how to unmount a volume. Signed-off-by: John Arbuckle ---

[Qemu-block] QEMU being able to use audio cdroms

2015-11-25 Thread Programmingkid
Is there any platform where a guest in QEMU can play an audio cd? If not, is this a feature that you would allow into QEMU?

Re: [Qemu-block] [PATCH v6] raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2015-11-24 Thread Programmingkid
On Nov 24, 2015, at 9:38 AM, Kevin Wolf wrote: > > >> +/* If using a physical device */ >> +if (strstart(filename, "/dev/", NULL)) { >> +char bsdPath[MAXPATHLEN]; >> + >> +/* If the physical device is a cdrom */ >> +if (strcmp(filename, "/dev/cdrom") == 0) { > >

[Qemu-block] [PATCH] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2015-11-24 Thread Programmingkid
Mac OS X can be picky when it comes to allowing the user to use physical devices in QEMU. Most mounted volumes appear to be off limits to QEMU. If an issue is detected, a message is displayed showing the user how to unmount a volume. Signed-off-by: John Arbuckle ---

[Qemu-block] [PATCH v2] raw-posix.c: Make GetBSDPath() handle caching options

2015-11-20 Thread Programmingkid
Add support for caching options that can be specified from the command line. Signed-off-by: John Arbuckle --- Only location of code has been changed. block/raw-posix.c | 15 +-- 1 files changed, 9 insertions(+), 6 deletions(-) diff --git

[Qemu-block] [PATCH v6] raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2015-11-20 Thread Programmingkid
Mac OS X can be picky when it comes to allowing the user to use physical devices in QEMU. Most mounted volumes appear to be off limits to QEMU. If an issue is detected, a message is displayed showing the user how to unmount a volume. Signed-off-by: John Arbuckle ---

Re: [Qemu-block] [PATCH v5] raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2015-11-20 Thread Programmingkid
On Nov 20, 2015, at 11:26 AM, Kevin Wolf wrote: > Am 27.07.2015 um 19:05 hat Programmingkid geschrieben: >> Mac OS X can be picky when it comes to allowing the user to use physical >> devices >> in QEMU. Most mounted volumes appear to be off limits to QEMU. If an issue is &

Re: [Qemu-block] [Qemu-devel] [PATCH v3 1/4] util - add automated ID generation utility

2015-10-13 Thread Programmingkid
On Oct 13, 2015, at 11:26 AM, Markus Armbruster wrote: > Jeff Cody writes: > >> On Tue, Oct 13, 2015 at 09:37:29AM +0200, Markus Armbruster wrote: >>> Jeff Cody writes: >>> Multiple sub-systems in QEMU may find it useful to generate IDs for

[Qemu-block] ping: [PATCH v5] raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2015-09-12 Thread Programmingkid
> Mac OS X can be picky when it comes to allowing the user to use physical > devices > in QEMU. Most mounted volumes appear to be off limits to QEMU. If an issue is > detected, a message is displayed showing the user how to unmount a volume. > > Signed-off-by: John Arbuckle

Re: [Qemu-block] [PATCH] raw-posix.c: Make GetBSDPath() handle caching options

2015-07-28 Thread Programmingkid
On Jul 28, 2015, at 6:18 AM, Stefan Hajnoczi wrote: On Mon, Jul 27, 2015 at 12:28:03PM -0400, Programmingkid wrote: Add support for caching options that can be specified from the command line. Please squash this into the commit message when merging: Is this message meant for Kevin Wolf

[Qemu-block] [PATCH] raw-posix.c: Make GetBSDPath() handle caching options

2015-07-27 Thread Programmingkid
Add support for caching options that can be specified from the command line. Signed-off-by: John Arbuckle programmingk...@gmail.com --- block/raw-posix.c | 15 +-- 1 files changed, 9 insertions(+), 6 deletions(-) diff --git a/block/raw-posix.c b/block/raw-posix.c index

[Qemu-block] [PATCH v5] raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2015-07-27 Thread Programmingkid
Mac OS X can be picky when it comes to allowing the user to use physical devices in QEMU. Most mounted volumes appear to be off limits to QEMU. If an issue is detected, a message is displayed showing the user how to unmount a volume. Signed-off-by: John Arbuckle programmingk...@gmail.com ---

[Qemu-block] [PATCH v4] raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2015-07-24 Thread Programmingkid
Mac OS X can be picky when it comes to allowing the user to use physical devices in QEMU. Most mounted volumes appear to be off limits to QEMU. If an issue is detected, a message is displayed showing the user how to unmount a volume. Signed-off-by: John Arbuckle programmingk...@gmail.com ---

Re: [Qemu-block] [PATCH v2] raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2015-07-20 Thread Programmingkid
On Jul 20, 2015, at 8:46 AM, Laurent Vivier wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 20/07/2015 12:48, Stefan Hajnoczi wrote: On Fri, Jul 17, 2015 at 03:24:34PM -0400, Programmingkid wrote: On Jul 17, 2015, at 9:41 AM, Stefan Hajnoczi wrote: On Thu, Jul 16, 2015

Re: [Qemu-block] [PATCH v2] raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2015-07-17 Thread Programmingkid
On Jul 17, 2015, at 9:41 AM, Stefan Hajnoczi wrote: On Thu, Jul 16, 2015 at 04:46:07PM -0400, Programmingkid wrote: @@ -2014,7 +2015,9 @@ kern_return_t GetBSDPath( io_iterator_t mediaIterator, char *bsdPath, CFIndex ma if ( bsdPathAsCFString ) { size_t devPathLength

[Qemu-block] [PATCH v3] raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2015-07-17 Thread Programmingkid
Mac OS X can be picky when it comes to allowing the user to use physical devices in QEMU. Most mounted volumes appear to be off limits to QEMU. If an issue is detected, a message is displayed showing the user how to unmount a volume. Signed-off-by: John Arbuckle programmingk...@gmail.com ---

Re: [Qemu-block] [PATCH] raw-posix.c: Make physical devices usable in QEMU

2015-07-16 Thread Programmingkid
On Jul 16, 2015, at 9:19 AM, Stefan Hajnoczi wrote: On Thu, Jul 09, 2015 at 10:02:26AM -0400, Programmingkid wrote: On Jul 9, 2015, at 6:52 AM, Stefan Hajnoczi wrote: On Tue, Jul 07, 2015 at 01:33:23PM -0400, Programmingkid wrote: Make physical devices like a USB flash drive or a CDROM

[Qemu-block] [PATCH v2] raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2015-07-16 Thread Programmingkid
Mac OS X can be picky when it comes to allowing the user to use physical devices in QEMU. This patch fixes that issue by testing each physical device first before using it in QEMU. If an issue is detected, a message is displayed showing the user how to unmount a volume. Signed-off-by: John

Re: [Qemu-block] [PATCH] raw-posix.c: Make physical devices usable in QEMU

2015-07-16 Thread Programmingkid
On Jul 16, 2015, at 3:43 PM, Stefan Hajnoczi wrote: On Thu, Jul 16, 2015 at 6:26 PM, Programmingkid programmingk...@gmail.com wrote: On Jul 16, 2015, at 9:19 AM, Stefan Hajnoczi wrote: On Thu, Jul 09, 2015 at 10:02:26AM -0400, Programmingkid wrote: On Jul 9, 2015, at 6:52 AM, Stefan

Re: [Qemu-block] [PATCH] raw-posix.c: remove raw device access for cdrom

2015-07-08 Thread Programmingkid
On Jul 8, 2015, at 7:01 AM, Kevin Wolf wrote: Am 08.07.2015 um 12:47 hat Laurent Vivier geschrieben: On 08/07/2015 12:31, Kevin Wolf wrote: Am 02.07.2015 um 16:18 hat Laurent Vivier geschrieben: On 02/07/2015 16:03, Paolo Bonzini wrote: On 02/07/2015 15:58, Laurent Vivier wrote:

Re: [Qemu-block] [PATCH v2] raw-posix.c: remove raw device access for cdrom

2015-07-02 Thread Programmingkid
Allows QEMU running on Mac OS X guest to use the real CD-ROM drive. This patch doesn't actually remove raw device access. I'm just using the same name as the last patch. Why should we test for /dev/disk1s0 when /dev/rdisk1s0 works? By avoiding using the raw device we gain speed. When a read

[Qemu-block] [PATCH] raw-posix.c: remove raw device access for cdrom

2015-07-01 Thread Programmingkid
Fix real cdrom access in Mac OS X so it can be used in QEMU. It simply removes the r from a device file's name. This allows for a real cdrom to be accessible to the guest. It has been successfully tested with a Windows XP guest in qemu-system-i386. The qemu-system-ppc emulator doesn't quit

[Qemu-block] [PATCH] raw-posix.c: cd_is_inserted() implementation for Mac OS X

2015-06-29 Thread Programmingkid
Fix a problem with QEMU not being able to use real cd's on Mac OS X hosts. Implements a function called cd_is_inserted(). Signed-off-by: John Arbuckle programmingk...@gmail.com --- block/raw-posix.c | 25 - 1 files changed, 24 insertions(+), 1 deletions(-) diff --git

Re: [Qemu-block] [Qemu-devel] [PATCH] raw-posix.c: cd_is_inserted() implementation for Mac OS X

2015-06-29 Thread Programmingkid
On Jun 29, 2015, at 1:11 PM, Peter Maydell wrote: On 29 June 2015 at 17:54, Programmingkid programmingk...@gmail.com wrote: @@ -2365,6 +2384,10 @@ static BlockDriver bdrv_host_device = { .bdrv_ioctl = hdev_ioctl, .bdrv_aio_ioctl = hdev_aio_ioctl, #endif + +#ifdef

Re: [Qemu-block] [Qemu-devel] [PATCH] raw-posix.c: cd_is_inserted() implementation for Mac OS X

2015-06-29 Thread Programmingkid
On Jun 29, 2015, at 2:16 PM, Peter Maydell wrote: On 29 June 2015 at 19:04, Programmingkid programmingk...@gmail.com wrote: On Jun 29, 2015, at 1:11 PM, Peter Maydell wrote: On 29 June 2015 at 17:54, Programmingkid programmingk...@gmail.com wrote: @@ -2365,6 +2384,10 @@ static

Re: [Qemu-block] [Qemu-devel] [PATCH] raw-posix.c: cd_is_inserted() implementation for Mac OS X

2015-06-29 Thread Programmingkid
On Jun 29, 2015, at 4:43 PM, Laurent Vivier wrote: On 29/06/2015 20:37, Programmingkid wrote: On Jun 29, 2015, at 2:16 PM, Peter Maydell wrote: On 29 June 2015 at 19:04, Programmingkid programmingk...@gmail.com mailto:programmingk...@gmail.com wrote: On Jun 29, 2015, at 1:11 PM

Re: [Qemu-block] [Qemu-devel] [PATCH] block.c: fix real cdrom detection

2015-06-28 Thread Programmingkid
On Jun 25, 2015, at 2:01 PM, Peter Maydell wrote: On 25 June 2015 at 18:56, Programmingkid programmingk...@gmail.com wrote: Nice to hear from you again Laurent. The only way a solution in hdev_open() would work is if it could prevent find_image_format() from executing. Otherwise

Re: [Qemu-block] [Qemu-devel] [PATCH] block.c: fix real cdrom detection

2015-06-28 Thread Programmingkid
On Jun 28, 2015, at 8:29 PM, Laurent Vivier wrote: Hi, On 29/06/2015 01:43, Programmingkid wrote: On Jun 25, 2015, at 2:01 PM, Peter Maydell wrote: On 25 June 2015 at 18:56, Programmingkid programmingk...@gmail.com wrote: Nice to hear from you again Laurent. The only way a solution

Re: [Qemu-block] [PATCH] block.c: fix real cdrom detection

2015-06-26 Thread Programmingkid
On Jun 26, 2015, at 5:34 AM, Stefan Hajnoczi wrote: On Thu, Jun 25, 2015 at 11:11:24AM -0400, Programmingkid wrote: On Jun 25, 2015, at 9:31 AM, Stefan Hajnoczi wrote: On Tue, Jun 23, 2015 at 02:26:51PM -0400, Programmingkid wrote: On Jun 23, 2015, at 2:06 PM, John Snow wrote: So what's

Re: [Qemu-block] [Qemu-devel] [PATCH] block.c: fix real cdrom detection

2015-06-25 Thread Programmingkid
On Jun 25, 2015, at 11:14 AM, Programmingkid wrote: On Jun 25, 2015, at 2:53 AM, Markus Armbruster wrote: Programmingkid programmingk...@gmail.com writes: On Jun 23, 2015, at 2:06 PM, John Snow wrote: On 06/23/2015 01:56 PM, Programmingkid wrote: Fix real cdrom detection so

Re: [Qemu-block] [Qemu-devel] [PATCH] block.c: fix real cdrom detection

2015-06-25 Thread Programmingkid
On Jun 25, 2015, at 11:32 AM, Programmingkid wrote: On Jun 25, 2015, at 11:14 AM, Programmingkid wrote: On Jun 25, 2015, at 2:53 AM, Markus Armbruster wrote: Programmingkid programmingk...@gmail.com writes: On Jun 23, 2015, at 2:06 PM, John Snow wrote: On 06/23/2015 01:56 PM

Re: [Qemu-block] [Qemu-devel] [PATCH] block.c: fix real cdrom detection

2015-06-25 Thread Programmingkid
On Jun 25, 2015, at 11:48 AM, Paolo Bonzini wrote: On 25/06/2015 17:32, Programmingkid wrote: I think we are going to have to agree to disagree. I have never used the /dev/sr(0 | 1) devices and don't see how they would be effected by this patch. Are you trying to say the /dev/sr(0 | 1

Re: [Qemu-block] [Qemu-devel] [PATCH] block.c: fix real cdrom detection

2015-06-25 Thread Programmingkid
On Jun 25, 2015, at 12:12 PM, Laurent Vivier wrote: On 25/06/2015 17:48, Paolo Bonzini wrote: On 25/06/2015 17:32, Programmingkid wrote: I think we are going to have to agree to disagree. I have never used the /dev/sr(0 | 1) devices and don't see how they would be effected

Re: [Qemu-block] [PATCH] block.c: fix real cdrom detection

2015-06-23 Thread Programmingkid
On Jun 23, 2015, at 2:06 PM, John Snow wrote: On 06/23/2015 01:56 PM, Programmingkid wrote: Fix real cdrom detection so that a real cdrom can actually be used. signed-off-by: John Arbuckle programmingk...@gmail.com mailto:programmingk...@gmail.com This patch has been tested on Mac