Re: [Qemu-block] [PATCH V6] pci: removed the is_express field since a uniform interface was inserted

2018-02-05 Thread Yoni Bettan
On 01/16/2018 02:34 PM, Yoni Bettan wrote: according to Eduardo Habkost's commit fd3b02c889 all PCIEs now implement INTERFACE_PCIE_DEVICE so we don't need is_express field anymore. Devices that implements only INTERFACE_PCIE_DEVICE (is_express == 1) or devices that implements only

[Qemu-block] [PATCH V6] pci: removed the is_express field since a uniform interface was inserted

2018-01-16 Thread Yoni Bettan
Apfelbaum <mar...@redhat.com> Reviewed-by: Eduardo Habkost <ehabk...@redhat.com> Signed-off-by: Yoni Bettan <ybet...@redhat.com> --- V5 --> V6 : rebased on Michael S. Tsirkin pci branch as requested. V4 --> V5 : updated the patch to work with a new inserted device hw/xen/xe

Re: [Qemu-block] [PATCH V5] pci: removed the is_express field since a uniform interface was inserted

2017-12-19 Thread Yoni Bettan
On 12/18/2017 05:21 PM, Yoni Bettan wrote: according to Eduardo Habkost's commit fd3b02c889 all PCIEs now implement INTERFACE_PCIE_DEVICE so we don't need is_express field anymore. Devices that implements only INTERFACE_PCIE_DEVICE (is_express == 1) or devices that implements only

Re: [Qemu-block] [PATCH V5] pci: removed the is_express field since a uniform interface was inserted

2017-12-18 Thread Yoni Bettan
On 12/18/2017 05:21 PM, Yoni Bettan wrote: according to Eduardo Habkost's commit fd3b02c889 all PCIEs now implement INTERFACE_PCIE_DEVICE so we don't need is_express field anymore. Devices that implements only INTERFACE_PCIE_DEVICE (is_express == 1) or devices that implements only

[Qemu-block] [PATCH V5] pci: removed the is_express field since a uniform interface was inserted

2017-12-18 Thread Yoni Bettan
not affected by the change. The only devices that were affected are those that are hybrid and also had (is_express == 1) - therefor only: - hw/vfio/pci.c - hw/usb/hcd-xhci.c - hw/xen/xen_pt.c For those 3 I made sure that QEMU_PCI_CAP_EXPRESS is on in instance_init() Signed-off-by: Yoni

[Qemu-block] [PATCH V4] pci: removed the is_express field since a uniform interface was inserted

2017-12-11 Thread Yoni Bettan
/usb/hcd-xhci.c For both I made sure that QEMU_PCI_CAP_EXPRESS is on Signed-off-by: Yoni Bettan <ybet...@redhat.com> --- docs/pcie_pci_bridge.txt | 2 +- hw/block/nvme.c| 1 - hw/net/e1000e.c| 1 - hw/pci-bridge/pcie_pci_bridge.c

Re: [Qemu-block] [Qemu-devel] [PATCH V3] pci: removed the is_express field since a uniform interface was inserted

2017-12-11 Thread Yoni Bettan
On 12/11/2017 04:19 PM, Eduardo Habkost wrote: On Mon, Dec 11, 2017 at 03:11:39PM +0200, Yoni Bettan wrote: On 12/07/2017 10:58 PM, Eduardo Habkost wrote: On Tue, Dec 05, 2017 at 07:17:06PM +0200, Yoni Bettan wrote: * according to Eduardo Habkost's commit

Re: [Qemu-block] [Qemu-devel] [PATCH V3] pci: removed the is_express field since a uniform interface was inserted

2017-12-11 Thread Yoni Bettan
On 12/07/2017 10:58 PM, Eduardo Habkost wrote: On Tue, Dec 05, 2017 at 07:17:06PM +0200, Yoni Bettan wrote: * according to Eduardo Habkost's commit fd3b02c8896d597dd8b9e053dec579cf0386aee1 * since all PCIEs now implement INTERFACE_PCIE_DEVICE we don't

Re: [Qemu-block] [PATCH V3] pci: removed the is_express field since a uniform interface was inserted

2017-12-05 Thread Yoni Bettan
On 12/05/2017 07:17 PM, Yoni Bettan wrote: * according to Eduardo Habkost's commit fd3b02c8896d597dd8b9e053dec579cf0386aee1 * since all PCIEs now implement INTERFACE_PCIE_DEVICE we don't need this field anymore * Devices that where only

[Qemu-block] [PATCH V3] pci: removed the is_express field since a uniform interface was inserted

2017-12-05 Thread Yoni Bettan
/usb/hcd-xhci.c For both I made sure that QEMU_PCI_CAP_EXPRESS is on Signed-off-by: Yoni Bettan <ybet...@redhat.com> --- docs/pcie_pci_bridge.txt | 2 +- hw/block/nvme.c| 1 - hw/net/e1000e.c| 1 - hw/pci-bridge/pcie_pci_bridge.c

Re: [Qemu-block] [Qemu-devel] [PATCH v2] pci: removed the is_express field since a uniform interface was inserted

2017-12-05 Thread Yoni Bettan
On 12/04/2017 09:46 PM, Philippe Mathieu-Daudé wrote: Hi Yoni, Eduardo, Markus, On 12/04/2017 07:18 AM, Yoni Bettan wrote: * according to Eduardo Habkost's commit fd3b02c8896d597dd8b9e053dec579cf0386aee1 * since all PCIEs now implement INTERFACE_PCIE_DEVICE we

[Qemu-block] [PATCH v2] pci: removed the is_express field since a uniform interface was inserted

2017-12-04 Thread Yoni Bettan
/usb/hcd-xhci.c For both i made sure that pci_dev->cap_present |= QEMU_PCI_CAP_EXPRESS Signed-off-by: Yoni Bettan <ybet...@redhat.com> --- docs/pcie_pci_bridge.txt | 2 +- hw/block/nvme.c| 1 - hw/net/e1000e.c| 1 - hw/p

Re: [Qemu-block] [PATCH 1/2] pci: removed the is_express field since a uniform interface was inserted

2017-11-28 Thread Yoni Bettan
On 11/28/2017 07:51 AM, Yoni Bettan wrote: * according to Eduardo Habkost's commit fd3b02c8896d597dd8b9e053dec579cf0386aee1 * since all PCIEs now implement INTERFACE_PCIE_DEVICE we don't need this field anymore Hi, please discard this series, i

[Qemu-block] [PATCH 1/2] pci: removed the is_express field since a uniform interface was inserted

2017-11-27 Thread Yoni Bettan
* according to Eduardo Habkost's commit fd3b02c8896d597dd8b9e053dec579cf0386aee1 * since all PCIEs now implement INTERFACE_PCIE_DEVICE we don't need this field anymore Signed-off-by: Yoni Bettan <ybet...@redhat.com> --- hw/block/nvme.c

[Qemu-block] [PATCH] pci: removed the is_express field since a uniform interface was inserted

2017-11-27 Thread Yoni Bettan
* according to Eduardo Habkost's commit fd3b02c8896d597dd8b9e053dec579cf0386aee1 * since all PCIEs now implement INTERFACE_PCIE_DEVICE we don't need this field anymore Signed-off-by: Yoni Bettan <ybet...@redhat.com> --- hw/block/nvme.c