Re: [PATCH 0/2] hw/block/nvme: zoned fixes

2021-01-27 Thread Klaus Jensen
On Jan 19 14:54, Klaus Jensen wrote:
> From: Klaus Jensen 
> 
> Patch [1/2] fixes the zone append bug reported by Niklas. [2/2]
> refactors the zone write check function to return status codes in a
> different order if there are multiple zone write violations that apply.
> 
> Klaus Jensen (2):
>   hw/block/nvme: fix zone boundary check for append
>   hw/block/nvme: refactor the logic for zone write checks
> 
>  hw/block/nvme.c   | 89 +--
>  hw/block/trace-events |  5 +++
>  2 files changed, 48 insertions(+), 46 deletions(-)
> 
> -- 
> 2.30.0
> 
> 

Thanks all, applied to nvme-next.


signature.asc
Description: PGP signature


RE: [PATCH 0/2] hw/block/nvme: zoned fixes

2021-01-27 Thread Dmitry Fomichev
> -Original Message-
> From: Keith Busch 
> Sent: Wednesday, January 27, 2021 12:42 PM
> To: Klaus Jensen 
> Cc: qemu-de...@nongnu.org; Kevin Wolf ; Max Reitz
> ; qemu-block@nongnu.org; Dmitry Fomichev
> ; Klaus Jensen 
> Subject: Re: [PATCH 0/2] hw/block/nvme: zoned fixes
> 
> On Tue, Jan 19, 2021 at 02:54:58PM +0100, Klaus Jensen wrote:
> > From: Klaus Jensen 
> >
> > Patch [1/2] fixes the zone append bug reported by Niklas. [2/2]
> > refactors the zone write check function to return status codes in a
> > different order if there are multiple zone write violations that apply.
> 
> Looks good to me.
> 
> Reviewed-by: Keith Busch 

Besides aesthetics, I don't have any complaints about this series :)

Tested-by: Dmitry Fomichev 
Reviewed-by: Dmitry Fomichev 



Re: [PATCH 0/2] hw/block/nvme: zoned fixes

2021-01-27 Thread Keith Busch
On Tue, Jan 19, 2021 at 02:54:58PM +0100, Klaus Jensen wrote:
> From: Klaus Jensen 
> 
> Patch [1/2] fixes the zone append bug reported by Niklas. [2/2]
> refactors the zone write check function to return status codes in a
> different order if there are multiple zone write violations that apply.

Looks good to me.

Reviewed-by: Keith Busch 



Re: [PATCH 0/2] hw/block/nvme: zoned fixes

2021-01-25 Thread Dmitry Fomichev
On Mon, 2021-01-25 at 08:25 +0100, Klaus Jensen wrote:
> On Jan 19 14:54, Klaus Jensen wrote:
> > From: Klaus Jensen 
> > 
> > Patch [1/2] fixes the zone append bug reported by Niklas. [2/2]
> > refactors the zone write check function to return status codes in a
> > different order if there are multiple zone write violations that apply.
> > 
> > Klaus Jensen (2):
> >   hw/block/nvme: fix zone boundary check for append
> >   hw/block/nvme: refactor the logic for zone write checks
> > 
> >  hw/block/nvme.c   | 89 +--
> >  hw/block/trace-events |  5 +++
> >  2 files changed, 48 insertions(+), 46 deletions(-)
> > 
> 
> Pinging for a review. Dmitry maybe?

I am testing it now, will post my review shortly.

DF


Re: [PATCH 0/2] hw/block/nvme: zoned fixes

2021-01-24 Thread Klaus Jensen
On Jan 19 14:54, Klaus Jensen wrote:
> From: Klaus Jensen 
> 
> Patch [1/2] fixes the zone append bug reported by Niklas. [2/2]
> refactors the zone write check function to return status codes in a
> different order if there are multiple zone write violations that apply.
> 
> Klaus Jensen (2):
>   hw/block/nvme: fix zone boundary check for append
>   hw/block/nvme: refactor the logic for zone write checks
> 
>  hw/block/nvme.c   | 89 +--
>  hw/block/trace-events |  5 +++
>  2 files changed, 48 insertions(+), 46 deletions(-)
> 

Pinging for a review. Dmitry maybe?


signature.asc
Description: PGP signature


Re: [PATCH 0/2] hw/block/nvme: zoned fixes

2021-01-20 Thread Niklas Cassel
On Tue, Jan 19, 2021 at 02:54:58PM +0100, Klaus Jensen wrote:
> From: Klaus Jensen 
> 
> Patch [1/2] fixes the zone append bug reported by Niklas. [2/2]
> refactors the zone write check function to return status codes in a
> different order if there are multiple zone write violations that apply.
> 
> Klaus Jensen (2):
>   hw/block/nvme: fix zone boundary check for append
>   hw/block/nvme: refactor the logic for zone write checks
> 
>  hw/block/nvme.c   | 89 +--
>  hw/block/trace-events |  5 +++
>  2 files changed, 48 insertions(+), 46 deletions(-)
> 
> -- 
> 2.30.0
> 
> 

For the series:
Tested-by: Niklas Cassel 


[PATCH 0/2] hw/block/nvme: zoned fixes

2021-01-19 Thread Klaus Jensen
From: Klaus Jensen 

Patch [1/2] fixes the zone append bug reported by Niklas. [2/2]
refactors the zone write check function to return status codes in a
different order if there are multiple zone write violations that apply.

Klaus Jensen (2):
  hw/block/nvme: fix zone boundary check for append
  hw/block/nvme: refactor the logic for zone write checks

 hw/block/nvme.c   | 89 +--
 hw/block/trace-events |  5 +++
 2 files changed, 48 insertions(+), 46 deletions(-)

-- 
2.30.0