Re: [PATCH] qcow2-bitmaps: fix qcow2_can_store_new_dirty_bitmap

2019-10-11 Thread John Snow
On 10/11/19 6:02 AM, Vladimir Sementsov-Ogievskiy wrote: > 10.10.2019 21:46, John Snow wrote: >> >> >> On 10/10/19 11:39 AM, Eric Blake wrote: >>> On 6/7/19 1:53 PM, Vladimir Sementsov-Ogievskiy wrote: 07.06.2019 21:48, Vladimir Sementsov-Ogievskiy wrote: > qcow2_can_store_new_dirty_bit

Re: [PATCH] qcow2-bitmaps: fix qcow2_can_store_new_dirty_bitmap

2019-10-11 Thread Vladimir Sementsov-Ogievskiy
10.10.2019 21:46, John Snow wrote: > > > On 10/10/19 11:39 AM, Eric Blake wrote: >> On 6/7/19 1:53 PM, Vladimir Sementsov-Ogievskiy wrote: >>> 07.06.2019 21:48, Vladimir Sementsov-Ogievskiy wrote: qcow2_can_store_new_dirty_bitmap works wrong, as it considers only bitmaps already stored

Re: [PATCH] qcow2-bitmaps: fix qcow2_can_store_new_dirty_bitmap

2019-10-10 Thread John Snow
On 10/10/19 11:39 AM, Eric Blake wrote: > On 6/7/19 1:53 PM, Vladimir Sementsov-Ogievskiy wrote: >> 07.06.2019 21:48, Vladimir Sementsov-Ogievskiy wrote: >>> qcow2_can_store_new_dirty_bitmap works wrong, as it considers only >>> bitmaps already stored in the qcow2 image and ignores persistent >>

Re: [PATCH] qcow2-bitmaps: fix qcow2_can_store_new_dirty_bitmap

2019-10-10 Thread Eric Blake
On 6/7/19 1:53 PM, Vladimir Sementsov-Ogievskiy wrote: 07.06.2019 21:48, Vladimir Sementsov-Ogievskiy wrote: qcow2_can_store_new_dirty_bitmap works wrong, as it considers only bitmaps already stored in the qcow2 image and ignores persistent BdrvDirtyBitmap objects. So, let's instead count persi

[Qemu-block] [PATCH] qcow2-bitmaps: fix qcow2_can_store_new_dirty_bitmap

2019-06-07 Thread Vladimir Sementsov-Ogievskiy
qcow2_can_store_new_dirty_bitmap works wrong, as it considers only bitmaps already stored in the qcow2 image and ignores persistent BdrvDirtyBitmap objects. So, let's instead count persistent BdrvDirtyBitmaps. We load all qcow2 bitmaps on open, so there should not be any bitmap in the image for wh

Re: [Qemu-block] [PATCH] qcow2-bitmaps: fix qcow2_can_store_new_dirty_bitmap

2019-06-07 Thread Vladimir Sementsov-Ogievskiy
07.06.2019 21:48, Vladimir Sementsov-Ogievskiy wrote: > qcow2_can_store_new_dirty_bitmap works wrong, as it considers only > bitmaps already stored in the qcow2 image and ignores persistent > BdrvDirtyBitmap objects. > > So, let's instead count persistent BdrvDirtyBitmaps. We load all qcow2 > bitm