Wei Yang wrote:
> Use ROUND_UP() to define, which is a little bit easy to read.
>
> Signed-off-by: Wei Yang
Reviewed-by: Juan Quintela
On Sun, Oct 13, 2019 at 07:38:04PM -0700, Richard Henderson wrote:
>On 10/13/19 6:01 PM, Wei Yang wrote:
>>> No, please.
>>>
>>> (1) The compiler does not know that qemu_*host_page_size is a power of 2,
>>> and
>>> will generate a real division at runtime. The same is true for
>>>
On 10/13/19 6:01 PM, Wei Yang wrote:
>> No, please.
>>
>> (1) The compiler does not know that qemu_*host_page_size is a power of 2, and
>> will generate a real division at runtime. The same is true for
>> TARGET_PAGE_SIZE when TARGET_PAGE_BITS_VARY.
>>
>
> Confused
>
> The definition of
On Sun, Oct 13, 2019 at 11:56:35AM -0400, Richard Henderson wrote:
>On 10/12/19 10:11 PM, Wei Yang wrote:
>> Use ROUND_UP() to define, which is a little bit easy to read.
>>
>> Signed-off-by: Wei Yang
>> ---
>> include/exec/cpu-all.h | 7 +++
>> 1 file changed, 3 insertions(+), 4
On Sun, Oct 13, 2019 at 11:56:35AM -0400, Richard Henderson wrote:
> On 10/12/19 10:11 PM, Wei Yang wrote:
> > Use ROUND_UP() to define, which is a little bit easy to read.
> >
> > Signed-off-by: Wei Yang
> > ---
> > include/exec/cpu-all.h | 7 +++
> > 1 file changed, 3 insertions(+), 4
On 10/12/19 10:11 PM, Wei Yang wrote:
> Use ROUND_UP() to define, which is a little bit easy to read.
>
> Signed-off-by: Wei Yang
> ---
> include/exec/cpu-all.h | 7 +++
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/include/exec/cpu-all.h b/include/exec/cpu-all.h
>
On Sun, Oct 13, 2019 at 10:11:44AM +0800, Wei Yang wrote:
> Use ROUND_UP() to define, which is a little bit easy to read.
>
> Signed-off-by: Wei Yang
Reviewed-by: David Gibson
> ---
> include/exec/cpu-all.h | 7 +++
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git
On Sun, Oct 13, 2019 at 10:11:44AM +0800, Wei Yang wrote:
> Use ROUND_UP() to define, which is a little bit easy to read.
>
> Signed-off-by: Wei Yang
Reviewed-by: Michael S. Tsirkin
> ---
> include/exec/cpu-all.h | 7 +++
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git
Use ROUND_UP() to define, which is a little bit easy to read.
Signed-off-by: Wei Yang
---
include/exec/cpu-all.h | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/include/exec/cpu-all.h b/include/exec/cpu-all.h
index ad9ab85eb3..255bb186ac 100644
---