Re: [PATCH 11/14] block/qcow2-bitmap: return startus from qcow2_store_persistent_dirty_bitmaps

2020-09-17 Thread Alberto Garcia
On Wed 09 Sep 2020 08:59:27 PM CEST, Vladimir Sementsov-Ogievskiy wrote: > It's better to return status together with setting errp. It makes > possible to avoid error propagation. > > Signed-off-by: Vladimir Sementsov-Ogievskiy [...] > -void qcow2_store_persistent_dirty_bitmaps(BlockDriverState

Re: [PATCH 11/14] block/qcow2-bitmap: return startus from qcow2_store_persistent_dirty_bitmaps

2020-09-14 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 11.09.2020 18:22, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> 11.09.2020 14:21, Greg Kurz wrote: On Fri, 11 Sep 2020 13:18:32 +0300 Vladimir Sementsov-Ogievskiy wrote: [...] > Hmm.. With this series I understand

Re: [PATCH 11/14] block/qcow2-bitmap: return startus from qcow2_store_persistent_dirty_bitmaps

2020-09-11 Thread Vladimir Sementsov-Ogievskiy
11.09.2020 18:22, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: 11.09.2020 14:21, Greg Kurz wrote: On Fri, 11 Sep 2020 13:18:32 +0300 Vladimir Sementsov-Ogievskiy wrote: 11.09.2020 12:38, Greg Kurz wrote: s/startus/status On Wed, 9 Sep 2020 21:59:27 +0300 Vladimir

Re: [PATCH 11/14] block/qcow2-bitmap: return startus from qcow2_store_persistent_dirty_bitmaps

2020-09-11 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 11.09.2020 14:21, Greg Kurz wrote: >> On Fri, 11 Sep 2020 13:18:32 +0300 >> Vladimir Sementsov-Ogievskiy wrote: >> >>> 11.09.2020 12:38, Greg Kurz wrote: s/startus/status On Wed, 9 Sep 2020 21:59:27 +0300 Vladimir Sementsov-Ogievskiy

Re: [PATCH 11/14] block/qcow2-bitmap: return startus from qcow2_store_persistent_dirty_bitmaps

2020-09-11 Thread Vladimir Sementsov-Ogievskiy
11.09.2020 14:21, Greg Kurz wrote: On Fri, 11 Sep 2020 13:18:32 +0300 Vladimir Sementsov-Ogievskiy wrote: 11.09.2020 12:38, Greg Kurz wrote: s/startus/status On Wed, 9 Sep 2020 21:59:27 +0300 Vladimir Sementsov-Ogievskiy wrote: It's better to return status together with setting errp. It

Re: [PATCH 11/14] block/qcow2-bitmap: return startus from qcow2_store_persistent_dirty_bitmaps

2020-09-11 Thread Greg Kurz
On Fri, 11 Sep 2020 13:18:32 +0300 Vladimir Sementsov-Ogievskiy wrote: > 11.09.2020 12:38, Greg Kurz wrote: > > s/startus/status > > > > On Wed, 9 Sep 2020 21:59:27 +0300 > > Vladimir Sementsov-Ogievskiy wrote: > > > >> It's better to return status together with setting errp. It makes > >>

Re: [PATCH 11/14] block/qcow2-bitmap: return startus from qcow2_store_persistent_dirty_bitmaps

2020-09-11 Thread Vladimir Sementsov-Ogievskiy
11.09.2020 12:38, Greg Kurz wrote: s/startus/status On Wed, 9 Sep 2020 21:59:27 +0300 Vladimir Sementsov-Ogievskiy wrote: It's better to return status together with setting errp. It makes possible to avoid error propagation. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2.h

Re: [PATCH 11/14] block/qcow2-bitmap: return startus from qcow2_store_persistent_dirty_bitmaps

2020-09-11 Thread Greg Kurz
s/startus/status On Wed, 9 Sep 2020 21:59:27 +0300 Vladimir Sementsov-Ogievskiy wrote: > It's better to return status together with setting errp. It makes > possible to avoid error propagation. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/qcow2.h| 2 +- >

[PATCH 11/14] block/qcow2-bitmap: return startus from qcow2_store_persistent_dirty_bitmaps

2020-09-09 Thread Vladimir Sementsov-Ogievskiy
It's better to return status together with setting errp. It makes possible to avoid error propagation. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2.h| 2 +- block/qcow2-bitmap.c | 13 ++--- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git