Re: [PATCH 13/14] block/qcow2: qcow2_do_open: deal with errp

2020-09-17 Thread Vladimir Sementsov-Ogievskiy
17.09.2020 19:23, Alberto Garcia wrote: On Wed 09 Sep 2020 08:59:29 PM CEST, Vladimir Sementsov-Ogievskiy wrote: 1. Drop extra error propagation 2. Set errp always on failure. Generic bdrv_open_driver supports driver functions which can return negative value and forget to set errp. That's a

Re: [PATCH 13/14] block/qcow2: qcow2_do_open: deal with errp

2020-09-17 Thread Alberto Garcia
On Wed 09 Sep 2020 08:59:29 PM CEST, Vladimir Sementsov-Ogievskiy wrote: > 1. Drop extra error propagation > > 2. Set errp always on failure. Generic bdrv_open_driver supports driver > functions which can return negative value and forget to set errp. > That's a strange thing.. Let's improve

[PATCH 13/14] block/qcow2: qcow2_do_open: deal with errp

2020-09-09 Thread Vladimir Sementsov-Ogievskiy
1. Drop extra error propagation 2. Set errp always on failure. Generic bdrv_open_driver supports driver functions which can return negative value and forget to set errp. That's a strange thing.. Let's improve qcow2_do_open to not behave this way. This allows to simplify code in