Re: [PATCH 4/7] block/nvme: switch to a NVMeRequest freelist

2020-05-25 Thread Sergio Lopez
On Tue, May 19, 2020 at 06:11:35PM +0100, Stefan Hajnoczi wrote: > There are three issues with the current NVMeRequest->busy field: > 1. The busy field is accidentally accessed outside q->lock when request >submission fails. > 2. Waiters on free_req_queue are not woken when a request is

[PATCH 4/7] block/nvme: switch to a NVMeRequest freelist

2020-05-19 Thread Stefan Hajnoczi
There are three issues with the current NVMeRequest->busy field: 1. The busy field is accidentally accessed outside q->lock when request submission fails. 2. Waiters on free_req_queue are not woken when a request is returned early due to submission failure. 2. Finding a free request involves