Re: [PATCH 9/9] hw/ide/ahci: fix broken SError handling

2023-05-17 Thread John Snow
On Fri, Apr 28, 2023 at 9:23 AM Niklas Cassel wrote: > > From: Niklas Cassel > > When encountering an NCQ error, you should not write the NCQ tag to the > SError register. This is completely wrong. Mea culpa ... ! > > The SError register has a clear definition, where each bit represents a >

[PATCH 9/9] hw/ide/ahci: fix broken SError handling

2023-04-28 Thread Niklas Cassel
From: Niklas Cassel When encountering an NCQ error, you should not write the NCQ tag to the SError register. This is completely wrong. The SError register has a clear definition, where each bit represents a different error, see PxSERR definition in AHCI 1.3.1. If we write a random value (like