Re: [PATCH v2] block: Reject misaligned write requests with BDRV_REQ_NO_FALLBACK

2019-10-14 Thread Kevin Wolf
Am 14.10.2019 um 13:22 hat Alberto Garcia geschrieben: > On Mon 14 Oct 2019 11:26:01 AM CEST, Kevin Wolf wrote: > >> Signed-off-by: Alberto Garcia > > > > Thanks, applied to the block branch. > > I'm a bit late now, but a possible trivial optimization is to flip the > conditions, because

Re: [PATCH v2] block: Reject misaligned write requests with BDRV_REQ_NO_FALLBACK

2019-10-14 Thread Alberto Garcia
On Mon 14 Oct 2019 11:26:01 AM CEST, Kevin Wolf wrote: >> Signed-off-by: Alberto Garcia > > Thanks, applied to the block branch. I'm a bit late now, but a possible trivial optimization is to flip the conditions, because checking the flag should be faster than checking the alignment and it's

Re: [PATCH v2] block: Reject misaligned write requests with BDRV_REQ_NO_FALLBACK

2019-10-14 Thread Kevin Wolf
Am 14.10.2019 um 10:15 hat Alberto Garcia geschrieben: > The BDRV_REQ_NO_FALLBACK flag means that an operation should only be > performed if it can be offloaded or otherwise performed efficiently. > > However a misaligned write request requires a RMW so we should return > an error and let the

Re: [PATCH v2] block: Reject misaligned write requests with BDRV_REQ_NO_FALLBACK

2019-10-14 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191014081545.29694-1-be...@igalia.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!

[PATCH v2] block: Reject misaligned write requests with BDRV_REQ_NO_FALLBACK

2019-10-14 Thread Alberto Garcia
The BDRV_REQ_NO_FALLBACK flag means that an operation should only be performed if it can be offloaded or otherwise performed efficiently. However a misaligned write request requires a RMW so we should return an error and let the caller decide how to proceed. This hits an assertion since commit