Re: [PATCH v2] hw: m25p80: Add Block Protect and Top Bottom bits for write protect

2022-07-07 Thread Francisco Iglesias
Hi Iris On [2022 Jul 06] Wed 19:16:26, Iris Chen wrote: > Signed-off-by: Iris Chen A couple of suggestions below if you would like to go for a v3 but otherwise: Reviewed-by: Francisco Iglesias Thanks, Best regards, Francisco Iglesias > --- > Addressing all comments. > In reponse to this

[PATCH v2] hw: m25p80: Add Block Protect and Top Bottom bits for write protect

2022-07-06 Thread Iris Chen
Signed-off-by: Iris Chen --- Addressing all comments. In reponse to this comment: "Something wrong will occur if all block_protect[0123] are zeroes", the code actually ignores num_protected_sectors when block_protect_value = 0 which happens when block_protect[0123] are zeroes. You can refer to