Re: [bugfix ping2] Re: [PATCH v2 0/2] fix qcow2_can_store_new_dirty_bitmap

2019-12-11 Thread Vladimir Sementsov-Ogievskiy
10.12.2019 23:27, John Snow wrote: > > > On 12/10/19 8:24 AM, Max Reitz wrote: >> On 10.12.19 09:11, Max Reitz wrote: >>> On 09.12.19 23:03, Eric Blake wrote: On 12/9/19 11:58 AM, Max Reitz wrote: > On 09.12.19 17:30, Max Reitz wrote: >> On 02.12.19 15:09, Vladimir

Re: [bugfix ping2] Re: [PATCH v2 0/2] fix qcow2_can_store_new_dirty_bitmap

2019-12-10 Thread John Snow
On 12/10/19 8:24 AM, Max Reitz wrote: > On 10.12.19 09:11, Max Reitz wrote: >> On 09.12.19 23:03, Eric Blake wrote: >>> On 12/9/19 11:58 AM, Max Reitz wrote: On 09.12.19 17:30, Max Reitz wrote: > On 02.12.19 15:09, Vladimir Sementsov-Ogievskiy wrote: >> Hi again! >> >>

Re: [bugfix ping2] Re: [PATCH v2 0/2] fix qcow2_can_store_new_dirty_bitmap

2019-12-10 Thread Max Reitz
On 10.12.19 09:11, Max Reitz wrote: > On 09.12.19 23:03, Eric Blake wrote: >> On 12/9/19 11:58 AM, Max Reitz wrote: >>> On 09.12.19 17:30, Max Reitz wrote: On 02.12.19 15:09, Vladimir Sementsov-Ogievskiy wrote: > Hi again! > > Still forgotten bug-fix :( > > Is it too late

Re: [bugfix ping2] Re: [PATCH v2 0/2] fix qcow2_can_store_new_dirty_bitmap

2019-12-10 Thread Max Reitz
On 09.12.19 23:03, Eric Blake wrote: > On 12/9/19 11:58 AM, Max Reitz wrote: >> On 09.12.19 17:30, Max Reitz wrote: >>> On 02.12.19 15:09, Vladimir Sementsov-Ogievskiy wrote: Hi again! Still forgotten bug-fix :( Is it too late for 4.2? >>> >>> Sorry. :-/ >>> >>> Yes, I

Re: [bugfix ping2] Re: [PATCH v2 0/2] fix qcow2_can_store_new_dirty_bitmap

2019-12-09 Thread Eric Blake
On 12/9/19 11:58 AM, Max Reitz wrote: On 09.12.19 17:30, Max Reitz wrote: On 02.12.19 15:09, Vladimir Sementsov-Ogievskiy wrote: Hi again! Still forgotten bug-fix :( Is it too late for 4.2? Sorry. :-/ Yes, I think I just forgot it. I don’t think it’s too important for 4.2, so, well, it

Re: [bugfix ping2] Re: [PATCH v2 0/2] fix qcow2_can_store_new_dirty_bitmap

2019-12-09 Thread Max Reitz
On 09.12.19 17:30, Max Reitz wrote: > On 02.12.19 15:09, Vladimir Sementsov-Ogievskiy wrote: >> Hi again! >> >> Still forgotten bug-fix :( >> >> Is it too late for 4.2? > > Sorry. :-/ > > Yes, I think I just forgot it. I don’t think it’s too important for > 4.2, so, well, it isn’t too bad,

Re: [bugfix ping2] Re: [PATCH v2 0/2] fix qcow2_can_store_new_dirty_bitmap

2019-12-09 Thread Max Reitz
On 02.12.19 15:09, Vladimir Sementsov-Ogievskiy wrote: > Hi again! > > Still forgotten bug-fix :( > > Is it too late for 4.2? Sorry. :-/ Yes, I think I just forgot it. I don’t think it’s too important for 4.2, so, well, it isn’t too bad, but... Sorry. > I can't imagine better test, and it

Re: [bugfix ping2] Re: [PATCH v2 0/2] fix qcow2_can_store_new_dirty_bitmap

2019-12-02 Thread Vladimir Sementsov-Ogievskiy
Hi again! Still forgotten bug-fix :( Is it too late for 4.2? I can't imagine better test, and it tests exactly what written in https://bugzilla.redhat.com/show_bug.cgi?id=1712636 (Hmm, actually, I doubt that it is real use-case, more probably it's a bug in management layer) So, take this

[bugfix ping] Re: [PATCH v2 0/2] fix qcow2_can_store_new_dirty_bitmap

2019-10-25 Thread Vladimir Sementsov-Ogievskiy
Hi! Don't we forget it? Here is a bug-fix, I think we want it for 4.2. 14.10.2019 14:51, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > Here is a fix for persistent bitmaps managing: we must check existent > but not yet stored bitmaps for qcow2-related constraints, like maximum > number of

[PATCH v2 0/2] fix qcow2_can_store_new_dirty_bitmap

2019-10-14 Thread Vladimir Sementsov-Ogievskiy
Hi all! Here is a fix for persistent bitmaps managing: we must check existent but not yet stored bitmaps for qcow2-related constraints, like maximum number of bitmaps in qcow2 image. v2: 01: change assertion to error-return at function start Be free to add Reported-by: aihua liang

Re: [PATCH v2 0/2] fix qcow2_can_store_new_dirty_bitmap

2019-10-14 Thread Vladimir Sementsov-Ogievskiy
14.10.2019 14:51, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > Here is a fix for persistent bitmaps managing: we must check existent > but not yet stored bitmaps for qcow2-related constraints, like maximum > number of bitmaps in qcow2 image. > > v2: main thing based on