Re: [PATCH v2 1/3] ide/pci.c: introduce pci_ide_update_mode() function

2023-11-14 Thread Kevin Wolf
Am 13.11.2023 um 22:24 hat Mark Cave-Ayland geschrieben: > On 07/11/2023 11:11, Kevin Wolf wrote: > > > Am 06.11.2023 um 23:41 hat Mark Cave-Ayland geschrieben: > > > On 06/11/2023 14:12, Kevin Wolf wrote: > > > > > > Hi Kevin, > > > > > > Thanks for taking the time to review this. I'll reply

Re: [PATCH v2 1/3] ide/pci.c: introduce pci_ide_update_mode() function

2023-11-13 Thread BALATON Zoltan
On Mon, 13 Nov 2023, Mark Cave-Ayland wrote: On 07/11/2023 11:11, Kevin Wolf wrote: Am 06.11.2023 um 23:41 hat Mark Cave-Ayland geschrieben: On 06/11/2023 14:12, Kevin Wolf wrote: Hi Kevin, Thanks for taking the time to review this. I'll reply inline below. Am 25.10.2023 um 00:40 hat Mark

Re: [PATCH v2 1/3] ide/pci.c: introduce pci_ide_update_mode() function

2023-11-13 Thread Mark Cave-Ayland
On 07/11/2023 11:11, Kevin Wolf wrote: Am 06.11.2023 um 23:41 hat Mark Cave-Ayland geschrieben: On 06/11/2023 14:12, Kevin Wolf wrote: Hi Kevin, Thanks for taking the time to review this. I'll reply inline below. Am 25.10.2023 um 00:40 hat Mark Cave-Ayland geschrieben: This function reads

Re: [PATCH v2 1/3] ide/pci.c: introduce pci_ide_update_mode() function

2023-11-07 Thread Kevin Wolf
Am 06.11.2023 um 23:41 hat Mark Cave-Ayland geschrieben: > On 06/11/2023 14:12, Kevin Wolf wrote: > > Hi Kevin, > > Thanks for taking the time to review this. I'll reply inline below. > > > Am 25.10.2023 um 00:40 hat Mark Cave-Ayland geschrieben: > > > This function reads the value of the

Re: [PATCH v2 1/3] ide/pci.c: introduce pci_ide_update_mode() function

2023-11-06 Thread Mark Cave-Ayland
On 06/11/2023 14:12, Kevin Wolf wrote: Hi Kevin, Thanks for taking the time to review this. I'll reply inline below. Am 25.10.2023 um 00:40 hat Mark Cave-Ayland geschrieben: This function reads the value of the PCI_CLASS_PROG register for PCI IDE controllers and configures the PCI BARs

Re: [PATCH v2 1/3] ide/pci.c: introduce pci_ide_update_mode() function

2023-11-06 Thread Kevin Wolf
Am 25.10.2023 um 00:40 hat Mark Cave-Ayland geschrieben: > This function reads the value of the PCI_CLASS_PROG register for PCI IDE > controllers and configures the PCI BARs and/or IDE ioports accordingly. > > In the case where we switch to legacy mode, the PCI BARs are set to return > zero >

[PATCH v2 1/3] ide/pci.c: introduce pci_ide_update_mode() function

2023-10-24 Thread Mark Cave-Ayland
This function reads the value of the PCI_CLASS_PROG register for PCI IDE controllers and configures the PCI BARs and/or IDE ioports accordingly. In the case where we switch to legacy mode, the PCI BARs are set to return zero (as suggested in the "PCI IDE Controller" specification), the legacy IDE