Re: [PATCH v2 25/44] qom: Use return values to check for error where that's simpler

2020-07-04 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 02.07.2020 18:49, Markus Armbruster wrote: >> When using the Error object to check for error, we need to receive it >> into a local variable, then propagate() it to @errp. >> >> Using the return value permits allows receiving it straight to @errp. >> >> Sign

Re: [PATCH v2 25/44] qom: Use return values to check for error where that's simpler

2020-07-03 Thread Vladimir Sementsov-Ogievskiy
02.07.2020 18:49, Markus Armbruster wrote: When using the Error object to check for error, we need to receive it into a local variable, then propagate() it to @errp. Using the return value permits allows receiving it straight to @errp. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake

[PATCH v2 25/44] qom: Use return values to check for error where that's simpler

2020-07-02 Thread Markus Armbruster
When using the Error object to check for error, we need to receive it into a local variable, then propagate() it to @errp. Using the return value permits allows receiving it straight to @errp. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- qom/object.c | 16 +--- 1 fi