Re: [PATCH v2 4/5] block: simplify bdrv_child_user_desc()

2021-05-31 Thread Vladimir Sementsov-Ogievskiy
31.05.2021 18:50, Kevin Wolf wrote: Am 04.05.2021 um 11:45 hat Vladimir Sementsov-Ogievskiy geschrieben: All existing parent types (block nodes, block devices, jobs) has the realization. So, drop unreachable code. Signed-off-by: Vladimir Sementsov-Ogievskiy Your fixes the other days showed

Re: [PATCH v2 4/5] block: simplify bdrv_child_user_desc()

2021-05-31 Thread Kevin Wolf
Am 04.05.2021 um 11:45 hat Vladimir Sementsov-Ogievskiy geschrieben: > All existing parent types (block nodes, block devices, jobs) has the > realization. So, drop unreachable code. > > Signed-off-by: Vladimir Sementsov-Ogievskiy Your fixes the other days showed that vvfat has a BdrvChildClass,

Re: [PATCH v2 4/5] block: simplify bdrv_child_user_desc()

2021-05-10 Thread Vladimir Sementsov-Ogievskiy
10.05.2021 18:33, Alberto Garcia wrote: On Tue 04 May 2021 11:45:09 AM CEST, Vladimir Sementsov-Ogievskiy wrote: All existing parent types (block nodes, block devices, jobs) has the realization. So, drop unreachable code. s/has/have/ , and I'm not sure what "have the realization" means

Re: [PATCH v2 4/5] block: simplify bdrv_child_user_desc()

2021-05-10 Thread Alberto Garcia
On Tue 04 May 2021 11:45:09 AM CEST, Vladimir Sementsov-Ogievskiy wrote: > All existing parent types (block nodes, block devices, jobs) has the > realization. So, drop unreachable code. s/has/have/ , and I'm not sure what "have the realization" means > static char

[PATCH v2 4/5] block: simplify bdrv_child_user_desc()

2021-05-04 Thread Vladimir Sementsov-Ogievskiy
All existing parent types (block nodes, block devices, jobs) has the realization. So, drop unreachable code. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/block.c b/block.c index 54a3da9311..2f73523285 100644 ---