Re: [PATCH v2 4/5] qemu-iotests: let "check" spawn an arbitrary test command

2021-03-24 Thread Vladimir Sementsov-Ogievskiy
24.03.2021 00:20, Paolo Bonzini wrote: On 23/03/21 20:12, Vladimir Sementsov-Ogievskiy wrote: Move the trailing empty line to print_env(), since it always looks better and one caller was not adding it. Seems you've moved this fix from one unrelated commit to another.. And it touches two

Re: [PATCH v2 4/5] qemu-iotests: let "check" spawn an arbitrary test command

2021-03-23 Thread Paolo Bonzini
On 23/03/21 20:12, Vladimir Sementsov-Ogievskiy wrote: Move the trailing empty line to print_env(), since it always looks better and one caller was not adding it. Seems you've moved this fix from one unrelated commit to another.. And it touches two extra files. I'd just make it a separate

Re: [PATCH v2 4/5] qemu-iotests: let "check" spawn an arbitrary test command

2021-03-23 Thread Vladimir Sementsov-Ogievskiy
23.03.2021 21:19, Paolo Bonzini wrote: Right now there is no easy way for "check" to print a reproducer command. Because such a reproducer command line would be huge, we can instead teach check to start a command of our choice. This can be for example a Python unit test with arguments to only

[PATCH v2 4/5] qemu-iotests: let "check" spawn an arbitrary test command

2021-03-23 Thread Paolo Bonzini
Right now there is no easy way for "check" to print a reproducer command. Because such a reproducer command line would be huge, we can instead teach check to start a command of our choice. This can be for example a Python unit test with arguments to only run a specific subtest. Move the trailing