Re: [PATCH v3 0/8] misc AHCI cleanups

2023-08-31 Thread Philippe Mathieu-Daudé
Hi John, On 7/8/23 19:37, John Snow wrote: Apologies again for the delay. I tested it lightly and it seems fine to me (and in general I trust your commits as they've got meticulous references to the spec, so it'll be easy to fix if something goes wrong) It's my fault we'll miss this release

Re: [PATCH v3 0/8] misc AHCI cleanups

2023-08-07 Thread John Snow
On Mon, Aug 7, 2023, 6:33 AM Niklas Cassel wrote: > On Tue, Jul 25, 2023 at 03:00:56PM -0400, John Snow wrote: > > On Tue, Jul 25, 2023 at 9:04 AM Philippe Mathieu-Daudé > > wrote: > > > > > > Hi Niklas, John, Paolo, Kevin, > > > > > > On 19/7/23 12:47, Niklas Cassel wrote: > > > > > > >>

Re: [PATCH v3 0/8] misc AHCI cleanups

2023-08-07 Thread Niklas Cassel
On Tue, Jul 25, 2023 at 03:00:56PM -0400, John Snow wrote: > On Tue, Jul 25, 2023 at 9:04 AM Philippe Mathieu-Daudé > wrote: > > > > Hi Niklas, John, Paolo, Kevin, > > > > On 19/7/23 12:47, Niklas Cassel wrote: > > > > >> Niklas Cassel (8): > > >>hw/ide/ahci: remove stray backslash > > >>

Re: [PATCH v3 0/8] misc AHCI cleanups

2023-07-25 Thread John Snow
On Tue, Jul 25, 2023 at 9:04 AM Philippe Mathieu-Daudé wrote: > > Hi Niklas, John, Paolo, Kevin, > > On 19/7/23 12:47, Niklas Cassel wrote: > > >> Niklas Cassel (8): > >>hw/ide/ahci: remove stray backslash > >>hw/ide/core: set ERR_STAT in unsupported command completion > >>

Re: [PATCH v3 0/8] misc AHCI cleanups

2023-07-25 Thread Philippe Mathieu-Daudé
Hi Niklas, John, Paolo, Kevin, On 19/7/23 12:47, Niklas Cassel wrote: Niklas Cassel (8): hw/ide/ahci: remove stray backslash hw/ide/core: set ERR_STAT in unsupported command completion hw/ide/ahci: write D2H FIS when processing NCQ command hw/ide/ahci: simplify and document PxCI

Re: [PATCH v3 0/8] misc AHCI cleanups

2023-07-19 Thread Niklas Cassel
On Fri, Jun 09, 2023 at 04:08:36PM +0200, Niklas Cassel wrote: > From: Niklas Cassel > > Hello John, > > Here comes some misc AHCI cleanups. > > Most are related to error handling. > > Please review. > > Changes since v2: > -Squashed in the test commits that were sent out as a separate

[PATCH v3 0/8] misc AHCI cleanups

2023-06-09 Thread Niklas Cassel
From: Niklas Cassel Hello John, Here comes some misc AHCI cleanups. Most are related to error handling. Please review. Changes since v2: -Squashed in the test commits that were sent out as a separate series into the patch "hw/ide/ahci: PxCI should not get cleared when ERR_STAT is set", and