Re: [PATCH v3 8/8] hw/ide/ahci: fix broken SError handling

2023-07-19 Thread Philippe Mathieu-Daudé
On 19/7/23 14:06, Michael Tokarev wrote: 19.07.2023 14:59, Philippe Mathieu-Daudé wrote: On 9/6/23 16:08, Niklas Cassel wrote: From: Niklas Cassel When encountering an NCQ error, you should not write the NCQ tag to the SError register. This is completely wrong. The SError register has a

Re: [PATCH v3 8/8] hw/ide/ahci: fix broken SError handling

2023-07-19 Thread Michael Tokarev
19.07.2023 14:59, Philippe Mathieu-Daudé wrote: On 9/6/23 16:08, Niklas Cassel wrote: From: Niklas Cassel When encountering an NCQ error, you should not write the NCQ tag to the SError register. This is completely wrong. The SError register has a clear definition, where each bit represents a

Re: [PATCH v3 8/8] hw/ide/ahci: fix broken SError handling

2023-07-19 Thread Philippe Mathieu-Daudé
On 9/6/23 16:08, Niklas Cassel wrote: From: Niklas Cassel When encountering an NCQ error, you should not write the NCQ tag to the SError register. This is completely wrong. The SError register has a clear definition, where each bit represents a different error, see PxSERR definition in AHCI

[PATCH v3 8/8] hw/ide/ahci: fix broken SError handling

2023-06-09 Thread Niklas Cassel
From: Niklas Cassel When encountering an NCQ error, you should not write the NCQ tag to the SError register. This is completely wrong. The SError register has a clear definition, where each bit represents a different error, see PxSERR definition in AHCI 1.3.1. If we write a random value (like