RE: [PATCH v5 05/14] hw/block/nvme: Add support for Namespace Types

2020-10-01 Thread Dmitry Fomichev
qemu-block@nongnu.org; qemu-de...@nongnu.org; Alistair Francis > ; Matias Bjorling > Subject: Re: [PATCH v5 05/14] hw/block/nvme: Add support for Namespace > Types > > On Sep 28 11:35, Dmitry Fomichev wrote: > > From: Niklas Cassel > > > > Namespace Types introduce

Re: [PATCH v5 05/14] hw/block/nvme: Add support for Namespace Types

2020-10-01 Thread Klaus Jensen
On Sep 28 11:35, Dmitry Fomichev wrote: > From: Niklas Cassel > > Namespace Types introduce a new command set, "I/O Command Sets", > that allows the host to retrieve the command sets associated with > a namespace. Introduce support for the command set and enable > detection for the NVM Command

Re: [PATCH v5 05/14] hw/block/nvme: Add support for Namespace Types

2020-10-01 Thread Keith Busch
On Thu, Oct 01, 2020 at 04:23:56PM +, Niklas Cassel wrote: > But I see your point, all of this code: > > if (NVME_CC_CSS(data) != NVME_CC_CSS(n->bar.cc)) { > if (NVME_CC_EN(n->bar.cc)) { > NVME_GUEST_ERR(pci_nvme_err_change_css_when_enabled, >

Re: [PATCH v5 05/14] hw/block/nvme: Add support for Namespace Types

2020-10-01 Thread Niklas Cassel
On Thu, Oct 01, 2020 at 08:59:31AM -0700, Keith Busch wrote: > On Thu, Oct 01, 2020 at 03:50:35PM +, Niklas Cassel wrote: > > On Thu, Oct 01, 2020 at 09:29:22AM -0600, Keith Busch wrote: > > > On Thu, Oct 01, 2020 at 11:22:46AM +, Niklas Cassel wrote: > > > > On Mon, Sep 28, 2020 at

Re: [PATCH v5 05/14] hw/block/nvme: Add support for Namespace Types

2020-10-01 Thread Keith Busch
On Thu, Oct 01, 2020 at 03:50:35PM +, Niklas Cassel wrote: > On Thu, Oct 01, 2020 at 09:29:22AM -0600, Keith Busch wrote: > > On Thu, Oct 01, 2020 at 11:22:46AM +, Niklas Cassel wrote: > > > On Mon, Sep 28, 2020 at 11:35:19AM +0900, Dmitry Fomichev wrote: > > > > From: Niklas Cassel > > >

Re: [PATCH v5 05/14] hw/block/nvme: Add support for Namespace Types

2020-10-01 Thread Niklas Cassel
On Thu, Oct 01, 2020 at 09:29:22AM -0600, Keith Busch wrote: > On Thu, Oct 01, 2020 at 11:22:46AM +, Niklas Cassel wrote: > > On Mon, Sep 28, 2020 at 11:35:19AM +0900, Dmitry Fomichev wrote: > > > From: Niklas Cassel > > > @@ -,6 +2328,30 @@ static void nvme_write_bar(NvmeCtrl *n, hwaddr

Re: [PATCH v5 05/14] hw/block/nvme: Add support for Namespace Types

2020-10-01 Thread Keith Busch
On Thu, Oct 01, 2020 at 11:22:46AM +, Niklas Cassel wrote: > On Mon, Sep 28, 2020 at 11:35:19AM +0900, Dmitry Fomichev wrote: > > From: Niklas Cassel > > @@ -,6 +2328,30 @@ static void nvme_write_bar(NvmeCtrl *n, hwaddr > > offset, uint64_t data, > > break; > > case 0x14:

Re: [PATCH v5 05/14] hw/block/nvme: Add support for Namespace Types

2020-10-01 Thread Niklas Cassel
On Mon, Sep 28, 2020 at 11:35:19AM +0900, Dmitry Fomichev wrote: > From: Niklas Cassel > > Namespace Types introduce a new command set, "I/O Command Sets", > that allows the host to retrieve the command sets associated with > a namespace. Introduce support for the command set and enable >

Re: [PATCH v5 05/14] hw/block/nvme: Add support for Namespace Types

2020-09-30 Thread Niklas Cassel
On Mon, Sep 28, 2020 at 11:35:19AM +0900, Dmitry Fomichev wrote: > From: Niklas Cassel > > Namespace Types introduce a new command set, "I/O Command Sets", > that allows the host to retrieve the command sets associated with > a namespace. Introduce support for the command set and enable >

Re: [PATCH v5 05/14] hw/block/nvme: Add support for Namespace Types

2020-09-30 Thread Klaus Jensen
On Sep 28 11:35, Dmitry Fomichev wrote: > From: Niklas Cassel > > Namespace Types introduce a new command set, "I/O Command Sets", > that allows the host to retrieve the command sets associated with > a namespace. Introduce support for the command set and enable > detection for the NVM Command

[PATCH v5 05/14] hw/block/nvme: Add support for Namespace Types

2020-09-27 Thread Dmitry Fomichev
From: Niklas Cassel Namespace Types introduce a new command set, "I/O Command Sets", that allows the host to retrieve the command sets associated with a namespace. Introduce support for the command set and enable detection for the NVM Command Set. The new workflows for identify commands rely