Re: [PATCH v5 3/5] virtio-scsi: default num_queues to -smp N

2020-07-13 Thread Stefan Hajnoczi
On Wed, Jul 08, 2020 at 06:50:12PM +0200, Cornelia Huck wrote: > On Wed, 8 Jul 2020 14:05:26 +0100 > Stefan Hajnoczi wrote: > > > On Tue, Jul 07, 2020 at 05:44:53PM +0200, Cornelia Huck wrote: > > > On Mon, 6 Jul 2020 14:56:48 +0100 > > > Stefan Hajnoczi wrote: > > > > > diff --git

Re: [PATCH v5 3/5] virtio-scsi: default num_queues to -smp N

2020-07-08 Thread Stefan Hajnoczi
On Tue, Jul 07, 2020 at 05:44:53PM +0200, Cornelia Huck wrote: > On Mon, 6 Jul 2020 14:56:48 +0100 > Stefan Hajnoczi wrote: > > Maybe mention 'pci' in the subject as well? Actually splitting up the patch is hard due to the nvectors dependency on num_queues. I will leave it as a single patch

Re: [PATCH v5 3/5] virtio-scsi: default num_queues to -smp N

2020-07-08 Thread Stefan Hajnoczi
On Tue, Jul 07, 2020 at 05:44:53PM +0200, Cornelia Huck wrote: > On Mon, 6 Jul 2020 14:56:48 +0100 > Stefan Hajnoczi wrote: > > Maybe mention 'pci' in the subject as well? I think this patch does too many things. I'll split up the generic and PCI parts so that the commit message is more

Re: [PATCH v5 3/5] virtio-scsi: default num_queues to -smp N

2020-07-08 Thread Cornelia Huck
On Wed, 8 Jul 2020 14:05:26 +0100 Stefan Hajnoczi wrote: > On Tue, Jul 07, 2020 at 05:44:53PM +0200, Cornelia Huck wrote: > > On Mon, 6 Jul 2020 14:56:48 +0100 > > Stefan Hajnoczi wrote: > > > diff --git a/hw/virtio/virtio-scsi-pci.c b/hw/virtio/virtio-scsi-pci.c > > > index

Re: [PATCH v5 3/5] virtio-scsi: default num_queues to -smp N

2020-07-07 Thread Cornelia Huck
On Mon, 6 Jul 2020 14:56:48 +0100 Stefan Hajnoczi wrote: Maybe mention 'pci' in the subject as well? > Automatically size the number of virtio-scsi-pci, vhost-scsi-pci, and > vhost-user-scsi-pci request virtqueues to match the number of vCPUs. > Other transports continue to default to 1

[PATCH v5 3/5] virtio-scsi: default num_queues to -smp N

2020-07-06 Thread Stefan Hajnoczi
Automatically size the number of virtio-scsi-pci, vhost-scsi-pci, and vhost-user-scsi-pci request virtqueues to match the number of vCPUs. Other transports continue to default to 1 request virtqueue. A 1:1 virtqueue:vCPU mapping ensures that completion interrupts are handled on the same vCPU that