RE: [PATCH v6 01/11] hw/block/nvme: Add Commands Supported and Effects log

2020-10-18 Thread Dmitry Fomichev
t; Damien Le Moal ; qemu-block@nongnu.org; > qemu-de...@nongnu.org > Subject: Re: [PATCH v6 01/11] hw/block/nvme: Add Commands Supported > and Effects log > > On Wed, Oct 14, 2020 at 06:42:02AM +0900, Dmitry Fomichev wrote: > > +{ > > +NvmeEffectsLog log = {}; &

Re: [PATCH v6 01/11] hw/block/nvme: Add Commands Supported and Effects log

2020-10-14 Thread Niklas Cassel
On Tue, Oct 13, 2020 at 05:50:34PM -0700, Keith Busch wrote: > On Wed, Oct 14, 2020 at 06:42:02AM +0900, Dmitry Fomichev wrote: > > +{ > > +NvmeEffectsLog log = {}; > > +uint32_t *dst_acs = log.acs, *dst_iocs = log.iocs; > > +uint32_t trans_len; > > +int i; > > + > > +

Re: [PATCH v6 01/11] hw/block/nvme: Add Commands Supported and Effects log

2020-10-13 Thread Keith Busch
On Wed, Oct 14, 2020 at 06:42:02AM +0900, Dmitry Fomichev wrote: > +{ > +NvmeEffectsLog log = {}; > +uint32_t *dst_acs = log.acs, *dst_iocs = log.iocs; > +uint32_t trans_len; > +int i; > + > +trace_pci_nvme_cmd_supp_and_effects_log_read(); > + > +if (off >= sizeof(log)) { >

[PATCH v6 01/11] hw/block/nvme: Add Commands Supported and Effects log

2020-10-13 Thread Dmitry Fomichev
This log page becomes necessary to implement to allow checking for Zone Append command support in Zoned Namespace Command Set. This commit adds the code to report this log page for NVM Command Set only. The parts that are specific to zoned operation will be added later in the series. All