Re: [PATCH v6 02/10] migration: stop returning errno from load_snapshot()

2020-10-19 Thread Markus Armbruster
Eric Blake writes: > On 10/8/20 10:49 AM, Daniel P. Berrangé wrote: >> None of the callers care about the errno value since there is a full >> Error object populated. This gives consistency with save_snapshot() >> which already just returns -1. >> Reviewed-by: Dr. David Alan Gilbert >>

Re: [PATCH v6 02/10] migration: stop returning errno from load_snapshot()

2020-10-19 Thread Eric Blake
On 10/8/20 10:49 AM, Daniel P. Berrangé wrote: None of the callers care about the errno value since there is a full Error object populated. This gives consistency with save_snapshot() which already just returns -1. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé ---

[PATCH v6 02/10] migration: stop returning errno from load_snapshot()

2020-10-08 Thread Daniel P . Berrangé
None of the callers care about the errno value since there is a full Error object populated. This gives consistency with save_snapshot() which already just returns -1. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé --- migration/savevm.c | 15 +++ 1 file