Re: [PATCH v8 11/27] meson: Use -b to ignore CR vs. CR-LF issues on Windows

2020-09-14 Thread Peter Maydell
On Sun, 13 Sep 2020 at 19:51, Philippe Mathieu-Daudé wrote: > > On 9/13/20 6:01 PM, 罗勇刚(Yonggang Luo) wrote: > > > > > > On Sun, Sep 13, 2020 at 11:35 PM Philippe Mathieu-Daudé > > mailto:phi...@redhat.com>> wrote: > > > > On 9/13/20 12:44 AM, Yonggang Luo wrote: > > > On windows, a

Re: [PATCH v8 11/27] meson: Use -b to ignore CR vs. CR-LF issues on Windows

2020-09-14 Thread Yonggang Luo
On Mon, Sep 14, 2020 at 10:41 PM Peter Maydell wrote: > On Sun, 13 Sep 2020 at 19:51, Philippe Mathieu-Daudé > wrote: > > > > On 9/13/20 6:01 PM, 罗勇刚(Yonggang Luo) wrote: > > > > > > > > > On Sun, Sep 13, 2020 at 11:35 PM Philippe Mathieu-Daudé > > > mailto:phi...@redhat.com>> wrote: > > > > >

Re: [PATCH v8 11/27] meson: Use -b to ignore CR vs. CR-LF issues on Windows

2020-09-14 Thread Eric Blake
On 9/13/20 10:35 AM, Philippe Mathieu-Daudé wrote: On 9/13/20 12:44 AM, Yonggang Luo wrote: On windows, a difference in line endings causes testsuite failures complaining that every single line in files such as 'tests/qapi-schemadoc-good.texi' is wrong. Fix it by adding -b to diff. Isn't

Re: [PATCH v8 11/27] meson: Use -b to ignore CR vs. CR-LF issues on Windows

2020-09-13 Thread Philippe Mathieu-Daudé
On 9/13/20 6:01 PM, 罗勇刚(Yonggang Luo) wrote: > > > On Sun, Sep 13, 2020 at 11:35 PM Philippe Mathieu-Daudé > mailto:phi...@redhat.com>> wrote: > > On 9/13/20 12:44 AM, Yonggang Luo wrote: > > On windows, a difference in line endings causes testsuite failures > > complaining that

Re: [PATCH v8 11/27] meson: Use -b to ignore CR vs. CR-LF issues on Windows

2020-09-13 Thread Yonggang Luo
On Sun, Sep 13, 2020 at 11:35 PM Philippe Mathieu-Daudé wrote: > On 9/13/20 12:44 AM, Yonggang Luo wrote: > > On windows, a difference in line endings causes testsuite failures > > complaining that every single line in files such as > > 'tests/qapi-schemadoc-good.texi' is wrong. Fix it by

Re: [PATCH v8 11/27] meson: Use -b to ignore CR vs. CR-LF issues on Windows

2020-09-13 Thread Philippe Mathieu-Daudé
On 9/13/20 12:44 AM, Yonggang Luo wrote: > On windows, a difference in line endings causes testsuite failures > complaining that every single line in files such as > 'tests/qapi-schemadoc-good.texi' is wrong. Fix it by adding -b to diff. Isn't '--strip-trailing-cr' more adapted? > >

[PATCH v8 11/27] meson: Use -b to ignore CR vs. CR-LF issues on Windows

2020-09-12 Thread Yonggang Luo
On windows, a difference in line endings causes testsuite failures complaining that every single line in files such as 'tests/qapi-schemadoc-good.texi' is wrong. Fix it by adding -b to diff. Signed-off-by: Yonggang Luo Reviewed-by: Eric Blake Reviewed-by: Daniel P. Berrangé ---