Re: [Qemu-block] [PATCH] block/iscsi: handle zero events from iscsi_which_events

On Tue, Apr 7, 2015 at 9:08 PM, Peter Lieven wrote: > newer libiscsi versions may return zero events from iscsi_which_events. > > In this case iscsi_service will return immediately without any progress. > To avoid busy waiting for iscsi_which_events to change we deregister all > read and write han

Re: [Qemu-block] [PATCH] block/iscsi: handle zero events from iscsi_which_events

On Tue, Apr 7, 2015 at 9:08 PM, Peter Lieven wrote: CCing the entirety of this patch to qemu-de...@nongnu.org. It is also available in the qemu-block@nongnu.org mailing list archives: http://permalink.gmane.org/gmane.comp.emulators.qemu.block/460 > newer libiscsi versions may return zero events

Re: [Qemu-block] [PATCH] block/iscsi: handle zero events from iscsi_which_events

Am 08.04.2015 um 21:22 schrieb Stefan Hajnoczi: > On Wed, Apr 8, 2015 at 6:08 PM, ronnie sahlberg > wrote: >> The nice part with the current patch of Peter is that qemu and >> libiscsi can be upgraded/downgraded independently. > That's fine for avoiding hassles for existing apps, like QEMU, and I'

Re: [Qemu-block] [PATCH] block/iscsi: handle zero events from iscsi_which_events

On Wed, Apr 8, 2015 at 6:08 PM, ronnie sahlberg wrote: > The nice part with the current patch of Peter is that qemu and > libiscsi can be upgraded/downgraded independently. That's fine for avoiding hassles for existing apps, like QEMU, and I'm happy to merge the patch. For the library's API desi

Re: [Qemu-block] [PATCH] block/iscsi: handle zero events from iscsi_which_events

On Wed, Apr 8, 2015 at 1:38 AM, Stefan Hajnoczi wrote: > On Tue, Apr 7, 2015 at 9:08 PM, Peter Lieven wrote: > > Please CC qemu-de...@nongnu.org in the future. All patches must be on > the qemu-devel mailing list so they can be merged (for transparency). > I have added qemu-devel to CC. > >> +

Re: [Qemu-block] [PATCH] block/iscsi: handle zero events from iscsi_which_events

On Tue, Apr 7, 2015 at 9:08 PM, Peter Lieven wrote: Please CC qemu-de...@nongnu.org in the future. All patches must be on the qemu-devel mailing list so they can be merged (for transparency). I have added qemu-devel to CC. > +/* newer versions of libiscsi may return zero events. In this > +

[Qemu-block] [PATCH] block/iscsi: handle zero events from iscsi_which_events

newer libiscsi versions may return zero events from iscsi_which_events. In this case iscsi_service will return immediately without any progress. To avoid busy waiting for iscsi_which_events to change we deregister all read and write handlers in this case and schedule a timer to periodically check