Re: [Qemu-block] [PATCH] block: workaround for unaligned byte range in fallocate()

2019-08-27 Thread Eric Blake
On 8/27/19 7:39 AM, Andrey Shinkevich wrote: > > >>> >> >> Reviewed-by: Eric Blake >> > Eric, > If you are good to take this patch to your branch with your corrections, > please let us know. Otherwise, I will send the v2 with your corrections. Since I based my fast-zero patches on top of this

Re: [Qemu-block] [PATCH] block: workaround for unaligned byte range in fallocate()

2019-08-27 Thread Andrey Shinkevich
On 23/08/2019 00:09, Eric Blake wrote: > On 8/22/19 1:31 PM, Andrey Shinkevich wrote: >> Revert the commit 118f99442d 'block/io.c: fix for the allocation failure' >> and make better error handling for the file systems that do not support > > s/make/use/ > >> fallocate() for the unaligned byte r

Re: [Qemu-block] [PATCH] block: workaround for unaligned byte range in fallocate()

2019-08-27 Thread Denis V. Lunev
On 8/22/19 11:09 PM, Eric Blake wrote: > On 8/22/19 1:31 PM, Andrey Shinkevich wrote: >> Revert the commit 118f99442d 'block/io.c: fix for the allocation failure' >> and make better error handling for the file systems that do not support > s/make/use/ > >> fallocate() for the unaligned byte range.

Re: [Qemu-block] [PATCH] block: workaround for unaligned byte range in fallocate()

2019-08-23 Thread Andrey Shinkevich
On 23/08/2019 00:09, Eric Blake wrote: > On 8/22/19 1:31 PM, Andrey Shinkevich wrote: >> Revert the commit 118f99442d 'block/io.c: fix for the allocation failure' >> and make better error handling for the file systems that do not support > > s/make/use/ > >> fallocate() for the unaligned byte r

Re: [Qemu-block] [PATCH] block: workaround for unaligned byte range in fallocate()

2019-08-22 Thread Eric Blake
On 8/22/19 1:31 PM, Andrey Shinkevich wrote: > Revert the commit 118f99442d 'block/io.c: fix for the allocation failure' > and make better error handling for the file systems that do not support s/make/use/ > fallocate() for the unaligned byte range. Allow falling back to pwrite s/the/an/ > in

Re: [Qemu-block] [PATCH] block: workaround for unaligned byte range in fallocate()

2019-08-22 Thread Vladimir Sementsov-Ogievskiy
22.08.2019 21:55, Vladimir Sementsov-Ogievskiy wrote: > 22.08.2019 21:31, Andrey Shinkevich wrote: >> Revert the commit 118f99442d 'block/io.c: fix for the allocation failure' >> and make better error handling for the file systems that do not support >> fallocate() for the unaligned byte range. All

Re: [Qemu-block] [PATCH] block: workaround for unaligned byte range in fallocate()

2019-08-22 Thread Vladimir Sementsov-Ogievskiy
22.08.2019 21:31, Andrey Shinkevich wrote: > Revert the commit 118f99442d 'block/io.c: fix for the allocation failure' > and make better error handling for the file systems that do not support > fallocate() for the unaligned byte range. Allow falling back to pwrite > in case fallocate() returns EIN

[Qemu-block] [PATCH] block: workaround for unaligned byte range in fallocate()

2019-08-22 Thread Andrey Shinkevich
Revert the commit 118f99442d 'block/io.c: fix for the allocation failure' and make better error handling for the file systems that do not support fallocate() for the unaligned byte range. Allow falling back to pwrite in case fallocate() returns EINVAL. Suggested-by: Kevin Wolf Suggested-by: Eric