Re: [Qemu-block] [PATCH] qcow2: Support BDRV_REQ_MAY_UNMAP

On 29.09.2016 10:10, Fam Zheng wrote: > On Thu, 09/29 09:58, Paolo Bonzini wrote: >> >> >> On 29/09/2016 04:21, Fam Zheng wrote: >>> On Wed, 09/28 18:11, Max Reitz wrote: Note that BDRV_REQ_MAY_UNMAP does not mean "Yes, please discard" but just "You may discard if it's easier for you".

Re: [Qemu-block] [PATCH] qcow2: Support BDRV_REQ_MAY_UNMAP

On Thu, 09/29 09:58, Paolo Bonzini wrote: > > > On 29/09/2016 04:21, Fam Zheng wrote: > > On Wed, 09/28 18:11, Max Reitz wrote: > >> Note that BDRV_REQ_MAY_UNMAP does not mean "Yes, please discard" but > >> just "You may discard if it's easier for you". But it's actually not > >> easier for us,

Re: [Qemu-block] [PATCH] qcow2: Support BDRV_REQ_MAY_UNMAP

On 29/09/2016 04:21, Fam Zheng wrote: > On Wed, 09/28 18:11, Max Reitz wrote: >> Note that BDRV_REQ_MAY_UNMAP does not mean "Yes, please discard" but >> just "You may discard if it's easier for you". But it's actually not >> easier for us, so I don't see why we're doing it. >> >> As far as I can

Re: [Qemu-block] [PATCH] qcow2: Support BDRV_REQ_MAY_UNMAP

On Wed, 09/28 18:11, Max Reitz wrote: > On 28.09.2016 09:04, Fam Zheng wrote: > > Handling this is similar to what is done to the L2 entry in the case of > > compressed clusters. > > > > Signed-off-by: Fam Zheng > > --- > > block/qcow2-cluster.c | 9 + > > block/qcow2.c

Re: [Qemu-block] [PATCH] qcow2: Support BDRV_REQ_MAY_UNMAP

On 28.09.2016 09:04, Fam Zheng wrote: > Handling this is similar to what is done to the L2 entry in the case of > compressed clusters. > > Signed-off-by: Fam Zheng > --- > block/qcow2-cluster.c | 9 + > block/qcow2.c | 3 ++- > block/qcow2.h | 3 ++- > 3

[Qemu-block] [PATCH] qcow2: Support BDRV_REQ_MAY_UNMAP

Handling this is similar to what is done to the L2 entry in the case of compressed clusters. Signed-off-by: Fam Zheng --- block/qcow2-cluster.c | 9 + block/qcow2.c | 3 ++- block/qcow2.h | 3 ++- 3 files changed, 9 insertions(+), 6 deletions(-) diff