Re: [Qemu-block] [PATCH] qemu-img: improve convert_iteration_sectors()

2017-04-26 Thread Max Reitz
On 20.04.2017 01:06, John Snow wrote: > > > On 04/07/2017 07:34 AM, Vladimir Sementsov-Ogievskiy wrote: >> Do not do extra call to _get_block_status() >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> --- >> >> Also, I'm not sure about last line: >> s->status =

Re: [Qemu-block] [PATCH] qemu-img: improve convert_iteration_sectors()

2017-04-26 Thread Max Reitz
On 07.04.2017 13:34, Vladimir Sementsov-Ogievskiy wrote: > Do not do extra call to _get_block_status() > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > > Also, I'm not sure about last line: > s->status = s->target_has_backing ? BLK_BACKING_FILE : BLK_DATA; > >

Re: [Qemu-block] [PATCH] qemu-img: improve convert_iteration_sectors()

2017-04-19 Thread John Snow
On 04/07/2017 07:34 AM, Vladimir Sementsov-Ogievskiy wrote: > Do not do extra call to _get_block_status() > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > > Also, I'm not sure about last line: > s->status = s->target_has_backing ? BLK_BACKING_FILE : BLK_DATA;

[Qemu-block] [PATCH] qemu-img: improve convert_iteration_sectors()

2017-04-07 Thread Vladimir Sementsov-Ogievskiy
Do not do extra call to _get_block_status() Signed-off-by: Vladimir Sementsov-Ogievskiy --- Also, I'm not sure about last line: s->status = s->target_has_backing ? BLK_BACKING_FILE : BLK_DATA; (which is equal to old code) may be, it should be s->status =