Re: [Qemu-block] [PATCH] qmp: fill in the image field in BlockDeviceInfo

2015-04-22 Thread Stefan Hajnoczi
On Fri, Apr 17, 2015 at 02:52:43PM +0300, Alberto Garcia wrote: > The image field in BlockDeviceInfo is supposed to contain an ImageInfo > object. However that is being filled in by bdrv_query_info(), not by > bdrv_block_device_info(), which is where BlockDeviceInfo is actually > created. > > Anyo

Re: [Qemu-block] [PATCH] qmp: fill in the image field in BlockDeviceInfo

2015-04-21 Thread Kevin Wolf
Am 21.04.2015 um 15:28 hat Stefan Hajnoczi geschrieben: > On Fri, Apr 17, 2015 at 02:52:43PM +0300, Alberto Garcia wrote: > > The image field in BlockDeviceInfo is supposed to contain an ImageInfo > > object. However that is being filled in by bdrv_query_info(), not by > > bdrv_block_device_info(),

Re: [Qemu-block] [PATCH] qmp: fill in the image field in BlockDeviceInfo

2015-04-21 Thread Stefan Hajnoczi
On Fri, Apr 17, 2015 at 02:52:43PM +0300, Alberto Garcia wrote: > The image field in BlockDeviceInfo is supposed to contain an ImageInfo > object. However that is being filled in by bdrv_query_info(), not by > bdrv_block_device_info(), which is where BlockDeviceInfo is actually > created. > > Anyo

Re: [Qemu-block] [PATCH] qmp: fill in the image field in BlockDeviceInfo

2015-04-17 Thread Alberto Garcia
On Fri 17 Apr 2015 01:52:43 PM CEST, Alberto Garcia wrote: > Anyone calling bdrv_block_device_info() directly will get a null image > field. As a consequence of this, the HMP command 'info block -n -v' > crashes QEMU. > > This patch moves the code that fills in that field from > bdrv_query_info()

[Qemu-block] [PATCH] qmp: fill in the image field in BlockDeviceInfo

2015-04-17 Thread Alberto Garcia
The image field in BlockDeviceInfo is supposed to contain an ImageInfo object. However that is being filled in by bdrv_query_info(), not by bdrv_block_device_info(), which is where BlockDeviceInfo is actually created. Anyone calling bdrv_block_device_info() directly will get a null image field. As