Re: [Qemu-block] [PATCH 00/15] Implement TLS support to QEMU NBD server & client

2015-12-03 Thread Wouter Verhelst
Hi all, On Fri, Nov 27, 2015 at 03:06:51PM +0100, Wouter Verhelst wrote: > I have been thinking of adding a message NBD_OPT_SELECT_EXPORT to > replace NBD_OPT_EXPORT_NAME, which would select an export but not end > negotiation. That would also require another message to end negotiation > and move

Re: [Qemu-block] [PATCH 00/15] Implement TLS support to QEMU NBD server & client

2015-12-02 Thread Wouter Verhelst
On Wed, Dec 02, 2015 at 01:37:08PM +, Daniel P. Berrange wrote: > On Wed, Dec 02, 2015 at 01:56:30PM +0100, Wouter Verhelst wrote: > > Hi Daniel, > > > > Something occurred to me earlier today: > > > > On Fri, Nov 27, 2015 at 12:20:38PM +, Daniel P. Berrange wrote: > > > As is, if the

Re: [Qemu-block] [PATCH 00/15] Implement TLS support to QEMU NBD server & client

2015-12-02 Thread Daniel P. Berrange
On Wed, Dec 02, 2015 at 01:56:30PM +0100, Wouter Verhelst wrote: > Hi Daniel, > > Something occurred to me earlier today: > > On Fri, Nov 27, 2015 at 12:20:38PM +, Daniel P. Berrange wrote: > > As is, if the client connects to a TLS enabled NBD server and then > > immediately sends

Re: [Qemu-block] [PATCH 00/15] Implement TLS support to QEMU NBD server & client

2015-12-02 Thread Wouter Verhelst
Hi Daniel, Something occurred to me earlier today: On Fri, Nov 27, 2015 at 12:20:38PM +, Daniel P. Berrange wrote: > As is, if the client connects to a TLS enabled NBD server and then > immediately sends NBD_OPT_EXPORT_NAME, it is not possible for us > to send back NBD_REP_ERR_TLS_REQD as

[Qemu-block] [PATCH 00/15] Implement TLS support to QEMU NBD server & client

2015-11-27 Thread Daniel P. Berrange
This series of patches implements support for TLS in the QEMU NBD server and client code. It is implementing the NBD_OPT_STARTTLS option that was previously discussed here: https://www.redhat.com/archives/libvir-list/2014-October/msg00506.html And is also described in the NBD spec here:

Re: [Qemu-block] [PATCH 00/15] Implement TLS support to QEMU NBD server & client

2015-11-27 Thread Wouter Verhelst
[nbd-general added to Cc] Hi Daniel, On Fri, Nov 27, 2015 at 12:20:38PM +, Daniel P. Berrange wrote: > This series of patches implements support for TLS in the QEMU NBD > server and client code. > > It is implementing the NBD_OPT_STARTTLS option that was previously > discussed here: > >