Re: [Qemu-block] [PATCH 03/10] hw: Use CFI_PFLASH0{1, 2} and TYPE_CFI_PFLASH0{1, 2}

Markus Armbruster writes: > We have two open-coded copies of macro CFI_PFLASH01(). Move the macro > to the header, so we can ditch the copies. Move CFI_PFLASH02() to the > header for symmetry. > > We define macros TYPE_CFI_PFLASH01 and TYPE_CFI_PFLASH02 for type name > strings, then mostly

[Qemu-block] [PATCH 03/10] hw: Use CFI_PFLASH0{1, 2} and TYPE_CFI_PFLASH0{1, 2}

We have two open-coded copies of macro CFI_PFLASH01(). Move the macro to the header, so we can ditch the copies. Move CFI_PFLASH02() to the header for symmetry. We define macros TYPE_CFI_PFLASH01 and TYPE_CFI_PFLASH02 for type name strings, then mostly use the strings. If the macros are worth