Re: [Qemu-block] [PATCH 05/34] block: Use macro for cache option names

On Fri 08 May 2015 07:21:37 PM CEST, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf Reviewed-by: Alberto Garcia Berto

Re: [Qemu-block] [PATCH 05/34] block: Use macro for cache option names

On Fri, May 08, 2015 at 07:21:37PM +0200, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > blockdev.c| 24 > include/block/block.h | 8 > 2 files changed, 20 insertions(+), 12 deletions(-) > > diff --git a/blockdev.c b/blockdev.c > index 5eaf77

Re: [Qemu-block] [PATCH 05/34] block: Use macro for cache option names

On 08.05.2015 19:21, Kevin Wolf wrote: Signed-off-by: Kevin Wolf --- blockdev.c| 24 include/block/block.h | 8 2 files changed, 20 insertions(+), 12 deletions(-) Reviewed-by: Max Reitz

Re: [Qemu-block] [PATCH 05/34] block: Use macro for cache option names

On 11.05.2015 16:51, Kevin Wolf wrote: Am 11.05.2015 um 16:40 hat Max Reitz geschrieben: On 08.05.2015 19:21, Kevin Wolf wrote: Signed-off-by: Kevin Wolf --- blockdev.c| 24 include/block/block.h | 8 2 files changed, 20 insertions(+), 12 dele

Re: [Qemu-block] [PATCH 05/34] block: Use macro for cache option names

Am 11.05.2015 um 16:40 hat Max Reitz geschrieben: > On 08.05.2015 19:21, Kevin Wolf wrote: > >Signed-off-by: Kevin Wolf > >--- > > blockdev.c| 24 > > include/block/block.h | 8 > > 2 files changed, 20 insertions(+), 12 deletions(-) > > Any reason f

Re: [Qemu-block] [PATCH 05/34] block: Use macro for cache option names

On 08.05.2015 19:21, Kevin Wolf wrote: Signed-off-by: Kevin Wolf --- blockdev.c| 24 include/block/block.h | 8 2 files changed, 20 insertions(+), 12 deletions(-) Any reason for not making it part of the BLOCK_OPT_* macros in block_int.h? Max

[Qemu-block] [PATCH 05/34] block: Use macro for cache option names

Signed-off-by: Kevin Wolf --- blockdev.c| 24 include/block/block.h | 8 2 files changed, 20 insertions(+), 12 deletions(-) diff --git a/blockdev.c b/blockdev.c index 5eaf77e..77cbe72 100644 --- a/blockdev.c +++ b/blockdev.c @@ -391,13 +391,13 @@ st