Re: [Qemu-block] [PATCH 06/11] qmp: Add an implementation wrapper for qmp_drive_backup

2015-03-17 Thread Eric Blake
On 03/17/2015 01:16 PM, John Snow wrote: >> Other than that, I'm okay with a forward-declaration; if you want to >> move it, but I'd be fine with moving the code, too. >> >> With _drive_backup() being called do_drive_backup(): >> >> Reviewed-by: Max Reitz >> > > Moving the code around might be b

Re: [Qemu-block] [PATCH 06/11] qmp: Add an implementation wrapper for qmp_drive_backup

2015-03-17 Thread Max Reitz
On 2015-03-17 at 15:16, John Snow wrote: On 03/17/2015 02:51 PM, Max Reitz wrote: On 2015-03-04 at 23:15, John Snow wrote: We'd like to be able to specify the callback given to backup_start manually in the case of transactions, so split apart qmp_drive_backup into an implementation and a wrap

Re: [Qemu-block] [PATCH 06/11] qmp: Add an implementation wrapper for qmp_drive_backup

2015-03-17 Thread John Snow
On 03/17/2015 02:51 PM, Max Reitz wrote: On 2015-03-04 at 23:15, John Snow wrote: We'd like to be able to specify the callback given to backup_start manually in the case of transactions, so split apart qmp_drive_backup into an implementation and a wrapper. Switch drive_backup_prepare to use t

Re: [Qemu-block] [PATCH 06/11] qmp: Add an implementation wrapper for qmp_drive_backup

2015-03-17 Thread Max Reitz
On 2015-03-04 at 23:15, John Snow wrote: We'd like to be able to specify the callback given to backup_start manually in the case of transactions, so split apart qmp_drive_backup into an implementation and a wrapper. Switch drive_backup_prepare to use the new wrapper, but don't overload the callb