Re: [Qemu-block] [PATCH 1/5] block: Remove copy-on-read from bdrv_move_feature_fields()

2016-03-14 Thread Eric Blake
On 03/14/2016 09:44 AM, Kevin Wolf wrote: > Ever since we first introduced bdrv_append() in commit 8802d1fd ('qapi: > Introduce blockdev-group-snapshot-sync command'), the copy-on-read flag > was moved to the new top layer when taking a snapshot. The only problem > is that it doesn't make a whole l

[Qemu-block] [PATCH 1/5] block: Remove copy-on-read from bdrv_move_feature_fields()

2016-03-14 Thread Kevin Wolf
Ever since we first introduced bdrv_append() in commit 8802d1fd ('qapi: Introduce blockdev-group-snapshot-sync command'), the copy-on-read flag was moved to the new top layer when taking a snapshot. The only problem is that it doesn't make a whole lot of sense. The use case for manually enabled Co