Re: [Qemu-block] [PATCH 12/15] nbd: implement TLS support in the protocol negotiation

On Sat, Nov 28, 2015 at 11:28:55AM +0100, Wouter Verhelst wrote: > Minor nitpick: > > On Fri, Nov 27, 2015 at 12:20:50PM +, Daniel P. Berrange wrote: > [...] > > @@ -563,6 +659,14 @@ static int nbd_receive_options(NBDClient *client) > > case NBD_OPT_EXPORT_NAME: > >

Re: [Qemu-block] [PATCH 12/15] nbd: implement TLS support in the protocol negotiation

Minor nitpick: On Fri, Nov 27, 2015 at 12:20:50PM +, Daniel P. Berrange wrote: [...] > @@ -563,6 +659,14 @@ static int nbd_receive_options(NBDClient *client) > case NBD_OPT_EXPORT_NAME: > return nbd_handle_export_name(client, length); > > +case

[Qemu-block] [PATCH 12/15] nbd: implement TLS support in the protocol negotiation

This extends the NBD protocol handling code so that it is capable of negotiating TLS support during the connection setup. This involves requesting the STARTTLS protocol option before any other NBD options. Signed-off-by: Daniel P. Berrange --- block/nbd-client.c | 12 ++-