Re: [Qemu-block] [PATCH 6/7] qcow2: make qcow2_cache_put() a void function

2015-05-08 Thread Alberto Garcia
On Fri 08 May 2015 05:51:30 PM CEST, Max Reitz wrote: >> -int qcow2_cache_put(BlockDriverState *bs, Qcow2Cache *c, void **table) >> +void qcow2_cache_put(BlockDriverState *bs, Qcow2Cache *c, void **table) >> { >> int i = qcow2_cache_get_table_idx(bs, c, *table); >> >> -if (c->entrie

Re: [Qemu-block] [PATCH 6/7] qcow2: make qcow2_cache_put() a void function

2015-05-08 Thread Max Reitz
On 06.05.2015 15:39, Alberto Garcia wrote: This function never receives an invalid table pointer, so we can make it void and remove all the error checking code. Signed-off-by: Alberto Garcia --- block/qcow2-cache.c| 7 +-- block/qcow2-cluster.c | 50 ++--

[Qemu-block] [PATCH 6/7] qcow2: make qcow2_cache_put() a void function

2015-05-06 Thread Alberto Garcia
This function never receives an invalid table pointer, so we can make it void and remove all the error checking code. Signed-off-by: Alberto Garcia --- block/qcow2-cache.c| 7 +-- block/qcow2-cluster.c | 50 ++ block/qcow2-refcount.c | 29