Re: [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-05-08 Thread Dr. David Alan Gilbert
* Kevin Wolf (kw...@redhat.com) wrote: > Am 08.05.2015 um 10:42 hat Stefan Hajnoczi geschrieben: > > On Tue, May 05, 2015 at 04:23:56PM +0100, Dr. David Alan Gilbert wrote: > > > * Stefan Hajnoczi (stefa...@redhat.com) wrote: > > > > On Fri, Apr 24, 2015 at 11:36:35AM +0200, Paolo Bonzini wrote: >

Re: [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-05-08 Thread Kevin Wolf
Am 08.05.2015 um 10:42 hat Stefan Hajnoczi geschrieben: > On Tue, May 05, 2015 at 04:23:56PM +0100, Dr. David Alan Gilbert wrote: > > * Stefan Hajnoczi (stefa...@redhat.com) wrote: > > > On Fri, Apr 24, 2015 at 11:36:35AM +0200, Paolo Bonzini wrote: > > > > > > > > > > > > On 24/04/2015 11:38, We

Re: [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-05-08 Thread Dr. David Alan Gilbert
* Stefan Hajnoczi (stefa...@redhat.com) wrote: > On Tue, May 05, 2015 at 04:23:56PM +0100, Dr. David Alan Gilbert wrote: > > * Stefan Hajnoczi (stefa...@redhat.com) wrote: > > > On Fri, Apr 24, 2015 at 11:36:35AM +0200, Paolo Bonzini wrote: > > > > > > > > > > > > On 24/04/2015 11:38, Wen Congyan

Re: [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-05-08 Thread Stefan Hajnoczi
On Tue, May 05, 2015 at 04:23:56PM +0100, Dr. David Alan Gilbert wrote: > * Stefan Hajnoczi (stefa...@redhat.com) wrote: > > On Fri, Apr 24, 2015 at 11:36:35AM +0200, Paolo Bonzini wrote: > > > > > > > > > On 24/04/2015 11:38, Wen Congyang wrote: > > > >> > > > > >> > That can be done with drive

Re: [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-05-05 Thread Fam Zheng
On Wed, 05/06 02:26, Dong, Eddie wrote: > > > > -Original Message- > > From: Dr. David Alan Gilbert [mailto:dgilb...@redhat.com] > > Sent: Tuesday, May 05, 2015 11:24 PM > > To: Stefan Hajnoczi > > Cc: Paolo Bonzini; Wen Congyang; Fam Zheng; Kevin Wolf; Lai Jiangshan; qemu > > block; Jian

Re: [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-05-05 Thread Dong, Eddie
> -Original Message- > From: Dr. David Alan Gilbert [mailto:dgilb...@redhat.com] > Sent: Tuesday, May 05, 2015 11:24 PM > To: Stefan Hajnoczi > Cc: Paolo Bonzini; Wen Congyang; Fam Zheng; Kevin Wolf; Lai Jiangshan; qemu > block; Jiang, Yunhong; Dong, Eddie; qemu devel; Max Reitz; Gonglei;

Re: [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-05-05 Thread Dr. David Alan Gilbert
* Stefan Hajnoczi (stefa...@redhat.com) wrote: > On Fri, Apr 24, 2015 at 11:36:35AM +0200, Paolo Bonzini wrote: > > > > > > On 24/04/2015 11:38, Wen Congyang wrote: > > >> > > > >> > That can be done with drive-mirror. But I think it's too early for > > >> > that. > > > Do you mean use drive-m

Re: [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-30 Thread Stefan Hajnoczi
On Wed, Apr 29, 2015 at 04:37:49PM +0800, Gonglei wrote: > On 2015/4/29 16:29, Paolo Bonzini wrote: > > > > > > On 27/04/2015 11:37, Stefan Hajnoczi wrote: > But it's only for the failover case. Quorum (or a new > block/colo.c driver or filter) is fine for normal colo > operatio

Re: [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-29 Thread Paolo Bonzini
On 27/04/2015 11:37, Stefan Hajnoczi wrote: >>> But it's only for the failover case. Quorum (or a new >>> block/colo.c driver or filter) is fine for normal colo >>> operation. > Perhaps this patch series should mirror the Secondary's disk to a > Backup Secondary so that the system can be prot

Re: [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-29 Thread Gonglei
On 2015/4/29 16:29, Paolo Bonzini wrote: > > > On 27/04/2015 11:37, Stefan Hajnoczi wrote: But it's only for the failover case. Quorum (or a new block/colo.c driver or filter) is fine for normal colo operation. >> Perhaps this patch series should mirror the Secondary's disk to a

Re: [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-27 Thread Stefan Hajnoczi
On Fri, Apr 24, 2015 at 11:36:35AM +0200, Paolo Bonzini wrote: > > > On 24/04/2015 11:38, Wen Congyang wrote: > >> > > >> > That can be done with drive-mirror. But I think it's too early for that. > > Do you mean use drive-mirror instead of quorum? > > Only before starting up a new secondary.

Re: [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-24 Thread Paolo Bonzini
On 24/04/2015 11:53, Wen Congyang wrote: >> > Only before starting up a new secondary. Basically you do a migration >> > with non-shared storage, and then start the secondary in colo mode. >> > >> > But it's only for the failover case. Quorum (or a new block/colo.c >> > driver or filter) is fi

Re: [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-24 Thread Wen Congyang
On 04/24/2015 05:36 PM, Paolo Bonzini wrote: > > > On 24/04/2015 11:38, Wen Congyang wrote: That can be done with drive-mirror. But I think it's too early for that. >> Do you mean use drive-mirror instead of quorum? > > Only before starting up a new secondary. Basically you do a migr

Re: [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-24 Thread Paolo Bonzini
On 24/04/2015 11:38, Wen Congyang wrote: >> > >> > That can be done with drive-mirror. But I think it's too early for that. > Do you mean use drive-mirror instead of quorum? Only before starting up a new secondary. Basically you do a migration with non-shared storage, and then start the secon

Re: [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-24 Thread Wen Congyang
On 04/24/2015 05:04 PM, Paolo Bonzini wrote: > > > On 24/04/2015 10:58, Dr. David Alan Gilbert wrote: If we can add a filter dynamically, we can add a filter that's file is nbd dynamically after secondary qemu's nbd server is ready. In this case, I think there is no need to t

Re: [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-24 Thread Paolo Bonzini
On 24/04/2015 10:58, Dr. David Alan Gilbert wrote: >> > If we can add a filter dynamically, we can add a filter that's file is nbd >> > dynamically after secondary qemu's nbd server is ready. In this case, I >> > think >> > there is no need to touch nbd client. > Yes, I think maybe the harder pa

Re: [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-24 Thread Dr. David Alan Gilbert
* Wen Congyang (we...@cn.fujitsu.com) wrote: > On 04/24/2015 03:47 PM, Paolo Bonzini wrote: > > > > > > On 24/04/2015 04:16, Wen Congyang wrote: > >> I think the primary shouldn't do any I/O after failover (and the > >> secondary should close the NBD server) so it is probably okay to igno

Re: [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-24 Thread Wen Congyang
On 04/24/2015 03:47 PM, Paolo Bonzini wrote: > > > On 24/04/2015 04:16, Wen Congyang wrote: >> I think the primary shouldn't do any I/O after failover (and the >> secondary should close the NBD server) so it is probably okay to ignore >> the removal for now. Inserting the filter dyna

Re: [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-24 Thread Paolo Bonzini
On 24/04/2015 04:16, Wen Congyang wrote: >>> >> I think the primary shouldn't do any I/O after failover (and the >>> >> secondary should close the NBD server) so it is probably okay to ignore >>> >> the removal for now. Inserting the filter dynamically is probably >>> >> needed though. >> > >>

Re: [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-23 Thread Wen Congyang
On 04/24/2015 10:01 AM, Fam Zheng wrote: > On Thu, 04/23 14:23, Paolo Bonzini wrote: >> >> >> On 23/04/2015 14:19, Dr. David Alan Gilbert wrote: > So that means the bdrv_start_replication and bdrv_stop_replication > callbacks are more or less redundant, at least on the primary? > >

Re: [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-23 Thread Fam Zheng
On Thu, 04/23 14:23, Paolo Bonzini wrote: > > > On 23/04/2015 14:19, Dr. David Alan Gilbert wrote: > >> > So that means the bdrv_start_replication and bdrv_stop_replication > >> > callbacks are more or less redundant, at least on the primary? > >> > > >> > In fact, who calls them? Certainly not

Re: [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-23 Thread Paolo Bonzini
On 23/04/2015 14:19, Dr. David Alan Gilbert wrote: >> > So that means the bdrv_start_replication and bdrv_stop_replication >> > callbacks are more or less redundant, at least on the primary? >> > >> > In fact, who calls them? Certainly nothing in this patch set... >> > :) > In the main colo set

Re: [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-23 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > > > On 23/04/2015 14:05, Dr. David Alan Gilbert wrote: > > As presented at the moment, I don't see there's any dynamic reconfiguration > > on the primary side at the moment > > So that means the bdrv_start_replication and bdrv_stop_replication > cal

Re: [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-23 Thread Paolo Bonzini
On 23/04/2015 14:05, Dr. David Alan Gilbert wrote: > As presented at the moment, I don't see there's any dynamic reconfiguration > on the primary side at the moment So that means the bdrv_start_replication and bdrv_stop_replication callbacks are more or less redundant, at least on the primary?

Re: [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-23 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > > > On 23/04/2015 13:36, Kevin Wolf wrote: > > Crap. Then we need to figure out dynamic reconfiguration for filters > > (CCed Markus and Jeff). > > > > And this is really part of the fundamental operation mode and not just a > > way to give users a

Re: [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-23 Thread Paolo Bonzini
On 23/04/2015 13:36, Kevin Wolf wrote: > Crap. Then we need to figure out dynamic reconfiguration for filters > (CCed Markus and Jeff). > > And this is really part of the fundamental operation mode and not just a > way to give users a way to change their mind at runtime? Because if it > were, we

Re: [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-23 Thread Kevin Wolf
Am 23.04.2015 um 12:44 hat Paolo Bonzini geschrieben: > On 23/04/2015 12:40, Kevin Wolf wrote: > > The question that is still open for me is whether it would be a colo.c > > or an active-mirror.c, i.e. if this would be tied specifically to COLO > > or if it could be kept generic enough that it coul

Re: [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-23 Thread Wen Congyang
On 04/23/2015 06:44 PM, Paolo Bonzini wrote: > > > On 23/04/2015 12:40, Kevin Wolf wrote: >> The question that is still open for me is whether it would be a colo.c >> or an active-mirror.c, i.e. if this would be tied specifically to COLO >> or if it could be kept generic enough that it could be u

Re: [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-23 Thread Paolo Bonzini
On 23/04/2015 12:40, Kevin Wolf wrote: > The question that is still open for me is whether it would be a colo.c > or an active-mirror.c, i.e. if this would be tied specifically to COLO > or if it could be kept generic enough that it could be used for other > use cases as well. Understood (now).

Re: [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-23 Thread Kevin Wolf
Am 23.04.2015 um 12:33 hat Paolo Bonzini geschrieben: > On 23/04/2015 12:17, Kevin Wolf wrote: > > > Perhaps quorum is not a great match after all, and it's better to add a > > > new "colo" driver similar to quorum but simpler and only using the read > > > policy that you need for colo. The new dr

Re: [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-23 Thread Paolo Bonzini
On 23/04/2015 12:17, Kevin Wolf wrote: > > Perhaps quorum is not a great match after all, and it's better to add a > > new "colo" driver similar to quorum but simpler and only using the read > > policy that you need for colo. The new driver would also know how to > > use BDRV_O_NO_CONNECT. In a

Re: [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-23 Thread Kevin Wolf
Am 23.04.2015 um 12:05 hat Paolo Bonzini geschrieben: > > > On 23/04/2015 11:14, Wen Congyang wrote: > > The bs->file->driver should support backing file, and use backing reference > > already. > > > > What about the primary side? We should control when to connect to NBD > > server, > > not in

Re: [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-23 Thread Wen Congyang
On 04/23/2015 05:55 PM, Stefan Hajnoczi wrote: > On Wed, Apr 22, 2015 at 05:28:01PM +0800, Wen Congyang wrote: >> On 04/22/2015 05:18 PM, Stefan Hajnoczi wrote: >>> On Tue, Apr 21, 2015 at 05:28:01PM +0200, Paolo Bonzini wrote: On 21/04/2015 03:25, Wen Congyang wrote: >>> Please do not int

Re: [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-23 Thread Paolo Bonzini
On 23/04/2015 11:14, Wen Congyang wrote: > The bs->file->driver should support backing file, and use backing reference > already. > > What about the primary side? We should control when to connect to NBD server, > not in nbd_open(). My naive suggestion could be to add a BDRV_O_NO_CONNECT option

Re: [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-23 Thread Wen Congyang
On 04/23/2015 05:00 PM, Kevin Wolf wrote: > Am 22.04.2015 um 12:12 hat Paolo Bonzini geschrieben: >> On 22/04/2015 11:31, Kevin Wolf wrote: Actually I liked the "foo+colo" names. These are just internal details of the implementations and the primary/secondary disks actually can

Re: [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-23 Thread Stefan Hajnoczi
On Wed, Apr 22, 2015 at 05:28:01PM +0800, Wen Congyang wrote: > On 04/22/2015 05:18 PM, Stefan Hajnoczi wrote: > > On Tue, Apr 21, 2015 at 05:28:01PM +0200, Paolo Bonzini wrote: > >> On 21/04/2015 03:25, Wen Congyang wrote: > > Please do not introduce "+colo" block drivers. This approach is >

Re: [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-23 Thread Wen Congyang
On 04/23/2015 05:26 PM, Paolo Bonzini wrote: > > > On 23/04/2015 11:00, Kevin Wolf wrote: >> Because it may be the right design. >> >> If you're really worried about the test matrix, put a check in the >> filter block driver that its bs->file is qcow2. Of course, such an >> artificial restriction

Re: [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-23 Thread Kevin Wolf
Am 23.04.2015 um 11:26 hat Paolo Bonzini geschrieben: > > > On 23/04/2015 11:00, Kevin Wolf wrote: > > Because it may be the right design. > > > > If you're really worried about the test matrix, put a check in the > > filter block driver that its bs->file is qcow2. Of course, such an > > artific

Re: [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-23 Thread Paolo Bonzini
On 23/04/2015 11:00, Kevin Wolf wrote: > Because it may be the right design. > > If you're really worried about the test matrix, put a check in the > filter block driver that its bs->file is qcow2. Of course, such an > artificial restriction looks a bit ugly, but using a bad design just > in ord

Re: [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-23 Thread Kevin Wolf
Am 22.04.2015 um 12:12 hat Paolo Bonzini geschrieben: > On 22/04/2015 11:31, Kevin Wolf wrote: > >> Actually I liked the "foo+colo" names. > >> > >> These are just internal details of the implementations and the > >> primary/secondary disks actually can be any format. > >> > >> Stefan, what was you

Re: [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-22 Thread Dr. David Alan Gilbert
* Wen Congyang (we...@cn.fujitsu.com) wrote: > Signed-off-by: Wen Congyang > Signed-off-by: Paolo Bonzini > Signed-off-by: Yang Hongyang > Signed-off-by: zhanghailiang > Signed-off-by: Gonglei > --- > docs/block-replication.txt | 153 > + > 1 file

Re: [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-22 Thread Paolo Bonzini
On 22/04/2015 11:31, Kevin Wolf wrote: >> Actually I liked the "foo+colo" names. >> >> These are just internal details of the implementations and the >> primary/secondary disks actually can be any format. >> >> Stefan, what was your worry with the +colo block drivers? > > I haven't read the patc

Re: [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-22 Thread Wen Congyang
On 04/22/2015 05:29 PM, Stefan Hajnoczi wrote: > On Tue, Apr 21, 2015 at 09:25:59AM +0800, Wen Congyang wrote: >> On 04/20/2015 11:30 PM, Stefan Hajnoczi wrote: >>> On Fri, Apr 03, 2015 at 06:01:07PM +0800, Wen Congyang wrote: >>> One general question about the design: the Secondary host needs 3x >

Re: [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-22 Thread Kevin Wolf
Am 21.04.2015 um 17:28 hat Paolo Bonzini geschrieben: > > > On 21/04/2015 03:25, Wen Congyang wrote: > >> > Please do not introduce "+colo" block drivers. This approach is > >> > invasive and makes block replication specific to only a few block > >> > drivers, e.g. NBD or qcow2. > > NBD is used

Re: [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-22 Thread Stefan Hajnoczi
On Tue, Apr 21, 2015 at 09:25:59AM +0800, Wen Congyang wrote: > On 04/20/2015 11:30 PM, Stefan Hajnoczi wrote: > > On Fri, Apr 03, 2015 at 06:01:07PM +0800, Wen Congyang wrote: > > One general question about the design: the Secondary host needs 3x > > storage space since it has the Secondary Disk,

Re: [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-22 Thread Wen Congyang
On 04/22/2015 05:18 PM, Stefan Hajnoczi wrote: > On Tue, Apr 21, 2015 at 05:28:01PM +0200, Paolo Bonzini wrote: >> On 21/04/2015 03:25, Wen Congyang wrote: > Please do not introduce "+colo" block drivers. This approach is > invasive and makes block replication specific to only a few block

Re: [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-22 Thread Stefan Hajnoczi
On Tue, Apr 21, 2015 at 05:28:01PM +0200, Paolo Bonzini wrote: > On 21/04/2015 03:25, Wen Congyang wrote: > >> > Please do not introduce "+colo" block drivers. This approach is > >> > invasive and makes block replication specific to only a few block > >> > drivers, e.g. NBD or qcow2. > > NBD is us

Re: [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-21 Thread Paolo Bonzini
On 21/04/2015 03:25, Wen Congyang wrote: >> > Please do not introduce "+colo" block drivers. This approach is >> > invasive and makes block replication specific to only a few block >> > drivers, e.g. NBD or qcow2. > NBD is used to connect to secondary qemu, so it must be used. But the primary >

Re: [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-20 Thread Wen Congyang
On 04/20/2015 11:30 PM, Stefan Hajnoczi wrote: > On Fri, Apr 03, 2015 at 06:01:07PM +0800, Wen Congyang wrote: >> Signed-off-by: Wen Congyang >> Signed-off-by: Paolo Bonzini >> Signed-off-by: Yang Hongyang >> Signed-off-by: zhanghailiang >> Signed-off-by: Gonglei >> --- >> docs/block-replicat

Re: [Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-20 Thread Stefan Hajnoczi
On Fri, Apr 03, 2015 at 06:01:07PM +0800, Wen Congyang wrote: > Signed-off-by: Wen Congyang > Signed-off-by: Paolo Bonzini > Signed-off-by: Yang Hongyang > Signed-off-by: zhanghailiang > Signed-off-by: Gonglei > --- > docs/block-replication.txt | 153 > +++

[Qemu-block] [PATCH COLO v3 01/14] docs: block replication's description

2015-04-03 Thread Wen Congyang
Signed-off-by: Wen Congyang Signed-off-by: Paolo Bonzini Signed-off-by: Yang Hongyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei --- docs/block-replication.txt | 153 + 1 file changed, 153 insertions(+) create mode 100644 docs/block-replic