Re: [Qemu-block] [PATCH v2 05/13] block: Hide HBitmap in block dirty bitmap interface

2016-02-27 Thread Fam Zheng
On Tue, 01/26 19:02, Vladimir Sementsov-Ogievskiy wrote: > > why? The old way works for meta iters. The new code - doesn't. I suppose > > assert(iter->hbi.hb); > hbitmap_iter_init(>hbi, iter->hbi.hb, sector_num); Okay, will change. Fam

Re: [Qemu-block] [PATCH v2 05/13] block: Hide HBitmap in block dirty bitmap interface

2016-01-26 Thread Vladimir Sementsov-Ogievskiy
On 20.01.2016 09:11, Fam Zheng wrote: HBitmap is an implementation detail of block dirty bitmap that should be hidden from users. Introduce a BdrvDirtyBitmapIter to encapsulate the underlying HBitmapIter. A small difference in the interface is, before, an HBitmapIter is initialized in place,