Re: [Qemu-block] [PATCH v2 06/22] block: Add "supports_stats" field to BlockStats

2015-10-16 Thread Alberto Garcia
On Thu 15 Oct 2015 04:58:22 PM CEST, Stefan Hajnoczi wrote: >> > If I/O accounting isn't being used then all fields will be 0? >> >> Yes, but there's no way to tell if that happens because I/O >> accounting is not supported or because there hasn't been any I/O yet. >> >> There's one additional

[Qemu-block] [PATCH v2 06/22] block: Add "supports_stats" field to BlockStats

2015-10-02 Thread Alberto Garcia
query-blockstats always returns a BlockDeviceStats structure for each BDS, regardless of whether it implements accounting or not. Since the field is mandatory there's no way to tell that from the values alone. This field solves that problem by indicating which BDSs support I/O accounting.