Re: [Qemu-block] [PATCH v2 6/6] tests/block-job-txn: Don't start block job before adding to txn

2017-04-07 Thread Fam Zheng
On Fri, 04/07 14:05, John Snow wrote: > > > On 04/07/2017 09:28 AM, Stefan Hajnoczi wrote: > > On Fri, Apr 07, 2017 at 02:54:14PM +0800, Fam Zheng wrote: > >> Previously, before test_block_job_start returns, the job can already > >> complete, as a result, the transactional state of other jobs

Re: [Qemu-block] [PATCH v2 6/6] tests/block-job-txn: Don't start block job before adding to txn

2017-04-07 Thread John Snow
On 04/07/2017 09:28 AM, Stefan Hajnoczi wrote: > On Fri, Apr 07, 2017 at 02:54:14PM +0800, Fam Zheng wrote: >> Previously, before test_block_job_start returns, the job can already >> complete, as a result, the transactional state of other jobs added to >> the same txn later cannot be handled

[Qemu-block] [PATCH v2 6/6] tests/block-job-txn: Don't start block job before adding to txn

2017-04-07 Thread Fam Zheng
Previously, before test_block_job_start returns, the job can already complete, as a result, the transactional state of other jobs added to the same txn later cannot be handled correctly. Move the block_job_start() calls to callers after block_job_txn_add_job() calls. Signed-off-by: Fam Zheng