Re: [Qemu-block] [PATCH v4 3/4] block: add a 'blockdev-snapshot' QMP command

2015-09-22 Thread Alberto Garcia
On Fri 18 Sep 2015 04:49:06 PM CEST, Eric Blake wrote: >> +# @BlockdevSnapshot >> +# >> +# @device: device or node name to generate the snapshot from. > > I'm still wondering if 'node' is a better name than 'device' here. I don't have a strong preference. Kevin, Max, ... any

Re: [Qemu-block] [PATCH v4 3/4] block: add a 'blockdev-snapshot' QMP command

2015-09-22 Thread Kevin Wolf
Am 22.09.2015 um 11:21 hat Alberto Garcia geschrieben: > On Fri 18 Sep 2015 04:49:06 PM CEST, Eric Blake wrote: > > >> +# @BlockdevSnapshot > >> +# > >> +# @device: device or node name to generate the snapshot from. > > > > I'm still wondering if 'node' is a better name than

Re: [Qemu-block] [PATCH v4 3/4] block: add a 'blockdev-snapshot' QMP command

2015-09-18 Thread Max Reitz
On 14.09.2015 18:01, Alberto Garcia wrote: > One of the limitations of the 'blockdev-snapshot-sync' command is that > it does not allow passing BlockdevOptions to the newly created > snapshots, so they are always opened using the default values. > > Extending the command to allow passing options

Re: [Qemu-block] [PATCH v4 3/4] block: add a 'blockdev-snapshot' QMP command

2015-09-18 Thread Eric Blake
On 09/14/2015 10:01 AM, Alberto Garcia wrote: > One of the limitations of the 'blockdev-snapshot-sync' command is that > it does not allow passing BlockdevOptions to the newly created > snapshots, so they are always opened using the default values. > > Extending the command to allow passing

[Qemu-block] [PATCH v4 3/4] block: add a 'blockdev-snapshot' QMP command

2015-09-14 Thread Alberto Garcia
One of the limitations of the 'blockdev-snapshot-sync' command is that it does not allow passing BlockdevOptions to the newly created snapshots, so they are always opened using the default values. Extending the command to allow passing options is not a practical solution because there is overlap