Re: [Qemu-block] [PATCH v5 7/9] block: don't make snapshots for filters

2016-12-21 Thread Pavel Dovgalyuk
Kevin, > From: Kevin Wolf [mailto:kw...@redhat.com] > Am 05.12.2016 um 12:49 hat Pavel Dovgalyuk geschrieben: > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > > It's not a requirement. But to make replay deterministic we have to > > start with the same image every time. As I know, this may

Re: [Qemu-block] [PATCH v5 7/9] block: don't make snapshots for filters

2016-12-06 Thread Pavel Dovgalyuk
> From: Kevin Wolf [mailto:kw...@redhat.com] > Am 05.12.2016 um 12:49 hat Pavel Dovgalyuk geschrieben: > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > Am 05.12.2016 um 08:43 hat Pavel Dovgalyuk geschrieben: > > > Record/replay without this option uses '-snapshot' to preserve > > the state

Re: [Qemu-block] [PATCH v5 7/9] block: don't make snapshots for filters

2016-12-05 Thread Kevin Wolf
Am 05.12.2016 um 12:49 hat Pavel Dovgalyuk geschrieben: > > From: Kevin Wolf [mailto:kw...@redhat.com] > > Am 05.12.2016 um 08:43 hat Pavel Dovgalyuk geschrieben: > > > Paolo, > > > > > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > > Am 21.11.2016 um 13:22 hat Pavel Dovgalyuk geschrieben: >

Re: [Qemu-block] [PATCH v5 7/9] block: don't make snapshots for filters

2016-12-05 Thread Pavel Dovgalyuk
> From: Kevin Wolf [mailto:kw...@redhat.com] > Am 05.12.2016 um 08:43 hat Pavel Dovgalyuk geschrieben: > > Paolo, > > > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > Am 21.11.2016 um 13:22 hat Pavel Dovgalyuk geschrieben: > > > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > > > Am

Re: [Qemu-block] [PATCH v5 7/9] block: don't make snapshots for filters

2016-12-05 Thread Kevin Wolf
Am 05.12.2016 um 08:43 hat Pavel Dovgalyuk geschrieben: > Paolo, > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > Am 21.11.2016 um 13:22 hat Pavel Dovgalyuk geschrieben: > > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > > Am 16.11.2016 um 10:49 hat Pavel Dovgalyuk geschrieben: > > > >

Re: [Qemu-block] [PATCH v5 7/9] block: don't make snapshots for filters

2016-12-04 Thread Pavel Dovgalyuk
Paolo, > From: Kevin Wolf [mailto:kw...@redhat.com] > Am 21.11.2016 um 13:22 hat Pavel Dovgalyuk geschrieben: > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > Am 16.11.2016 um 10:49 hat Pavel Dovgalyuk geschrieben: > > > > > From: Pavel Dovgalyuk [mailto:dovga...@ispras.ru] > > > > > > > >

Re: [Qemu-block] [PATCH v5 7/9] block: don't make snapshots for filters

2016-11-21 Thread Kevin Wolf
Am 21.11.2016 um 13:22 hat Pavel Dovgalyuk geschrieben: > > From: Kevin Wolf [mailto:kw...@redhat.com] > > Am 16.11.2016 um 10:49 hat Pavel Dovgalyuk geschrieben: > > > > From: Pavel Dovgalyuk [mailto:dovga...@ispras.ru] > > > > > > I've investigated this issue. > > > This command line works ok: >

Re: [Qemu-block] [PATCH v5 7/9] block: don't make snapshots for filters

2016-11-21 Thread Pavel Dovgalyuk
> From: Kevin Wolf [mailto:kw...@redhat.com] > Am 16.11.2016 um 10:49 hat Pavel Dovgalyuk geschrieben: > > > From: Pavel Dovgalyuk [mailto:dovga...@ispras.ru] > > > > I've investigated this issue. > > This command line works ok: > > -drive > >

Re: [Qemu-block] [PATCH v5 7/9] block: don't make snapshots for filters

2016-11-16 Thread Pavel Dovgalyuk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > > I've investigated this issue. > > This command line works ok: > > -drive > > > > driver=blkreplay,if=none,image.driver=file,image.filename=testdisk.qcow,id=img-blkreplay > > -device ide-hd,drive=img-blkreplay > > > > And this does not: > >

Re: [Qemu-block] [PATCH v5 7/9] block: don't make snapshots for filters

2016-11-16 Thread Kevin Wolf
Am 16.11.2016 um 10:49 hat Pavel Dovgalyuk geschrieben: > > From: Pavel Dovgalyuk [mailto:dovga...@ispras.ru] > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > My command line was assuming a raw image. It looks like you're using a > > > qcow (hopefully qcow2?) image. If so, then you need to

Re: [Qemu-block] [PATCH v5 7/9] block: don't make snapshots for filters

2016-11-16 Thread Paolo Bonzini
> I've investigated this issue. > This command line works ok: > -drive > > driver=blkreplay,if=none,image.driver=file,image.filename=testdisk.qcow,id=img-blkreplay > -device ide-hd,drive=img-blkreplay > > And this does not: > -drive >

Re: [Qemu-block] [PATCH v5 7/9] block: don't make snapshots for filters

2016-11-16 Thread Pavel Dovgalyuk
Kevin, > From: Pavel Dovgalyuk [mailto:dovga...@ispras.ru] > > From: Kevin Wolf [mailto:kw...@redhat.com] > > Am 28.09.2016 um 11:32 hat Pavel Dovgalyuk geschrieben: > > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > > Am 27.09.2016 um 16:06 hat Pavel Dovgalyuk geschrieben: > > > > > >

Re: [Qemu-block] [PATCH v5 7/9] block: don't make snapshots for filters

2016-09-29 Thread Kevin Wolf
Am 28.09.2016 um 14:49 hat Pavel Dovgalyuk geschrieben: > > From: Kevin Wolf [mailto:kw...@redhat.com] > > Am 28.09.2016 um 11:32 hat Pavel Dovgalyuk geschrieben: > > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > > Am 27.09.2016 um 16:06 hat Pavel Dovgalyuk geschrieben: > > > > > > From:

Re: [Qemu-block] [PATCH v5 7/9] block: don't make snapshots for filters

2016-09-28 Thread Pavel Dovgalyuk
> From: Kevin Wolf [mailto:kw...@redhat.com] > Am 28.09.2016 um 11:32 hat Pavel Dovgalyuk geschrieben: > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > Am 27.09.2016 um 16:06 hat Pavel Dovgalyuk geschrieben: > > > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > > > Am 26.09.2016 um

Re: [Qemu-block] [PATCH v5 7/9] block: don't make snapshots for filters

2016-09-28 Thread Kevin Wolf
Am 28.09.2016 um 11:32 hat Pavel Dovgalyuk geschrieben: > > From: Kevin Wolf [mailto:kw...@redhat.com] > > Am 27.09.2016 um 16:06 hat Pavel Dovgalyuk geschrieben: > > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > > Am 26.09.2016 um 11:51 hat Pavel Dovgalyuk geschrieben: > > > > > > From:

Re: [Qemu-block] [PATCH v5 7/9] block: don't make snapshots for filters

2016-09-28 Thread Pavel Dovgalyuk
> From: Kevin Wolf [mailto:kw...@redhat.com] > Am 27.09.2016 um 16:06 hat Pavel Dovgalyuk geschrieben: > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > Am 26.09.2016 um 11:51 hat Pavel Dovgalyuk geschrieben: > > > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > > > Am 26.09.2016 um

Re: [Qemu-block] [PATCH v5 7/9] block: don't make snapshots for filters

2016-09-28 Thread Kevin Wolf
Am 27.09.2016 um 16:06 hat Pavel Dovgalyuk geschrieben: > > From: Kevin Wolf [mailto:kw...@redhat.com] > > Am 26.09.2016 um 11:51 hat Pavel Dovgalyuk geschrieben: > > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > > Am 26.09.2016 um 10:08 hat Pavel Dovgalyuk geschrieben: > > > > > This patch

Re: [Qemu-block] [PATCH v5 7/9] block: don't make snapshots for filters

2016-09-27 Thread Pavel Dovgalyuk
> From: Kevin Wolf [mailto:kw...@redhat.com] > Am 26.09.2016 um 11:51 hat Pavel Dovgalyuk geschrieben: > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > Am 26.09.2016 um 10:08 hat Pavel Dovgalyuk geschrieben: > > > > This patch disables snapshotting for block driver filters. > > > > It is

Re: [Qemu-block] [PATCH v5 7/9] block: don't make snapshots for filters

2016-09-26 Thread Kevin Wolf
Am 26.09.2016 um 11:51 hat Pavel Dovgalyuk geschrieben: > > From: Kevin Wolf [mailto:kw...@redhat.com] > > Am 26.09.2016 um 10:08 hat Pavel Dovgalyuk geschrieben: > > > This patch disables snapshotting for block driver filters. > > > It is needed, because snapshots should be created > > > in