Re: [Qemu-block] [PATCH v6 11/18] qcow2: convert QCow2 to use QCryptoBlock for encryption

2017-05-25 Thread Alberto Garcia
On Wed 24 May 2017 06:46:31 PM CEST, Daniel P. Berrange wrote: >> > +case QCOW_CRYPT_AES: >> > +if (encryptfmt && !g_str_equal(encryptfmt, "aes")) { >> > +error_setg(errp, >> > + "Header reported 'aes' encryption format but " >> > +

Re: [Qemu-block] [PATCH v6 11/18] qcow2: convert QCow2 to use QCryptoBlock for encryption

2017-05-24 Thread Daniel P. Berrange
On Thu, May 11, 2017 at 04:29:11PM +0200, Alberto Garcia wrote: > On Tue 25 Apr 2017 05:38:51 PM CEST, Daniel P. Berrange wrote: > > +switch (s->crypt_method_header) { > > +case QCOW_CRYPT_NONE: > > +if (encryptfmt) { > > +error_setg(errp, "No encryption in image

Re: [Qemu-block] [PATCH v6 11/18] qcow2: convert QCow2 to use QCryptoBlock for encryption

2017-05-11 Thread Alberto Garcia
On Tue 25 Apr 2017 05:38:51 PM CEST, Daniel P. Berrange wrote: > +switch (s->crypt_method_header) { > +case QCOW_CRYPT_NONE: > +if (encryptfmt) { > +error_setg(errp, "No encryption in image header, but options " > + "specified format '%s'",

Re: [Qemu-block] [PATCH v6 11/18] qcow2: convert QCow2 to use QCryptoBlock for encryption

2017-04-26 Thread Eric Blake
On 04/25/2017 10:38 AM, Daniel P. Berrange wrote: > This converts the qcow2 driver to make use of the QCryptoBlock > APIs for encrypting image content, using the legacyy QCow2 AES s/legacyy/legacy/ > scheme. > > With this change it is now required to use the QCryptoSecret > object for providing

[Qemu-block] [PATCH v6 11/18] qcow2: convert QCow2 to use QCryptoBlock for encryption

2017-04-25 Thread Daniel P. Berrange
This converts the qcow2 driver to make use of the QCryptoBlock APIs for encrypting image content, using the legacyy QCow2 AES scheme. With this change it is now required to use the QCryptoSecret object for providing passwords, instead of the current block password APIs / interactive prompting.