Re: [Qemu-block] [Qemu-devel] [PATCH] include: Add a comment to explain the origin of sizes' lookup table

2018-11-05 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20181103015821.30074-1-lbl...@janustech.com Subject: [Qemu-devel] [PATCH] include: Add a comment to explain the origin of sizes' lookup table === TEST SCRIPT BEGIN ===

Re: [Qemu-block] [Qemu-devel] [PATCH] include: Add a comment to explain the origin of sizes' lookup table

2018-11-05 Thread Eric Blake
On 11/2/18 8:58 PM, Leonid Bloch wrote: The lookup table for power-of-two sizes was added in commit 540b8492618eb for the purpose of having convenient shortcuts for these sizes in cases when the literal number has to be present at compile time, and expressions as '(1 * KiB)' can not be used. One

Re: [Qemu-block] [Qemu-devel] [PATCH] include: Add a comment to explain the origin of sizes' lookup table

2018-11-04 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20181103015821.30074-1-lbl...@janustech.com Subject: [Qemu-devel] [PATCH] include: Add a comment to explain the origin of sizes' lookup table === TEST SCRIPT BEGIN ===