Re: [Qemu-block] [Qemu-devel] [PATCH 2/4] qdev-properties-system: Change set_pointer's parse callback to use Error

2015-06-22 Thread Markus Armbruster
Peter Maydell writes: > On 22 June 2015 at 10:39, Markus Armbruster wrote: >> Peter Maydell writes: >> >>> Instead of having set_pointer() call a parse callback which returns >>> an error number that we then convert to an Error string with >>> error_set_from_qdev_prop_error(), make the parse ca

Re: [Qemu-block] [Qemu-devel] [PATCH 2/4] qdev-properties-system: Change set_pointer's parse callback to use Error

2015-06-22 Thread Peter Maydell
On 22 June 2015 at 10:39, Markus Armbruster wrote: > Peter Maydell writes: > >> Instead of having set_pointer() call a parse callback which returns >> an error number that we then convert to an Error string with >> error_set_from_qdev_prop_error(), make the parse callback take an >> Error** and s

Re: [Qemu-block] [Qemu-devel] [PATCH 2/4] qdev-properties-system: Change set_pointer's parse callback to use Error

2015-06-22 Thread Markus Armbruster
Peter Maydell writes: > Instead of having set_pointer() call a parse callback which returns > an error number that we then convert to an Error string with > error_set_from_qdev_prop_error(), make the parse callback take an > Error** and set the error itself. This will allow parse routines > to pr