Re: [Qemu-block] [Qemu-devel] [PATCH 4/6] block: Support streaming to an intermediate layer

2015-04-17 Thread Kevin Wolf
Am 16.04.2015 um 14:34 hat Alberto Garcia geschrieben: > On Thu 16 Apr 2015 02:27:39 PM CEST, Eric Blake wrote: > > +orig_bs_flags = bdrv_get_flags(bs); > +if (!(orig_bs_flags & BDRV_O_RDWR)) { > >>> > >>> I feel like we don't want to do this if we're not streaming to an > >>> in

Re: [Qemu-block] [Qemu-devel] [PATCH 4/6] block: Support streaming to an intermediate layer

2015-04-16 Thread Alberto Garcia
On Thu 16 Apr 2015 02:27:39 PM CEST, Eric Blake wrote: +orig_bs_flags = bdrv_get_flags(bs); +if (!(orig_bs_flags & BDRV_O_RDWR)) { >>> >>> I feel like we don't want to do this if we're not streaming to an >>> intermediate layer but to the top layer (because that means there is >>

Re: [Qemu-block] [Qemu-devel] [PATCH 4/6] block: Support streaming to an intermediate layer

2015-04-16 Thread Eric Blake
On 04/16/2015 03:36 AM, Alberto Garcia wrote: > On Wed 15 Apr 2015 06:09:18 PM CEST, Max Reitz wrote: > >>> +orig_bs_flags = bdrv_get_flags(bs); >>> +if (!(orig_bs_flags & BDRV_O_RDWR)) { >> >> I feel like we don't want to do this if we're not streaming to an >> intermediate layer but to t