Re: [Qemu-block] [Qemu-devel] [PATCH for-2.10 3/9] block: honor BDRV_O_ALLOW_RDWR when clearing bs->read_only

2017-04-05 Thread Jeff Cody
On Wed, Apr 05, 2017 at 08:20:28PM -0400, Jeff Cody wrote: > On Wed, Apr 05, 2017 at 02:26:53PM -0500, Eric Blake wrote: > > On 04/05/2017 02:20 PM, John Snow wrote: > > > > > Conceptually straightforward. > > > > > > looks like this might change behavior for... RBD and vvfat, right? > > > RBD

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.10 3/9] block: honor BDRV_O_ALLOW_RDWR when clearing bs->read_only

2017-04-05 Thread Jeff Cody
On Wed, Apr 05, 2017 at 02:26:53PM -0500, Eric Blake wrote: > On 04/05/2017 02:20 PM, John Snow wrote: > > > Conceptually straightforward. > > > > looks like this might change behavior for... RBD and vvfat, right? > > RBD is the subject of this series so we'll just assume that was broken > > and

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.10 3/9] block: honor BDRV_O_ALLOW_RDWR when clearing bs->read_only

2017-04-05 Thread Eric Blake
On 04/05/2017 02:20 PM, John Snow wrote: > Conceptually straightforward. > > looks like this might change behavior for... RBD and vvfat, right? > RBD is the subject of this series so we'll just assume that was broken > and stupid. > > What's vvfat's story? It always set the read-only property

Re: [Qemu-block] [Qemu-devel] [PATCH for-2.10 3/9] block: honor BDRV_O_ALLOW_RDWR when clearing bs->read_only

2017-04-05 Thread John Snow
On 04/05/2017 02:28 PM, Jeff Cody wrote: > The BDRV_O_ALLOW_RDWR flag allows / prohibits the changing of > the BDS 'read_only' state, but there are a few places where it > is ignored. In the bdrv_set_read_only() helper, make sure to > honor the flag. > > Signed-off-by: Jeff Cody